am335x: evm: defconfig: disable spl tiny printf
diff mbox series

Message ID 20200213133407.11477-1-moseschristopherb@gmail.com
State Rejected, archived
Delegated to: Lokesh Vutla
Headers show
Series
  • am335x: evm: defconfig: disable spl tiny printf
Related show

Commit Message

Moses Christopher Feb. 13, 2020, 1:34 p.m. UTC
From: Moses Christopher Bollavarapu <moseschristopherb@gmail.com>

  - As tiny printf lib is further optimized, the ability to deal with
    ethaddr is lost. Hence, in order to handle usb-eth boot from SPL
    we need to disable tiny printf.

  - Tested on Beagle Bone Black

Signed-off-by: Moses Christopher Bollavarapu <moseschristopherb@gmail.com>
---
 configs/am335x_evm_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Lokesh Vutla Feb. 17, 2020, 3:46 a.m. UTC | #1
On 13/02/20 7:04 PM, moseschristopherb@gmail.com wrote:
> From: Moses Christopher Bollavarapu <moseschristopherb@gmail.com>
> 
>   - As tiny printf lib is further optimized, the ability to deal with
>     ethaddr is lost. Hence, in order to handle usb-eth boot from SPL
>     we need to disable tiny printf.
> 
>   - Tested on Beagle Bone Black
> 
> Signed-off-by: Moses Christopher Bollavarapu <moseschristopherb@gmail.com>

This significantly increases the code size. Did you check how much is increased?
SPL_TINY PRINTF is enabled on am335x_evm_defconfig to reduce the code size.
Wondering what allowed to be built even after disabling tiny printf.

Thanks and regards,
Lokesh
Vignesh Raghavendra Feb. 18, 2020, 4:58 a.m. UTC | #2
On 17/02/20 9:16 am, Lokesh Vutla wrote:
> 
> 
> On 13/02/20 7:04 PM, moseschristopherb@gmail.com wrote:
>> From: Moses Christopher Bollavarapu <moseschristopherb@gmail.com>
>>
>>   - As tiny printf lib is further optimized, the ability to deal with
>>     ethaddr is lost. Hence, in order to handle usb-eth boot from SPL
>>     we need to disable tiny printf.
>>
>>   - Tested on Beagle Bone Black
>>
>> Signed-off-by: Moses Christopher Bollavarapu <moseschristopherb@gmail.com>
> 
> This significantly increases the code size. Did you check how much is increased?
> SPL_TINY PRINTF is enabled on am335x_evm_defconfig to reduce the code size.
> Wondering what allowed to be built even after disabling tiny printf.
> 

I agree with Lokesh. Fix should be to revert the change that broke tiny
printf as its breaks an already supported feature. Disabling
SPL_TINY_PRINTF bloats AM335x SPL image size which is already at limit.

Regards
Vignesh

Patch
diff mbox series

diff --git a/configs/am335x_evm_defconfig b/configs/am335x_evm_defconfig
index 335aa8cfa1..e3fbe2e5bc 100644
--- a/configs/am335x_evm_defconfig
+++ b/configs/am335x_evm_defconfig
@@ -77,6 +77,7 @@  CONFIG_USB_ETHER=y
 CONFIG_WDT=y
 # CONFIG_SPL_WDT is not set
 CONFIG_DYNAMIC_CRC_TABLE=y
+# CONFIG_SPL_USE_TINY_PRINTF is not set
 CONFIG_RSA=y
 CONFIG_LZO=y
 # CONFIG_OF_LIBFDT_OVERLAY is not set