From patchwork Fri Nov 4 22:20:41 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Torvald Riegel X-Patchwork-Id: 123709 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 07A89B6FF5 for ; Sat, 5 Nov 2011 09:21:09 +1100 (EST) Received: (qmail 26823 invoked by alias); 4 Nov 2011 22:21:07 -0000 Received: (qmail 26813 invoked by uid 22791); 4 Nov 2011 22:21:06 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Nov 2011 22:20:48 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA4MKigg015375 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 4 Nov 2011 18:20:45 -0400 Received: from [10.36.4.215] (vpn1-4-215.ams2.redhat.com [10.36.4.215]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pA4MKgEc017431; Fri, 4 Nov 2011 18:20:43 -0400 Subject: Re: [patch] 14/n: trans-mem: compiler documentation From: Torvald Riegel To: "Joseph S. Myers" Cc: Aldy Hernandez , gcc-patches , Michael Matz In-Reply-To: References: <4EB2E1D2.50309@redhat.com> Date: Fri, 04 Nov 2011 23:20:41 +0100 Message-ID: <1320445241.5756.1074.camel@triegel.csb> Mime-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Thu, 2011-11-03 at 20:24 +0000, Joseph S. Myers wrote: > On Thu, 3 Nov 2011, Aldy Hernandez wrote: > > > Index: gcc/doc/tm.texi.in > > =================================================================== > > --- gcc/doc/tm.texi.in (.../trunk) (revision 180744) > > +++ gcc/doc/tm.texi.in (.../branches/transactional-memory) (revision > > 180773) > > @@ -5696,6 +5696,16 @@ mode returned by @code{TARGET_VECTORIZE_ > > The default is zero which means to not iterate over other vector sizes. > > @end deftypefn > > > > +@hook TARGET_VECTORIZE_BUILTIN_TM_LOAD > > +This hook should return the built-in decl needed to load a vector of > > +the given type. > > +@end deftypefn > > + > > +@hook TARGET_VECTORIZE_BUILTIN_TM_STORE > > +This hook should return the built-in decl needed to store a vector of > > +the given type. > > +@end deftypefn > > Is this text based on pre-existing GFDL-only text? If not, it's better to > put it in target.def rather than directly in tm.texi.in (tm.texi.in should > preferably just have the @hook lines saying where to put the documentation > in tm.texi). Better with the attached patch? Also mentions that these hooks are for transactions. OK for branch? commit 4e9d0c618f604628065025c0ebfd5c5084ccc6a8 Author: Torvald Riegel Date: Fri Nov 4 23:16:19 2011 +0100 Move hook documentation from tm.texi.in to target.def. diff --git a/gcc/doc/tm.texi b/gcc/doc/tm.texi index 9955894..737b48e 100644 --- a/gcc/doc/tm.texi +++ b/gcc/doc/tm.texi @@ -5759,13 +5759,11 @@ The default is zero which means to not iterate over other vector sizes. @end deftypefn @deftypefn {Target Hook} tree TARGET_VECTORIZE_BUILTIN_TM_LOAD (tree) -This hook should return the built-in decl needed to load a vector of -the given type. +This hook should return the built-in decl needed to load a vector of the given type within a transaction. @end deftypefn @deftypefn {Target Hook} tree TARGET_VECTORIZE_BUILTIN_TM_STORE (tree) -This hook should return the built-in decl needed to store a vector of -the given type. +This hook should return the built-in decl needed to store a vector of the given type within a transaction. @end deftypefn @node Anchored Addresses diff --git a/gcc/doc/tm.texi.in b/gcc/doc/tm.texi.in index 0e3011a..348b7e6 100644 --- a/gcc/doc/tm.texi.in +++ b/gcc/doc/tm.texi.in @@ -5697,14 +5697,8 @@ The default is zero which means to not iterate over other vector sizes. @end deftypefn @hook TARGET_VECTORIZE_BUILTIN_TM_LOAD -This hook should return the built-in decl needed to load a vector of -the given type. -@end deftypefn @hook TARGET_VECTORIZE_BUILTIN_TM_STORE -This hook should return the built-in decl needed to store a vector of -the given type. -@end deftypefn @node Anchored Addresses @section Anchored Addresses diff --git a/gcc/target.def b/gcc/target.def index 9c14720..d6d6cc3 100644 --- a/gcc/target.def +++ b/gcc/target.def @@ -1006,7 +1006,8 @@ DEFHOOK /* Return the builtin decl needed to load a vector of TYPE. */ DEFHOOK (builtin_tm_load, - "", + "This hook should return the built-in decl needed to load a vector of the " + "given type within a transaction.", tree, (tree), default_builtin_tm_load_store) @@ -1014,7 +1015,8 @@ DEFHOOK /* Return the builtin decl needed to store a vector of TYPE. */ DEFHOOK (builtin_tm_store, - "", + "This hook should return the built-in decl needed to store a vector of the " + "given type within a transaction.", tree, (tree), default_builtin_tm_load_store)