| Message ID | 20200212095919.80295-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v1] um: Don't use console_drivers directly | expand |
On Wed, Feb 12, 2020 at 11:59:19AM +0200, Andy Shevchenko wrote: > console_drivers is kind of (semi-)private variable to the console code. > Direct use of it make us stuck with it being exported here and there. > Reduce use of console_drivers by replacing it with for_each_console(). Oops, this one is wrong, v2 has been sent.
diff --git a/arch/um/kernel/kmsg_dump.c b/arch/um/kernel/kmsg_dump.c index 98bdf69e4c2e..a8683b717f94 100644 --- a/arch/um/kernel/kmsg_dump.c +++ b/arch/um/kernel/kmsg_dump.c @@ -9,20 +9,20 @@ static void kmsg_dumper_stdout(struct kmsg_dumper *dumper, enum kmsg_dump_reason reason) { static char line[1024]; - + struct console *con; size_t len = 0; - bool con_available = false; /* only dump kmsg when no console is available */ if (!console_trylock()) return; - if (console_drivers != NULL) - con_available = true; + /* Any registered console is fine to us */ + for_each_console(con) + break; console_unlock(); - if (con_available == true) + if (con == NULL) return; printf("kmsg_dump:\n");
console_drivers is kind of (semi-)private variable to the console code. Direct use of it make us stuck with it being exported here and there. Reduce use of console_drivers by replacing it with for_each_console(). Cc: Thomas Meyer <thomas@m3y3r.de> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- arch/um/kernel/kmsg_dump.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)