From patchwork Wed Feb 12 06:53:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AceLan Kao X-Patchwork-Id: 1236648 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=L0AjrZjN; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48HVj72zFgz9sRY; Wed, 12 Feb 2020 17:53:28 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1j1ltl-0006aD-2u; Wed, 12 Feb 2020 06:53:25 +0000 Received: from mail-pl1-f195.google.com ([209.85.214.195]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1j1lth-0006ZX-OE for kernel-team@lists.ubuntu.com; Wed, 12 Feb 2020 06:53:21 +0000 Received: by mail-pl1-f195.google.com with SMTP id b22so574061pls.12 for ; Tue, 11 Feb 2020 22:53:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=hgxWyS1gfigV6y5UNCgX8+AS9ciLxR/R5VLypbJH3gI=; b=L0AjrZjND6qFiLrVucTgS4SXxkRs6CudQ+taHiQJ+M1Nn2TThi7rQyVMlmIJziOu+/ pHTW4ibdXH7HEOdbN1H5sFZxafnfT6W6ubyAiOobXIR2/KvBjN7Beum+Nk4BwiJ3jAiQ PlpBqZ2DAKsxQ62fUB9kvhIHrrpcmWQTgbe3IWWEl4UrtqsNGCi7EBBsRK5bd/uJBFSo mGUhVoCzNzku9y0KAcMlnafVRyR7FV7JPGhDyhsi3eaXFW7JjsNw+1pMvMafyG3sa5jk oQjHf7UQ4mPoXG/NTrx5ErabrOOach0SmCY7IYOUMiyLIMurmFN7TsPRz0AWvYY/THdc 7MxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=hgxWyS1gfigV6y5UNCgX8+AS9ciLxR/R5VLypbJH3gI=; b=YUjC5Fy+/zF8NAIAErNXJNHpbh1lEXIMghl4O1AhxQGJo5jNtoinrrUH7zrHiGbGNy g+uDHSDQTagSMGjwFdkli2ovfmBfOW/RectRVgvGq3ytJENkf5TLLC22g/2QyfD62CrW nz1A5IxIjrIDlqmne0VZI4X0z9JpDlmAy4PiT7FrHbw5Z4N0Yix45JPc9+yFVEq7F6G9 xL/uoegc+zKsvLWyZbp/7t3ohUAo9P32gZ6HVDl/vqcyyAN3Mnjp4OFCnTmIkuwskcCN 4phvxCmEOMUCM3nx2wqGOOZVf+JIKX9iEDFweeYkTKULPbC6VvPR1HdYNBNzsmGU9VON cpyQ== X-Gm-Message-State: APjAAAWdosan4hEtqlnOtBQt3UmCyErirIH7hW7G3bZA+rN2RVQAq4WY Sfs0thxINZRzQx0Dojm5U1/+ZyhAYds= X-Google-Smtp-Source: APXvYqx15BTmXgTzM10MbUUrVVnnM8G/PaiNXNSvo6DPa/89lt7KVh5hxCUCvoy4EWS5gV5X6+Eghg== X-Received: by 2002:a17:90a:cc10:: with SMTP id b16mr7839171pju.55.1581490400106; Tue, 11 Feb 2020 22:53:20 -0800 (PST) Received: from localhost (220-135-95-34.HINET-IP.hinet.net. [220.135.95.34]) by smtp.gmail.com with ESMTPSA id d2sm5574915pjv.18.2020.02.11.22.53.19 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Feb 2020 22:53:19 -0800 (PST) From: AceLan Kao To: kernel-team@lists.ubuntu.com Subject: [PATCH 1/1][B][E][F][OEM-OSP1-B] UBUNTU: SAUCE: platform/x86: dell-uart-backlight: increase retry times Date: Wed, 12 Feb 2020 14:53:15 +0800 Message-Id: <20200212065315.19985-2-acelan.kao@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200212065315.19985-1-acelan.kao@canonical.com> References: <20200212065315.19985-1-acelan.kao@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1862885 From ODM, scalar takes some time to activate panel during booting up, it can't respond the UART commands within 1 seconds. So, we add retry and wait 2 seconds for the response. But sometimes it still fails to read the response. During the boot up time, it sometimes takes more than 2 seconds to respond the first command, so we enlarge the retry timeout from 2 seconds to 5 seconds to make sure we get the first response from scalar. Signed-off-by: AceLan Kao --- drivers/platform/x86/dell-uart-backlight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/dell-uart-backlight.c b/drivers/platform/x86/dell-uart-backlight.c index 76e9a60a9388..bddc4f228bf9 100644 --- a/drivers/platform/x86/dell-uart-backlight.c +++ b/drivers/platform/x86/dell-uart-backlight.c @@ -318,7 +318,7 @@ static int dell_uart_get_scalar_status(struct dell_uart_backlight *dell_pdata) struct dell_uart_bl_cmd *bl_cmd = &uart_cmd[DELL_UART_GET_SCALAR]; struct uart_8250_port *uart = serial8250_get_port(dell_pdata->line); int rx_len; - int status = 0, retry = 20; + int status = 0, retry = 50; dell_uart_dump_cmd(__func__, "tx: ", bl_cmd->cmd, bl_cmd->tx_len);