Patchwork Oneiric SRU: UBUNTU: [Config] CONFIG_USB_XHCI_HCD=y

login
register
mail settings
Submitter Tim Gardner
Date Nov. 4, 2011, 3:16 p.m.
Message ID <20111104151632.8EC54F88D3@lochsa.rtg.net>
Download mbox | patch
Permalink /patch/123655/
State New
Headers show

Comments

Tim Gardner - Nov. 4, 2011, 3:16 p.m.
From 06ae856e4c3a67d01f54081bf6dad19a3c9d913f Mon Sep 17 00:00:00 2001
From: Tim Gardner <tim.gardner@canonical.com>
Date: Fri, 4 Nov 2011 09:13:03 -0600
Subject: [PATCH] UBUNTU: [Config] CONFIG_USB_XHCI_HCD=y

BugLink: http://bugs.launchpad.net/bugs/886167

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
 debian.master/config/config.common.ubuntu |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Brad Figg - Nov. 4, 2011, 3:25 p.m.
On 11/04/2011 11:16 AM, Tim Gardner wrote:
>  From 06ae856e4c3a67d01f54081bf6dad19a3c9d913f Mon Sep 17 00:00:00 2001
> From: Tim Gardner<tim.gardner@canonical.com>
> Date: Fri, 4 Nov 2011 09:13:03 -0600
> Subject: [PATCH] UBUNTU: [Config] CONFIG_USB_XHCI_HCD=y
>
> BugLink: http://bugs.launchpad.net/bugs/886167
>
> Signed-off-by: Tim Gardner<tim.gardner@canonical.com>
> ---
>   debian.master/config/config.common.ubuntu |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index cc47909..a08c943 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -5514,7 +5514,7 @@ CONFIG_USB_WHCI_HCD=m
>   CONFIG_USB_WUSB=m
>   CONFIG_USB_WUSB_CBAF=m
>   # CONFIG_USB_WUSB_CBAF_DEBUG is not set
> -CONFIG_USB_XHCI_HCD=m
> +CONFIG_USB_XHCI_HCD=y
>   # CONFIG_USB_XHCI_HCD_DEBUGGING is not set
>   CONFIG_USB_XUSBATM=m
>   CONFIG_USB_YUREX=m

Neither the bug nor the commit contain the standard SRU boilerplate.

However, this s a trivial fix that looks like it does what is intended.
Acked-by: Brad Figg <brad.figg@canonical.com>
Stefan Bader - Nov. 4, 2011, 3:28 p.m.
On 04.11.2011 11:16, Tim Gardner wrote:
> From 06ae856e4c3a67d01f54081bf6dad19a3c9d913f Mon Sep 17 00:00:00 2001
> From: Tim Gardner <tim.gardner@canonical.com>
> Date: Fri, 4 Nov 2011 09:13:03 -0600
> Subject: [PATCH] UBUNTU: [Config] CONFIG_USB_XHCI_HCD=y
> 
> BugLink: http://bugs.launchpad.net/bugs/886167
> 
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> ---
>  debian.master/config/config.common.ubuntu |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index cc47909..a08c943 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -5514,7 +5514,7 @@ CONFIG_USB_WHCI_HCD=m
>  CONFIG_USB_WUSB=m
>  CONFIG_USB_WUSB_CBAF=m
>  # CONFIG_USB_WUSB_CBAF_DEBUG is not set
> -CONFIG_USB_XHCI_HCD=m
> +CONFIG_USB_XHCI_HCD=y
>  # CONFIG_USB_XHCI_HCD_DEBUGGING is not set
>  CONFIG_USB_XUSBATM=m
>  CONFIG_USB_YUREX=m

Actually I think that at least currently usb 3.0 needs to be unloaded to avoid
suspend resume problems...
Andy Whitcroft - Nov. 8, 2011, 10:01 a.m.
On Fri, Nov 04, 2011 at 11:28:12AM -0400, Stefan Bader wrote:
> On 04.11.2011 11:16, Tim Gardner wrote:
> > From 06ae856e4c3a67d01f54081bf6dad19a3c9d913f Mon Sep 17 00:00:00 2001
> > From: Tim Gardner <tim.gardner@canonical.com>
> > Date: Fri, 4 Nov 2011 09:13:03 -0600
> > Subject: [PATCH] UBUNTU: [Config] CONFIG_USB_XHCI_HCD=y
> > 
> > BugLink: http://bugs.launchpad.net/bugs/886167
> > 
> > Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> > ---
> >  debian.master/config/config.common.ubuntu |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> > index cc47909..a08c943 100644
> > --- a/debian.master/config/config.common.ubuntu
> > +++ b/debian.master/config/config.common.ubuntu
> > @@ -5514,7 +5514,7 @@ CONFIG_USB_WHCI_HCD=m
> >  CONFIG_USB_WUSB=m
> >  CONFIG_USB_WUSB_CBAF=m
> >  # CONFIG_USB_WUSB_CBAF_DEBUG is not set
> > -CONFIG_USB_XHCI_HCD=m
> > +CONFIG_USB_XHCI_HCD=y
> >  # CONFIG_USB_XHCI_HCD_DEBUGGING is not set
> >  CONFIG_USB_XUSBATM=m
> >  CONFIG_USB_YUREX=m
> 
> Actually I think that at least currently usb 3.0 needs to be unloaded to avoid
> suspend resume problems...

Someone at UDS indicated that they were still seeing intermittant hangs
on suspend/resume which were fixed by removing this module during
suspend.  I did request a bug be filed though I have not yet seen it.

-apw
Colin King - Nov. 8, 2011, 1:21 p.m.
On 08/11/11 10:01, Andy Whitcroft wrote:
> On Fri, Nov 04, 2011 at 11:28:12AM -0400, Stefan Bader wrote:
>> On 04.11.2011 11:16, Tim Gardner wrote:
>>> From 06ae856e4c3a67d01f54081bf6dad19a3c9d913f Mon Sep 17 00:00:00 2001
>>> From: Tim Gardner <tim.gardner@canonical.com>
>>> Date: Fri, 4 Nov 2011 09:13:03 -0600
>>> Subject: [PATCH] UBUNTU: [Config] CONFIG_USB_XHCI_HCD=y
>>>
>>> BugLink: http://bugs.launchpad.net/bugs/886167
>>>
>>> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
>>> ---
>>>  debian.master/config/config.common.ubuntu |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
>>> index cc47909..a08c943 100644
>>> --- a/debian.master/config/config.common.ubuntu
>>> +++ b/debian.master/config/config.common.ubuntu
>>> @@ -5514,7 +5514,7 @@ CONFIG_USB_WHCI_HCD=m
>>>  CONFIG_USB_WUSB=m
>>>  CONFIG_USB_WUSB_CBAF=m
>>>  # CONFIG_USB_WUSB_CBAF_DEBUG is not set
>>> -CONFIG_USB_XHCI_HCD=m
>>> +CONFIG_USB_XHCI_HCD=y
>>>  # CONFIG_USB_XHCI_HCD_DEBUGGING is not set
>>>  CONFIG_USB_XUSBATM=m
>>>  CONFIG_USB_YUREX=m
>> Actually I think that at least currently usb 3.0 needs to be unloaded to avoid
>> suspend resume problems...
> Someone at UDS indicated that they were still seeing intermittant hangs
> on suspend/resume which were fixed by removing this module during
> suspend.  I did request a bug be filed though I have not yet seen it.
>
> -apw
>
USB 3.0 on Oneiric required unloading/loading over S3 on several
machines that I've looked at over the past few months.

Colin
Tim Gardner - Nov. 8, 2011, 1:39 p.m.
On 11/08/2011 06:21 AM, Colin Ian King wrote:
> On 08/11/11 10:01, Andy Whitcroft wrote:
>> On Fri, Nov 04, 2011 at 11:28:12AM -0400, Stefan Bader wrote:
>>> On 04.11.2011 11:16, Tim Gardner wrote:
>>>>  From 06ae856e4c3a67d01f54081bf6dad19a3c9d913f Mon Sep 17 00:00:00 2001
>>>> From: Tim Gardner<tim.gardner@canonical.com>
>>>> Date: Fri, 4 Nov 2011 09:13:03 -0600
>>>> Subject: [PATCH] UBUNTU: [Config] CONFIG_USB_XHCI_HCD=y
>>>>
>>>> BugLink: http://bugs.launchpad.net/bugs/886167
>>>>
>>>> Signed-off-by: Tim Gardner<tim.gardner@canonical.com>
>>>> ---
>>>>   debian.master/config/config.common.ubuntu |    2 +-
>>>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
>>>> index cc47909..a08c943 100644
>>>> --- a/debian.master/config/config.common.ubuntu
>>>> +++ b/debian.master/config/config.common.ubuntu
>>>> @@ -5514,7 +5514,7 @@ CONFIG_USB_WHCI_HCD=m
>>>>   CONFIG_USB_WUSB=m
>>>>   CONFIG_USB_WUSB_CBAF=m
>>>>   # CONFIG_USB_WUSB_CBAF_DEBUG is not set
>>>> -CONFIG_USB_XHCI_HCD=m
>>>> +CONFIG_USB_XHCI_HCD=y
>>>>   # CONFIG_USB_XHCI_HCD_DEBUGGING is not set
>>>>   CONFIG_USB_XUSBATM=m
>>>>   CONFIG_USB_YUREX=m
>>> Actually I think that at least currently usb 3.0 needs to be unloaded to avoid
>>> suspend resume problems...
>> Someone at UDS indicated that they were still seeing intermittant hangs
>> on suspend/resume which were fixed by removing this module during
>> suspend.  I did request a bug be filed though I have not yet seen it.
>>
>> -apw
>>
> USB 3.0 on Oneiric required unloading/loading over S3 on several
> machines that I've looked at over the past few months.
>
> Colin
>

OK - I'll drop this for now.

rtg

Patch

diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index cc47909..a08c943 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -5514,7 +5514,7 @@  CONFIG_USB_WHCI_HCD=m
 CONFIG_USB_WUSB=m
 CONFIG_USB_WUSB_CBAF=m
 # CONFIG_USB_WUSB_CBAF_DEBUG is not set
-CONFIG_USB_XHCI_HCD=m
+CONFIG_USB_XHCI_HCD=y
 # CONFIG_USB_XHCI_HCD_DEBUGGING is not set
 CONFIG_USB_XUSBATM=m
 CONFIG_USB_YUREX=m