| Message ID | 20200211163452.25442-3-frieder.schrempf@kontron.de |
|---|---|
| State | Changes Requested |
| Delegated to: | Miquel Raynal |
| Headers | show |
| Series | mtd: spinand: Fix reading and writing of bad block markers | expand |
On Tue, 11 Feb 2020 16:35:43 +0000 Schrempf Frieder <frieder.schrempf@kontron.de> wrote: > From: Frieder Schrempf <frieder.schrempf@kontron.de> > > When writing the bad block marker to the OOB area the access mode > should be set to MTD_OPS_RAW as it is done for reading the marker. > Currently this only works because req.mode is initialized to > MTD_OPS_PLACE_OOB (0) and spinand_write_to_cache_op() checks for > req.mode != MTD_OPS_AUTO_OOB. > > Fix this by explicitly setting req.mode to MTD_OPS_RAW. > > Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs") > Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> > --- > drivers/mtd/nand/spi/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c > index 5d267a67a5f7..925db6269861 100644 > --- a/drivers/mtd/nand/spi/core.c > +++ b/drivers/mtd/nand/spi/core.c > @@ -609,6 +609,7 @@ static int spinand_markbad(struct nand_device *nand, const struct nand_pos *pos) > .ooboffs = 0, > .ooblen = 2, > .oobbuf.out = marker, > + .mode = MTD_OPS_RAW, > }; > int ret; >
diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c index 5d267a67a5f7..925db6269861 100644 --- a/drivers/mtd/nand/spi/core.c +++ b/drivers/mtd/nand/spi/core.c @@ -609,6 +609,7 @@ static int spinand_markbad(struct nand_device *nand, const struct nand_pos *pos) .ooboffs = 0, .ooblen = 2, .oobbuf.out = marker, + .mode = MTD_OPS_RAW, }; int ret;