diff mbox

[U-Boot,2/3] net/altera_tse: use flush_dcache_range instead of flush_dcache

Message ID 1320410288-15008-3-git-send-email-stefan.kristiansson@saunalahti.fi
State Accepted
Commit ee04a1048e73a5d9c359caa6f44a73329699aaa8
Delegated to: Joe Hershberger
Headers show

Commit Message

Stefan Kristiansson Nov. 4, 2011, 12:38 p.m. UTC
flush_dcache is not declared in the common.h API,
flush_dcache_range however is

Signed-off-by: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
Cc: Ben Warren <biggerbadderben@gmail.com>
Cc: Thomas Chou <thomas@wytron.com.tw>
---
 drivers/net/altera_tse.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

Comments

Thomas Chou Nov. 10, 2011, 9:14 a.m. UTC | #1
On 11/04/2011 08:38 PM, Stefan Kristiansson wrote:
> flush_dcache is not declared in the common.h API,
> flush_dcache_range however is
>
> Signed-off-by: Stefan Kristiansson<stefan.kristiansson@saunalahti.fi>
> Cc: Ben Warren<biggerbadderben@gmail.com>
> Cc: Thomas Chou<thomas@wytron.com.tw>
> ---
>   drivers/net/altera_tse.c |    9 ++++++---
>   1 files changed, 6 insertions(+), 3 deletions(-)

Acked-by: Thomas Chou <thomas@wytron.com.tw>

>
> diff --git a/drivers/net/altera_tse.c b/drivers/net/altera_tse.c
> index 5b00717..0e6aac7 100644
> --- a/drivers/net/altera_tse.c
> +++ b/drivers/net/altera_tse.c
> @@ -268,7 +268,8 @@ static int tse_eth_send(struct eth_device *dev,
>   	volatile struct alt_sgdma_descriptor *tx_desc_cur =
>   	    (volatile struct alt_sgdma_descriptor *)&tx_desc[0];
>
> -	flush_dcache((unsigned long)packet, length);
> +	flush_dcache_range((unsigned long)packet,
> +			(unsigned long)packet + length);
>   	alt_sgdma_construct_descriptor_burst(
>   		(volatile struct alt_sgdma_descriptor *)&tx_desc[0],
>   		(volatile struct alt_sgdma_descriptor *)&tx_desc[1],
> @@ -306,7 +307,8 @@ static int tse_eth_rx(struct eth_device *dev)
>   		NetReceive(NetRxPackets[0], packet_length);
>
>   		/* start descriptor again */
> -		flush_dcache((unsigned long)(NetRxPackets[0]), PKTSIZE_ALIGN);
> +		flush_dcache_range((unsigned long)(NetRxPackets[0]),
> +			(unsigned long)(NetRxPackets[0]) + PKTSIZE_ALIGN);
>   		alt_sgdma_construct_descriptor_burst(
>   			(volatile struct alt_sgdma_descriptor *)&rx_desc[0],
>   			(volatile struct alt_sgdma_descriptor *)&rx_desc[1],
> @@ -834,7 +836,8 @@ static int tse_eth_init(struct eth_device *dev, bd_t * bd)
>   		0x0	/* channel */
>   		);
>   	debug("Configuring rx desc\n");
> -	flush_dcache((unsigned long)(NetRxPackets[0]), PKTSIZE_ALIGN);
> +	flush_dcache_range((unsigned long)(NetRxPackets[0]),
> +			(unsigned long)(NetRxPackets[0]) + PKTSIZE_ALIGN);
>   	alt_sgdma_construct_descriptor_burst(
>   		(volatile struct alt_sgdma_descriptor *)&rx_desc[0],
>   		(volatile struct alt_sgdma_descriptor *)&rx_desc[1],
Wolfgang Denk March 30, 2012, 9:58 p.m. UTC | #2
Dear Stefan Kristiansson,

In message <1320410288-15008-3-git-send-email-stefan.kristiansson@saunalahti.fi> you wrote:
> flush_dcache is not declared in the common.h API,
> flush_dcache_range however is
> 
> Signed-off-by: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
> Cc: Ben Warren <biggerbadderben@gmail.com>
> Cc: Thomas Chou <thomas@wytron.com.tw>
> ---
>  drivers/net/altera_tse.c |    9 ++++++---
>  1 files changed, 6 insertions(+), 3 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk
diff mbox

Patch

diff --git a/drivers/net/altera_tse.c b/drivers/net/altera_tse.c
index 5b00717..0e6aac7 100644
--- a/drivers/net/altera_tse.c
+++ b/drivers/net/altera_tse.c
@@ -268,7 +268,8 @@  static int tse_eth_send(struct eth_device *dev,
 	volatile struct alt_sgdma_descriptor *tx_desc_cur =
 	    (volatile struct alt_sgdma_descriptor *)&tx_desc[0];
 
-	flush_dcache((unsigned long)packet, length);
+	flush_dcache_range((unsigned long)packet,
+			(unsigned long)packet + length);
 	alt_sgdma_construct_descriptor_burst(
 		(volatile struct alt_sgdma_descriptor *)&tx_desc[0],
 		(volatile struct alt_sgdma_descriptor *)&tx_desc[1],
@@ -306,7 +307,8 @@  static int tse_eth_rx(struct eth_device *dev)
 		NetReceive(NetRxPackets[0], packet_length);
 
 		/* start descriptor again */
-		flush_dcache((unsigned long)(NetRxPackets[0]), PKTSIZE_ALIGN);
+		flush_dcache_range((unsigned long)(NetRxPackets[0]),
+			(unsigned long)(NetRxPackets[0]) + PKTSIZE_ALIGN);
 		alt_sgdma_construct_descriptor_burst(
 			(volatile struct alt_sgdma_descriptor *)&rx_desc[0],
 			(volatile struct alt_sgdma_descriptor *)&rx_desc[1],
@@ -834,7 +836,8 @@  static int tse_eth_init(struct eth_device *dev, bd_t * bd)
 		0x0	/* channel */
 		);
 	debug("Configuring rx desc\n");
-	flush_dcache((unsigned long)(NetRxPackets[0]), PKTSIZE_ALIGN);
+	flush_dcache_range((unsigned long)(NetRxPackets[0]),
+			(unsigned long)(NetRxPackets[0]) + PKTSIZE_ALIGN);
 	alt_sgdma_construct_descriptor_burst(
 		(volatile struct alt_sgdma_descriptor *)&rx_desc[0],
 		(volatile struct alt_sgdma_descriptor *)&rx_desc[1],