diff mbox

[U-Boot,1/3] net/ethoc: use flush_dcache_range instead of flush_dcache

Message ID 1320410288-15008-2-git-send-email-stefan.kristiansson@saunalahti.fi
State Accepted
Commit 83ea1308537aabb5fd72a11cd9bada9d8496d585
Delegated to: Joe Hershberger
Headers show

Commit Message

Stefan Kristiansson Nov. 4, 2011, 12:38 p.m. UTC 
flush_dcache is not declared in the common.h API,
flush_dcache_range however is

Signed-off-by: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
Cc: Ben Warren <biggerbadderben@gmail.com>
Cc: Thomas Chou <thomas@wytron.com.tw>
---
 drivers/net/ethoc.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Comments

Thomas Chou Nov. 10, 2011, 9:12 a.m. UTC | #1 
On 11/04/2011 08:38 PM, Stefan Kristiansson wrote:
> flush_dcache is not declared in the common.h API,
> flush_dcache_range however is
>
> Signed-off-by: Stefan Kristiansson<stefan.kristiansson@saunalahti.fi>
> Cc: Ben Warren<biggerbadderben@gmail.com>
> Cc: Thomas Chou<thomas@wytron.com.tw>
> ---
>   drivers/net/ethoc.c |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)

Acked-by: Thomas Chou <thomas@wytron.com.tw>

>
> diff --git a/drivers/net/ethoc.c b/drivers/net/ethoc.c
> index 7ac9025..cb79753 100644
> --- a/drivers/net/ethoc.c
> +++ b/drivers/net/ethoc.c
> @@ -272,7 +272,7 @@ static int ethoc_init_ring(struct eth_device *dev)
>   		if (i == priv->num_rx - 1)
>   			bd.stat |= RX_BD_WRAP;
>
> -		flush_dcache(bd.addr, PKTSIZE_ALIGN);
> +		flush_dcache_range(bd.addr, bd.addr + PKTSIZE_ALIGN);
>   		ethoc_write_bd(dev, priv->num_tx + i,&bd);
>   	}
>
> @@ -377,7 +377,7 @@ static int ethoc_rx(struct eth_device *dev, int limit)
>   		}
>
>   		/* clear the buffer descriptor so it can be reused */
> -		flush_dcache(bd.addr, PKTSIZE_ALIGN);
> +		flush_dcache_range(bd.addr, bd.addr + PKTSIZE_ALIGN);
>   		bd.stat&= ~RX_BD_STATS;
>   		bd.stat |= RX_BD_EMPTY;
>   		ethoc_write_bd(dev, entry,&bd);
> @@ -431,7 +431,7 @@ static int ethoc_send(struct eth_device *dev, volatile void *packet, int length)
>   		bd.stat&= ~TX_BD_PAD;
>   	bd.addr = (u32)packet;
>
> -	flush_dcache(bd.addr, length);
> +	flush_dcache_range(bd.addr, bd.addr + length);
>   	bd.stat&= ~(TX_BD_STATS | TX_BD_LEN_MASK);
>   	bd.stat |= TX_BD_LEN(length);
>   	ethoc_write_bd(dev, entry,&bd);
Wolfgang Denk March 30, 2012, 9:58 p.m. UTC | #2 
Dear Stefan Kristiansson,

In message <1320410288-15008-2-git-send-email-stefan.kristiansson@saunalahti.fi> you wrote:
> flush_dcache is not declared in the common.h API,
> flush_dcache_range however is
> 
> Signed-off-by: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
> Cc: Ben Warren <biggerbadderben@gmail.com>
> Cc: Thomas Chou <thomas@wytron.com.tw>
> ---
>  drivers/net/ethoc.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk
diff mbox

Patch

diff --git a/drivers/net/ethoc.c b/drivers/net/ethoc.c
index 7ac9025..cb79753 100644
--- a/drivers/net/ethoc.c
+++ b/drivers/net/ethoc.c
@@ -272,7 +272,7 @@  static int ethoc_init_ring(struct eth_device *dev)
 		if (i == priv->num_rx - 1)
 			bd.stat |= RX_BD_WRAP;
 
-		flush_dcache(bd.addr, PKTSIZE_ALIGN);
+		flush_dcache_range(bd.addr, bd.addr + PKTSIZE_ALIGN);
 		ethoc_write_bd(dev, priv->num_tx + i, &bd);
 	}
 
@@ -377,7 +377,7 @@  static int ethoc_rx(struct eth_device *dev, int limit)
 		}
 
 		/* clear the buffer descriptor so it can be reused */
-		flush_dcache(bd.addr, PKTSIZE_ALIGN);
+		flush_dcache_range(bd.addr, bd.addr + PKTSIZE_ALIGN);
 		bd.stat &= ~RX_BD_STATS;
 		bd.stat |= RX_BD_EMPTY;
 		ethoc_write_bd(dev, entry, &bd);
@@ -431,7 +431,7 @@  static int ethoc_send(struct eth_device *dev, volatile void *packet, int length)
 		bd.stat &= ~TX_BD_PAD;
 	bd.addr = (u32)packet;
 
-	flush_dcache(bd.addr, length);
+	flush_dcache_range(bd.addr, bd.addr + length);
 	bd.stat &= ~(TX_BD_STATS | TX_BD_LEN_MASK);
 	bd.stat |= TX_BD_LEN(length);
 	ethoc_write_bd(dev, entry, &bd);