[2/3] pwm: imx27: Don't disable clks at device remove time
diff mbox series

Message ID 20200210212240.25513-3-u.kleine-koenig@pengutronix.de
State New
Headers show
  • pwm: imx27: fix clk handling
Related show

Commit Message

Uwe Kleine-König Feb. 10, 2020, 9:22 p.m. UTC
The .remove() callback is not supposed to modify hardware state. This is
in the responsibility of the PWM consumer.

After the PWM was disabled the clks are off (apart from a bug that is
fixed in the next patch), so unbinding the driver either stops the PWM
(which it should not) or disables already disabled clks yielding
warnings from the clk core.

So just drop the call to disable the clocks. (Which BTW was also in the
wrong order because the call makes the PWM unfunctional and so should
have come only after pwmchip_remove().

Fixes: 9f4c8f9607c3 ("pwm: imx: Add ipg clock operation")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
 drivers/pwm/pwm-imx27.c | 2 --
 1 file changed, 2 deletions(-)

diff mbox series

diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c
index e04ae566bbf9..fb142813d455 100644
--- a/drivers/pwm/pwm-imx27.c
+++ b/drivers/pwm/pwm-imx27.c
@@ -358,8 +358,6 @@  static int pwm_imx27_remove(struct platform_device *pdev)
 	imx = platform_get_drvdata(pdev);
-	pwm_imx27_clk_disable_unprepare(imx);
 	return pwmchip_remove(&imx->chip);