ARM: dts: sun5i: Add dts for inet86v_rev2
diff mbox series

Message ID 20200210103552.3210406-1-agriveaux@deutnet.info
State Changes Requested
Headers show
Series
  • ARM: dts: sun5i: Add dts for inet86v_rev2
Related show

Checks

Context Check Description
robh/dt-meta-schema success
robh/checkpatch warning "total: 0 errors, 2 warnings, 28 lines checked"

Commit Message

Alexandre GRIVEAUX Feb. 10, 2020, 10:35 a.m. UTC
From: Alexandre GRIVEAUX <agriveaux@deutnet.info>

Add Inet 86V Rev 2 support, based upon Inet 86VS.

Missing things:
- Accelerometer (MXC6225X)
- Touchpanel (Sitronix SL1536)
- Nand (29F32G08CBACA)
- Camera (HCWY0308)

Signed-off-by: Alexandre GRIVEAUX <agriveaux@deutnet.info>
---
 .../devicetree/bindings/arm/sunxi.yaml          |  5 +++++
 arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts   | 17 +++++++++++++++++
 2 files changed, 22 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts

Comments

Maxime Ripard Feb. 11, 2020, 1:15 p.m. UTC | #1
On Mon, Feb 10, 2020 at 11:35:52AM +0100, agriveaux@deutnet.info wrote:
> From: Alexandre GRIVEAUX <agriveaux@deutnet.info>
>
> Add Inet 86V Rev 2 support, based upon Inet 86VS.
>
> Missing things:
> - Accelerometer (MXC6225X)
> - Touchpanel (Sitronix SL1536)
> - Nand (29F32G08CBACA)
> - Camera (HCWY0308)
>
> Signed-off-by: Alexandre GRIVEAUX <agriveaux@deutnet.info>

Please read the documentation I sent you yesterday. In particular,
when submitting multiple versions, you should remove have the version
number in the title and a changelog.

Also, please ask questions if you're unsure about something, or
discuss something you do not agree with instead of ignoring the
comment.

Maxime
Alexandre GRIVEAUX Feb. 12, 2020, 9:45 a.m. UTC | #2
Le 11/02/2020 à 14:15, Maxime Ripard a écrit :
> On Mon, Feb 10, 2020 at 11:35:52AM +0100, agriveaux@deutnet.info wrote:
>> From: Alexandre GRIVEAUX <agriveaux@deutnet.info>
>>
>> Add Inet 86V Rev 2 support, based upon Inet 86VS.
>>
>> Missing things:
>> - Accelerometer (MXC6225X)
>> - Touchpanel (Sitronix SL1536)
>> - Nand (29F32G08CBACA)
>> - Camera (HCWY0308)
>>
>> Signed-off-by: Alexandre GRIVEAUX <agriveaux@deutnet.info>
> Please read the documentation I sent you yesterday. In particular,
> when submitting multiple versions, you should remove have the version
> number in the title and a changelog.
>
> Also, please ask questions if you're unsure about something, or
> discuss something you do not agree with instead of ignoring the
> comment.
>
> Maxime

Hello,


Seem I misusing 'git send-email' because i already changed the subject
line (same apply to u-boot):

git send-email --from agriveaux@deutnet.info --to
robh+dt@kernel.org,mark.rutland@arm.com,mripard@kernel.org,wens@csie.org
--cc
linux-kernel@vger.kernel.org,devicetree@vger.kernel.org,agriveaux@deutnet.info
--subject '[v2] ARM: dts: sun5i: Add dts for inet86v_rev2' --compose
/tmp/linux/0001-ARM-dts-sun5i-Add-dts-for-inet86v_rev2.patch

It's the first time i use git send-email, previously i used mutt to send
patchsets (on mips mostly).


Effectively i've forgot the changelog...


At why do we need another device tree:

inet86vs use a GSL1680 touchpanel controller and 4GB nand [0]

inet86vsuse a Sitonix SL1536 touchpanel controller and 8GB nand (can
have 16GB nand)[1]


Seem i've forgot to use:

git format-patch --subject-prefix="PATCH v2"


Thanks.

[0]https://fccid.io/2AARJ-AP7S118/Schematics/Schematics-2042312.pdfinet86vs
schematic

[1]https://fccid.io/XHW026/Schematics/Schematics-1820577.pdfinet86v
schematic
Maxime Ripard Feb. 14, 2020, 1:17 p.m. UTC | #3
Hi,

On Wed, Feb 12, 2020 at 10:45:03AM +0100, Alexandre GRIVEAUX wrote:
> Le 11/02/2020 à 14:15, Maxime Ripard a écrit :
> > On Mon, Feb 10, 2020 at 11:35:52AM +0100, agriveaux@deutnet.info wrote:
> >> From: Alexandre GRIVEAUX <agriveaux@deutnet.info>
> >>
> >> Add Inet 86V Rev 2 support, based upon Inet 86VS.
> >>
> >> Missing things:
> >> - Accelerometer (MXC6225X)
> >> - Touchpanel (Sitronix SL1536)
> >> - Nand (29F32G08CBACA)
> >> - Camera (HCWY0308)
> >>
> >> Signed-off-by: Alexandre GRIVEAUX <agriveaux@deutnet.info>
> > Please read the documentation I sent you yesterday. In particular,
> > when submitting multiple versions, you should remove have the version
> > number in the title and a changelog.
> >
> > Also, please ask questions if you're unsure about something, or
> > discuss something you do not agree with instead of ignoring the
> > comment.
> >
> > Maxime
>
>
> Seem I misusing 'git send-email' because i already changed the subject
> line (same apply to u-boot):
>
> git send-email --from agriveaux@deutnet.info --to
> robh+dt@kernel.org,mark.rutland@arm.com,mripard@kernel.org,wens@csie.org
> --cc
> linux-kernel@vger.kernel.org,devicetree@vger.kernel.org,agriveaux@deutnet.info
> --subject '[v2] ARM: dts: sun5i: Add dts for inet86v_rev2' --compose
> /tmp/linux/0001-ARM-dts-sun5i-Add-dts-for-inet86v_rev2.patch
>
> It's the first time i use git send-email, previously i used mutt to send
> patchsets (on mips mostly).
>
>
> Effectively i've forgot the changelog...

A simpler way, especially for a single patch, would be to use

git send-email -v2 --to $recipients --annotate $COMMIT^..$COMMIT

You can even keep the change log in the commit log itself by using ---
as a separator, so something like:

ARM: dts: my super title

Some nice awesome change

---

Changes from v1:
  - Whatever.

> At why do we need another device tree:
>
> inet86vs use a GSL1680 touchpanel controller and 4GB nand [0]
>
> inet86vsuse a Sitonix SL1536 touchpanel controller and 8GB nand (can
> have 16GB nand)[1]

NAND size will be discovered so it's not really a concern. For the
touchscreen, you should make that clear in your commit log.

Maxime

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
index 327ce6730823..af0db1fe69c9 100644
--- a/Documentation/devicetree/bindings/arm/sunxi.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
@@ -282,6 +282,11 @@  properties:
           - const: primux,inet86dz
           - const: allwinner,sun8i-a23
 
+      - description: iNet-86V Rev 02
+        items:
+          - const: primux,inet86v-rev2
+          - const: allwinner,sun5i-a13
+
       - description: iNet-9F Rev 03
         items:
           - const: inet-tek,inet9f-rev03
diff --git a/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts b/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts
new file mode 100644
index 000000000000..9b4c5349f048
--- /dev/null
+++ b/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts
@@ -0,0 +1,17 @@ 
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2020 Alexandre Griveaux <agriveaux@deutnet.info>
+ *
+ * Minimal dts file for the iNet 86V
+ */
+
+/dts-v1/;
+
+#include "sun5i-a13.dtsi"
+#include "sun5i-reference-design-tablet.dtsi"
+
+/ {
+	model = "iNET 86V Rev 02";
+	compatible = "primux,inet86v-rev2", "allwinner,sun5i-a13";
+
+};