diff mbox series

[4/4] mtd: rawnand: cadence: reinit complete before execute command

Message ID 1581328530-29966-4-git-send-email-piotrs@cadence.com
State Accepted
Headers show
Series [1/4] mtd: rawnand: cadence: get meta data size from registers | expand

Commit Message

Piotr Sroka Feb. 10, 2020, 9:55 a.m. UTC 
Reinitilaize complete object before executing CDMA command to make sure
that done flag is ok.

Signed-off-by: Piotr Sroka <piotrs@cadence.com>
---
 drivers/mtd/nand/raw/cadence-nand-controller.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Miquel Raynal Feb. 18, 2020, 10:48 a.m. UTC | #1 
Hi Piotr,

Piotr Sroka <piotrs@cadence.com> wrote on Mon, 10 Feb 2020 10:55:28
+0100:

> Reinitilaize complete object before executing CDMA command to make sure
> that done flag is ok.

Looks fine, besides the need for Fixes/Stable tags, what do you think?

> 
> Signed-off-by: Piotr Sroka <piotrs@cadence.com>
> ---
>  drivers/mtd/nand/raw/cadence-nand-controller.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/nand/raw/cadence-nand-controller.c b/drivers/mtd/nand/raw/cadence-nand-controller.c
> index 5c1bbb05ab51..efddc5c68afb 100644
> --- a/drivers/mtd/nand/raw/cadence-nand-controller.c
> +++ b/drivers/mtd/nand/raw/cadence-nand-controller.c
> @@ -998,6 +998,7 @@ static int cadence_nand_cdma_send(struct cdns_nand_ctrl *cdns_ctrl,
>  		return status;
>  
>  	cadence_nand_reset_irq(cdns_ctrl);
> +	reinit_completion(&cdns_ctrl->complete);
>  
>  	writel_relaxed((u32)cdns_ctrl->dma_cdma_desc,
>  		       cdns_ctrl->reg + CMD_REG2);

Thanks,
Miquèl
Miquel Raynal March 10, 2020, 6:29 p.m. UTC | #2 
On Mon, 2020-02-10 at 09:55:28 UTC, Piotr Sroka wrote:
> Reinitilaize complete object before executing CDMA command to make sure
> that done flag is ok.
> 
> Signed-off-by: Piotr Sroka <piotrs@cadence.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel
diff mbox series

Patch

diff --git a/drivers/mtd/nand/raw/cadence-nand-controller.c b/drivers/mtd/nand/raw/cadence-nand-controller.c
index 5c1bbb05ab51..efddc5c68afb 100644
--- a/drivers/mtd/nand/raw/cadence-nand-controller.c
+++ b/drivers/mtd/nand/raw/cadence-nand-controller.c
@@ -998,6 +998,7 @@  static int cadence_nand_cdma_send(struct cdns_nand_ctrl *cdns_ctrl,
 		return status;
 
 	cadence_nand_reset_irq(cdns_ctrl);
+	reinit_completion(&cdns_ctrl->complete);
 
 	writel_relaxed((u32)cdns_ctrl->dma_cdma_desc,
 		       cdns_ctrl->reg + CMD_REG2);