[next] nf_tables: make the symbol 'nft_pipapo_get' static
diff mbox series

Message ID 20200210085109.13954-1-chenwandun@huawei.com
State Accepted
Delegated to: Pablo Neira
Headers show
Series
  • [next] nf_tables: make the symbol 'nft_pipapo_get' static
Related show

Commit Message

Chen Wandun Feb. 10, 2020, 8:51 a.m. UTC
Fix the following sparse warning:

net/netfilter/nft_set_pipapo.c:739:6: warning: symbol 'nft_pipapo_get' was not declared. Should it be static?

Fixes: 3c4287f62044 ("nf_tables: Add set type for arbitrary concatenation of ranges")
Signed-off-by: Chen Wandun <chenwandun@huawei.com>
---
 net/netfilter/nft_set_pipapo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Stefano Brivio Feb. 10, 2020, 3:12 p.m. UTC | #1
On Mon, 10 Feb 2020 16:51:09 +0800
Chen Wandun <chenwandun@huawei.com> wrote:

> Fix the following sparse warning:
> 
> net/netfilter/nft_set_pipapo.c:739:6: warning: symbol 'nft_pipapo_get' was not declared. Should it be static?

Whoops, thanks for fixing this.

> Fixes: 3c4287f62044 ("nf_tables: Add set type for arbitrary concatenation of ranges")
> Signed-off-by: Chen Wandun <chenwandun@huawei.com>

Acked-by: Stefano Brivio <sbrivio@redhat.com>

Patch
diff mbox series

diff --git a/net/netfilter/nft_set_pipapo.c b/net/netfilter/nft_set_pipapo.c
index f0cb1e13af50..f5b9bb6bfcc3 100644
--- a/net/netfilter/nft_set_pipapo.c
+++ b/net/netfilter/nft_set_pipapo.c
@@ -736,8 +736,8 @@  static struct nft_pipapo_elem *pipapo_get(const struct net *net,
  * @elem:	nftables API element representation containing key data
  * @flags:	Unused
  */
-void *nft_pipapo_get(const struct net *net, const struct nft_set *set,
-		     const struct nft_set_elem *elem, unsigned int flags)
+static void *nft_pipapo_get(const struct net *net, const struct nft_set *set,
+			    const struct nft_set_elem *elem, unsigned int flags)
 {
 	return pipapo_get(net, set, (const u8 *)elem->key.val.data,
 			  nft_genmask_cur(net));