| Message ID | 20200210011441.147102-1-yaohongbo@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | [bpf-next] bpf: make btf_check_func_type_match() static | expand |
On 2/10/20 2:14 AM, Hongbo Yao wrote: > Fix sparse warning: > kernel/bpf/btf.c:4131:5: warning: symbol 'btf_check_func_type_match' was > not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Hongbo Yao <yaohongbo@huawei.com> Given this fixes a warning, applied to bpf.
diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c index 8c9d8f266bef..f24868a4176a 100644 --- a/kernel/bpf/btf.c +++ b/kernel/bpf/btf.c @@ -4144,9 +4144,9 @@ int btf_distill_func_proto(struct bpf_verifier_log *log, * EFAULT - verifier bug * 0 - 99% match. The last 1% is validated by the verifier. */ -int btf_check_func_type_match(struct bpf_verifier_log *log, - struct btf *btf1, const struct btf_type *t1, - struct btf *btf2, const struct btf_type *t2) +static int btf_check_func_type_match(struct bpf_verifier_log *log, + struct btf *btf1, const struct btf_type *t1, + struct btf *btf2, const struct btf_type *t2) { const struct btf_param *args1, *args2; const char *fn1, *fn2, *s1, *s2;
Fix sparse warning: kernel/bpf/btf.c:4131:5: warning: symbol 'btf_check_func_type_match' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Hongbo Yao <yaohongbo@huawei.com> --- kernel/bpf/btf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)