From patchwork Mon Feb 10 01:05:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 1235582 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-109337-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha1 header.s=default header.b=EO1aU2XB; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48G74Y1j4Lz9sRR for ; Mon, 10 Feb 2020 12:05:33 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; q=dns; s= default; b=oOPSHenLw37pDwcgKLgq4J16CEMzMMfiwExKl1T1v3rbcdCmmtJXc /EduPk7ZWX9lH80Zn+lbWmbkQwkAT66CM7EGkLveDFoEY2i0X8g0KTGUGNGUwkcH fqqeCEiNcTBovE9vj9PrBbtu5KtOocw83U8tafRk9iDdmpX/leXKjg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; s=default; bh=ZXVNPRz6hS2vYiypCVeSrkPCXD0=; b=EO1aU2XBqSCGR2aN0gXjrY2A2XZv 742HjMxPB09+g3Loa13ZRR7bNoClkSKTFeyxAuOYKxYm98ITJmyjoR95rEjjJmn0 Ixteg9uBAuDn6JQZ+nxGqKHKSAacvTeCqXJwR2uUqNeK5UOe/mM7h2RAgqi1il16 ja19gNN1NAcN3U0= Received: (qmail 95871 invoked by alias); 10 Feb 2020 01:05:18 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 95818 invoked by uid 89); 10 Feb 2020 01:05:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL autolearn=ham version=3.3.1 spammy=H*MI:sk:2020021 X-HELO: hera.aquilenet.fr From: Samuel Thibault To: libc-alpha@sourceware.org Cc: Samuel Thibault , commit-hurd@gnu.org Subject: [hurd, commited 02/10] htl: Add support for libc cancellation points Date: Mon, 10 Feb 2020 02:05:00 +0100 Message-Id: <20200210010508.428251-2-samuel.thibault@ens-lyon.org> In-Reply-To: <20200210010508.428251-1-samuel.thibault@ens-lyon.org> References: <20200210010508.428251-1-samuel.thibault@ens-lyon.org> MIME-Version: 1.0 --- htl/Makefile | 1 + htl/Versions | 2 ++ htl/cancellation.c | 45 +++++++++++++++++++++++++++++++ htl/pt-testcancel.c | 3 ++- sysdeps/htl/pthreadP.h | 1 + sysdeps/mach/hurd/sysdep-cancel.h | 20 ++++++++++++-- 6 files changed, 69 insertions(+), 3 deletions(-) create mode 100644 htl/cancellation.c diff --git a/htl/Makefile b/htl/Makefile index b2dc797ee4..1b33748934 100644 --- a/htl/Makefile +++ b/htl/Makefile @@ -132,6 +132,7 @@ libpthread-routines := pt-attr pt-attr-destroy pt-attr-getdetachstate \ \ shm-directory \ \ + cancellation \ cthreads-compat \ herrno \ $(SYSDEPS) diff --git a/htl/Versions b/htl/Versions index 4f5f727753..1ec6f363d5 100644 --- a/htl/Versions +++ b/htl/Versions @@ -168,6 +168,8 @@ libpthread { __pthread_mutex_init; __pthread_mutex_destroy; __pthread_mutex_timedlock; + __pthread_enable_asynccancel; + __pthread_disable_asynccancel; _pthread_mutex_lock; _pthread_mutex_trylock; _pthread_mutex_unlock; _pthread_rwlock_destroy; _pthread_rwlock_init; diff --git a/htl/cancellation.c b/htl/cancellation.c new file mode 100644 index 0000000000..598f911d91 --- /dev/null +++ b/htl/cancellation.c @@ -0,0 +1,45 @@ +/* Set the cancel type during blocking calls. + Copyright (C) 2020 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include +#include + +int __pthread_enable_asynccancel (void) +{ + struct __pthread *p = _pthread_self (); + int oldtype; + + __pthread_mutex_lock (&p->cancel_lock); + oldtype = p->cancel_type; + p->cancel_type = PTHREAD_CANCEL_ASYNCHRONOUS; + __pthread_mutex_unlock (&p->cancel_lock); + + __pthread_testcancel (); + + return oldtype; +} + +void __pthread_disable_asynccancel (int oldtype) +{ + struct __pthread *p = _pthread_self (); + + __pthread_mutex_lock (&p->cancel_lock); + p->cancel_type = oldtype; + __pthread_mutex_unlock (&p->cancel_lock); +} diff --git a/htl/pt-testcancel.c b/htl/pt-testcancel.c index 1ec324b95f..37326280ee 100644 --- a/htl/pt-testcancel.c +++ b/htl/pt-testcancel.c @@ -22,7 +22,7 @@ #include void -pthread_testcancel (void) +__pthread_testcancel (void) { struct __pthread *p = _pthread_self (); int cancelled; @@ -34,3 +34,4 @@ pthread_testcancel (void) if (cancelled) __pthread_exit (PTHREAD_CANCELED); } +strong_alias (__pthread_testcancel, pthread_testcancel) diff --git a/sysdeps/htl/pthreadP.h b/sysdeps/htl/pthreadP.h index 7de96120a4..2bb4baa249 100644 --- a/sysdeps/htl/pthreadP.h +++ b/sysdeps/htl/pthreadP.h @@ -84,6 +84,7 @@ int __pthread_attr_setstacksize (pthread_attr_t *__attr, size_t __stacksize); int __pthread_attr_setstack (pthread_attr_t *__attr, void *__stackaddr, size_t __stacksize); int __pthread_attr_getstack (const pthread_attr_t *, void **, size_t *); +void __pthread_testcancel (void); #if IS_IN (libpthread) hidden_proto (__pthread_key_create) diff --git a/sysdeps/mach/hurd/sysdep-cancel.h b/sysdeps/mach/hurd/sysdep-cancel.h index f686a39024..669c17151a 100644 --- a/sysdeps/mach/hurd/sysdep-cancel.h +++ b/sysdeps/mach/hurd/sysdep-cancel.h @@ -1,8 +1,24 @@ #include +int __pthread_enable_asynccancel (void); +void __pthread_disable_asynccancel (int oldtype); + +#pragma weak __pthread_enable_asynccancel +#pragma weak __pthread_disable_asynccancel + /* Always multi-thread (since there's at least the sig handler), but no handling enabled. */ #define SINGLE_THREAD_P (0) #define RTLD_SINGLE_THREAD_P (0) -#define LIBC_CANCEL_ASYNC() 0 /* Just a dummy value. */ -#define LIBC_CANCEL_RESET(val) ((void)(val)) /* Nothing, but evaluate it. */ + +#define LIBC_CANCEL_ASYNC() ({ \ + int __cancel_oldtype = 0; \ + if (__pthread_enable_asynccancel) \ + __cancel_oldtype = __pthread_enable_asynccancel(); \ + __cancel_oldtype; \ +}) + +#define LIBC_CANCEL_RESET(val) do { \ + if (__pthread_disable_asynccancel) \ + __pthread_disable_asynccancel (val); \ +} while (0)