[v2] gpio: ich: fix a typo
diff mbox series

Message ID 20200209111620.97423-1-sachinagarwal@sachins-MacBook-2.local
State New
Headers show
Series
  • [v2] gpio: ich: fix a typo
Related show

Commit Message

sachin agarwal Feb. 9, 2020, 11:16 a.m. UTC
From: sachin agarwal <asachin591@gmail.com>

We had written "Mangagment" rather than "Management".

Signed-off-by: Sachin Agarwal <asachin591@gmail.com>
---
 drivers/gpio/gpio-ich.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bartosz Golaszewski Feb. 10, 2020, 9:54 a.m. UTC | #1
niedz., 9 lut 2020 o 12:16 sachin agarwal <asachin591@gmail.com> napisał(a):
>
> From: sachin agarwal <asachin591@gmail.com>
>
> We had written "Mangagment" rather than "Management".
>
> Signed-off-by: Sachin Agarwal <asachin591@gmail.com>
> ---
>  drivers/gpio/gpio-ich.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-ich.c b/drivers/gpio/gpio-ich.c
> index 2f086d0aa1f4..9960bb8b0f5b 100644
> --- a/drivers/gpio/gpio-ich.c
> +++ b/drivers/gpio/gpio-ich.c
> @@ -89,7 +89,7 @@ static struct {
>         struct device *dev;
>         struct gpio_chip chip;
>         struct resource *gpio_base;     /* GPIO IO base */
> -       struct resource *pm_base;       /* Power Mangagment IO base */
> +       struct resource *pm_base;       /* Power Management IO base */
>         struct ichx_desc *desc; /* Pointer to chipset-specific description */
>         u32 orig_gpio_ctrl;     /* Orig CTRL value, used to restore on exit */
>         u8 use_gpio;            /* Which GPIO groups are usable */
> --
> 2.24.1
>

I'm seeing that you have been sending a lot of these single typo
fixes. This is polluting the history and I'm not a fan of that.

Linus: what is your policy on this?

Bartosz
Andy Shevchenko Feb. 10, 2020, 10:13 a.m. UTC | #2
On Mon, Feb 10, 2020 at 10:54:37AM +0100, Bartosz Golaszewski wrote:
> niedz., 9 lut 2020 o 12:16 sachin agarwal <asachin591@gmail.com> napisał(a):

> I'm seeing that you have been sending a lot of these single typo
> fixes. This is polluting the history and I'm not a fan of that.
> 
> Linus: what is your policy on this?

Side note from Intel developer(s):
Whatever you decide I would like to have Intel GPIO patches to be seen
separately, so, we handle them thru our trees.

Since it's only one patch now for me, I'll take it.
Linus Walleij Feb. 10, 2020, 12:06 p.m. UTC | #3
On Mon, Feb 10, 2020 at 10:54 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> niedz., 9 lut 2020 o 12:16 sachin agarwal <asachin591@gmail.com> napisał(a):
> >
> > From: sachin agarwal <asachin591@gmail.com>
> >
> > We had written "Mangagment" rather than "Management".
> >
> > Signed-off-by: Sachin Agarwal <asachin591@gmail.com>
> > ---
> >  drivers/gpio/gpio-ich.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpio/gpio-ich.c b/drivers/gpio/gpio-ich.c
> > index 2f086d0aa1f4..9960bb8b0f5b 100644
> > --- a/drivers/gpio/gpio-ich.c
> > +++ b/drivers/gpio/gpio-ich.c
> > @@ -89,7 +89,7 @@ static struct {
> >         struct device *dev;
> >         struct gpio_chip chip;
> >         struct resource *gpio_base;     /* GPIO IO base */
> > -       struct resource *pm_base;       /* Power Mangagment IO base */
> > +       struct resource *pm_base;       /* Power Management IO base */
> >         struct ichx_desc *desc; /* Pointer to chipset-specific description */
> >         u32 orig_gpio_ctrl;     /* Orig CTRL value, used to restore on exit */
> >         u8 use_gpio;            /* Which GPIO groups are usable */
> > --
> > 2.24.1
> >
>
> I'm seeing that you have been sending a lot of these single typo
> fixes. This is polluting the history and I'm not a fan of that.
>
> Linus: what is your policy on this?

I don't really have one, I think it's usually nice to do as a drive-by
change when fixing something else. I like what is said about
fixing whitespace and codingstyle issues in the document
Documentation/process/2.Process.rst heading
"Getting started with Kernel development":

  Individual developers are often, understandably, at a loss for a place to
  start.  Beginning with a large project can be intimidating; one often wants
  to test the waters with something smaller first.  This is the point where
  some developers jump into the creation of patches fixing spelling errors or
  minor coding style issues.  Unfortunately, such patches create a level of
  noise which is distracting for the development community as a whole, so,
  increasingly, they are looked down upon.  New developers wishing to
  introduce themselves to the community will not get the sort of reception
  they wish for by these means.

(Jonathan Corbet)

I recommend newcomers to read the whole document, or their
contributions might get increasingly ignored.

Yours,
Linus Walleij

Patch
diff mbox series

diff --git a/drivers/gpio/gpio-ich.c b/drivers/gpio/gpio-ich.c
index 2f086d0aa1f4..9960bb8b0f5b 100644
--- a/drivers/gpio/gpio-ich.c
+++ b/drivers/gpio/gpio-ich.c
@@ -89,7 +89,7 @@  static struct {
 	struct device *dev;
 	struct gpio_chip chip;
 	struct resource *gpio_base;	/* GPIO IO base */
-	struct resource *pm_base;	/* Power Mangagment IO base */
+	struct resource *pm_base;	/* Power Management IO base */
 	struct ichx_desc *desc;	/* Pointer to chipset-specific description */
 	u32 orig_gpio_ctrl;	/* Orig CTRL value, used to restore on exit */
 	u8 use_gpio;		/* Which GPIO groups are usable */