From patchwork Thu Nov 3 22:26:43 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: 1/n: trans-mem: libitm runtime tests Date: Thu, 03 Nov 2011 12:26:43 -0000 From: Aldy Hernandez X-Patchwork-Id: 123519 Message-Id: <4EB31523.2050700@redhat.com> To: Jeff Law Cc: gcc-patches On 11/03/11 15:33, Jeff Law wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 11/03/11 11:44, Aldy Hernandez wrote: >> These are all new files, thus require no ChangeLog entries (for >> the tests themselves anyhow). However, I will post a separate >> ChangeLog for the entire libitm. > Note copyright dates... Make sure they're not something like, umm, > 1997 :-) Fixed everywhere in libitm. > > testsuite/config/default.exp > > >> +# Copyright (C) 1997 Free Software Foundation, Inc. Fixed. > I'm going to assume the tests themselves are good. It'd be nice if > they all stated what they were testing, but I don't consider that a > requirement. If the tests were written independently rather than > extracted from another blob of code, you may consider adding a > copyright notice to them. Hmm, we based a lot of the original skeleton from libgomp, and AFAICT only one test has a copyright notice: libgomp.c/sort-1.c If you feel strongly about this, I can add a copyright notice to every test, after I finish all the other recommendations elsewhere. > Others have already noted the g-fortran dependency, which seems odd. > I think if that's cleaned up this stuff would be OK. rth is taking care of that. Committing the attached patch to the branch. * testsuite/config/default.exp: Update copyright date. * configure.ac: Add copyright info. * configure.tgt: Same. Index: configure.ac =================================================================== --- configure.ac (revision 180772) +++ configure.ac (working copy) @@ -1,4 +1,19 @@ # Process this file with autoreconf to produce a configure script. +# Copyright (C) 2011 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. AC_PREREQ(2.59) AC_INIT([GNU TM Runtime Library], 1.0,,[libitm]) Index: configure.tgt =================================================================== --- configure.tgt (revision 180744) +++ configure.tgt (working copy) @@ -1,4 +1,20 @@ # -*- shell-script -*- +# Copyright (C) 2011 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. + # This is the target specific configuration file. This is invoked by the # autoconf generated configure script. Putting it in a separate shell file # lets us skip running autoconf when modifying target specific information. Index: testsuite/config/default.exp =================================================================== --- testsuite/config/default.exp (revision 180744) +++ testsuite/config/default.exp (working copy) @@ -1,4 +1,4 @@ -# Copyright (C) 1997 Free Software Foundation, Inc. +# Copyright (C) 2011 Free Software Foundation, Inc. # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by