| Message ID | 20200206113328.7296-2-bage@linutronix.de |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | dts: Add Linutronix Testbox | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
On Thu, 6 Feb 2020 12:33:23 +0100, bage@linutronix.de wrote: > From: Bastian Germann <bage@linutronix.de> > > Add a vendor prefix for lx, known as Linutronix GmbH. > Website: https://linutronix.de/ > > Co-developed-by: Benedikt Spranger <b.spranger@linutronix.de> > Signed-off-by: Benedikt Spranger <b.spranger@linutronix.de> > Signed-off-by: Bastian Germann <bage@linutronix.de> > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Applied, thanks. Rob
Hi, On Thu, Feb 06, 2020 at 12:33:23PM +0100, bage@linutronix.de wrote: > From: Bastian Germann <bage@linutronix.de> > > Add a vendor prefix for lx, known as Linutronix GmbH. > Website: https://linutronix.de/ > > Co-developed-by: Benedikt Spranger <b.spranger@linutronix.de> > Signed-off-by: Benedikt Spranger <b.spranger@linutronix.de> > Signed-off-by: Bastian Germann <bage@linutronix.de> > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > index 7fcd48adc276..f6fea38b0848 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > @@ -561,6 +561,8 @@ patternProperties: > description: LSI Corp. (LSI Logic) > "^lwn,.*": > description: Liebherr-Werk Nenzing GmbH > + "^lx,.*": > + description: Linutronix GmbH Vendor names are usually either the vendor name itself or the stock name, so you should really use linutronix here Maxime
On Mon, Feb 10, 2020 at 1:43 AM Maxime Ripard <maxime@cerno.tech> wrote: > > Hi, > > On Thu, Feb 06, 2020 at 12:33:23PM +0100, bage@linutronix.de wrote: > > From: Bastian Germann <bage@linutronix.de> > > > > Add a vendor prefix for lx, known as Linutronix GmbH. > > Website: https://linutronix.de/ > > > > Co-developed-by: Benedikt Spranger <b.spranger@linutronix.de> > > Signed-off-by: Benedikt Spranger <b.spranger@linutronix.de> > > Signed-off-by: Bastian Germann <bage@linutronix.de> > > --- > > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > index 7fcd48adc276..f6fea38b0848 100644 > > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > @@ -561,6 +561,8 @@ patternProperties: > > description: LSI Corp. (LSI Logic) > > "^lwn,.*": > > description: Liebherr-Werk Nenzing GmbH > > + "^lx,.*": > > + description: Linutronix GmbH > > Vendor names are usually either the vendor name itself or the stock > name, so you should really use linutronix here Good point. I hadn't pushed this out, so I've dropped it until sorted. Rob
On Mon, 10 Feb 2020 08:43:10 +0100 Maxime Ripard <maxime@cerno.tech> wrote: > Vendor names are usually either the vendor name itself or the stock > name, so you should really use linutronix here May you kindly enlighten me why? "lx" is used internaly and externaly in projects, publications, contracts, etc. as common abbreviation by the Linutronix GmbH. Therefore it was self-evident to use this abbreviation in the device tree. As I did not found any documented rule in the kernel documentation, which denote a restriction for the vendor abbreviation in the device tree bindings the decision for "lx" was clear. A quick look into "Documentation/devicetree/bindings/vendor-prefixes.yaml" assured me in the decision to use "lx". Here some example not fitting your rule: "^ad,.*": "^adi,.*": "^al,.*": "^anvo,.*": ... In summary I would be encouraged if "lx" gets in, as it is *our* abbreviation. Regards Benedikt Spranger
On Wed, Feb 12, 2020 at 10:39:42AM +0100, Benedikt Spranger wrote: > On Mon, 10 Feb 2020 08:43:10 +0100 > Maxime Ripard <maxime@cerno.tech> wrote: > > > Vendor names are usually either the vendor name itself or the stock > > name, so you should really use linutronix here > > May you kindly enlighten me why? > > "lx" is used internaly and externaly in projects, publications, > contracts, etc. as common abbreviation by the Linutronix GmbH. > Therefore it was self-evident to use this abbreviation in the device > tree. Googling "linutronix lx" returns approximately 0 meaningful results, so it's really not "common", at least externally. "lx linux" doesn't return much either. > As I did not found any documented rule in the kernel documentation, > which denote a restriction for the vendor abbreviation in the device > tree bindings the decision for "lx" was clear. It's in the devicetree specification: https://github.com/devicetree-org/devicetree-specification/releases/download/v0.2/devicetree-specification-v0.2.pdf Section 2.3: Standard Properties "The recommended format is "manufacturer,model", where manufacturer is a string describing the name of the manufacturer (such as a stock ticker symbol)" > A quick look into > "Documentation/devicetree/bindings/vendor-prefixes.yaml" > assured me in the decision to use "lx". > Here some example not fitting your rule: > "^ad,.*": > "^adi,.*": https://www.nasdaq.com/market-activity/stocks/adi > "^al,.*": > "^anvo,.*": That's the name of the company > ... > > In summary I would be encouraged if "lx" gets in, as it is *our* > abbreviation. How using the name of your company that *everybody* knows it by would be discouraging? Maxime
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index 7fcd48adc276..f6fea38b0848 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -561,6 +561,8 @@ patternProperties: description: LSI Corp. (LSI Logic) "^lwn,.*": description: Liebherr-Werk Nenzing GmbH + "^lx,.*": + description: Linutronix GmbH "^macnica,.*": description: Macnica Americas "^mapleboard,.*":