Patchwork ARM : mx35: 3ds-board: add framebuffer device

login
register
mail settings
Submitter wu guoxing
Date Nov. 3, 2011, 5:56 a.m.
Message ID <1320299797-23167-1-git-send-email-b39297@freescale.com>
Download mbox | patch
Permalink /patch/123404/
State New
Headers show

Comments

wu guoxing - Nov. 3, 2011, 5:56 a.m.
This patch adds framebuffer support for freescale mx35 3ds board

Signed-off-by: Wu Guoxing <b39297@freescale.com>
---
 arch/arm/mach-imx/mach-mx35_3ds.c |   99 +++++++++++++++++++++++++++++++++++++
 1 files changed, 99 insertions(+), 0 deletions(-)
Sascha Hauer - Nov. 3, 2011, 7:18 a.m.
On Thu, Nov 03, 2011 at 01:56:37PM +0800, wu guoxing wrote:
> This patch adds framebuffer support for freescale mx35 3ds board
> 
> Signed-off-by: Wu Guoxing <b39297@freescale.com>
> ---
>  arch/arm/mach-imx/mach-mx35_3ds.c |   99 +++++++++++++++++++++++++++++++++++++
>  1 files changed, 99 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/mach-mx35_3ds.c b/arch/arm/mach-imx/mach-mx35_3ds.c
> index 5a5eb3e..e7889ca 100644
> --- a/arch/arm/mach-imx/mach-mx35_3ds.c
> +++ b/arch/arm/mach-imx/mach-mx35_3ds.c
> @@ -40,9 +40,74 @@
>  #include <mach/iomux-mx35.h>
>  #include <mach/irqs.h>
>  #include <mach/3ds_debugboard.h>
> +#include <video/platform_lcd.h>
>  
>  #include "devices-imx35.h"
>  
> +static const struct fb_videomode fb_modedb[] = {
> +	{
> +	 /* 800x480 @ 55 Hz */
> +	 .name = "Ceramate-CLAA070VC01",
> +	 .refresh = 55,
> +	 .xres = 800,
> +	 .yres = 480,
> +	 .pixclock = 40000,
> +	 .left_margin = 40,
> +	 .right_margin = 40,
> +	 .upper_margin = 5,
> +	 .lower_margin = 5,
> +	 .hsync_len = 20,
> +	 .vsync_len = 10,
> +	 .sync = FB_SYNC_OE_ACT_HIGH,
> +	 .vmode = FB_VMODE_NONINTERLACED,
> +	 .flag = 0,
> +	 },
> +};
> +
> +static const struct ipu_platform_data mx3_ipu_data __initconst = {
> +	.irq_base = MXC_IPU_IRQ_START,
> +};
> +
> +static struct mx3fb_platform_data mx3fb_pdata __initdata = {
> +	.name = "Ceramate-CLAA070VC01",
> +	.mode = fb_modedb,
> +	.num_modes = ARRAY_SIZE(fb_modedb),
> +};
> +
> +static struct i2c_board_info __initdata mc9s08dz60_i2c_device = {
> +	I2C_BOARD_INFO("mc9s08dz60", 0x69),
> +};
> +
> +static struct i2c_client *mc9s08dz60_client;
> +
> +static void mx35_3ds_lcd_set_power(struct plat_lcd_data *pd, unsigned int power)
> +{
> +	u8 temp;
> +
> +	if (!mc9s08dz60_client) {
> +		mc9s08dz60_client =
> +		    i2c_new_device(i2c_get_adapter(0), &mc9s08dz60_i2c_device);
> +	}
> +	if (mc9s08dz60_client) {
> +		temp = (u8) i2c_smbus_read_byte_data(mc9s08dz60_client, 0x20);
> +		if (power)
> +			temp |= (1 << 6);
> +		else
> +			temp &= ~(1 << 6);
> +
> +		i2c_smbus_write_byte_data(mc9s08dz60_client, 0x20, temp);
> +	}
> +}

The mc9s08dz60 is a RTC/Touchscreen/GPIO chip. You should write a driver
for it instead of adding a quick hack in the board code.

>  
>  static void __init mx35pdk_timer_init(void)
> @@ -225,3 +323,4 @@ MACHINE_START(MX35_3DS, "Freescale MX35PDK")
>  	.timer = &mx35pdk_timer,
>  	.init_machine = mx35_3ds_init,
>  MACHINE_END
> +

Please don't add blank lines to files.

Sascha
wu guoxing - Nov. 3, 2011, 8:01 a.m.
Hi Sascha:
  The mc9s08dz60 is a MCU, and its function depend on the code flashed in it. so, it is not a common chip.
it is only for mx35 3ds board, a driver for it will be useless for others, that's why I didn't write a common
driver for it, as it will never be used in any other freescale board. But, if you insist, I will write a driver for it.
  For the Blank line, I will remove it.

-----Original Message-----
From: Sascha Hauer [mailto:s.hauer@pengutronix.de] 
Sent: Thursday, November 03, 2011 3:18 PM
To: Wu Guoxing-B39297
Cc: linux-arm-kernel@lists.infradead.org; shawn.guo@linaro.org
Subject: Re: [PATCH] ARM : mx35: 3ds-board: add framebuffer device

On Thu, Nov 03, 2011 at 01:56:37PM +0800, wu guoxing wrote:
> This patch adds framebuffer support for freescale mx35 3ds board
> 
> Signed-off-by: Wu Guoxing <b39297@freescale.com>
> ---
>  arch/arm/mach-imx/mach-mx35_3ds.c |   99 +++++++++++++++++++++++++++++++++++++
>  1 files changed, 99 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/mach-mx35_3ds.c 
> b/arch/arm/mach-imx/mach-mx35_3ds.c
> index 5a5eb3e..e7889ca 100644
> --- a/arch/arm/mach-imx/mach-mx35_3ds.c
> +++ b/arch/arm/mach-imx/mach-mx35_3ds.c
> @@ -40,9 +40,74 @@
>  #include <mach/iomux-mx35.h>
>  #include <mach/irqs.h>
>  #include <mach/3ds_debugboard.h>
> +#include <video/platform_lcd.h>
>  
>  #include "devices-imx35.h"
>  
> +static const struct fb_videomode fb_modedb[] = {
> +	{
> +	 /* 800x480 @ 55 Hz */
> +	 .name = "Ceramate-CLAA070VC01",
> +	 .refresh = 55,
> +	 .xres = 800,
> +	 .yres = 480,
> +	 .pixclock = 40000,
> +	 .left_margin = 40,
> +	 .right_margin = 40,
> +	 .upper_margin = 5,
> +	 .lower_margin = 5,
> +	 .hsync_len = 20,
> +	 .vsync_len = 10,
> +	 .sync = FB_SYNC_OE_ACT_HIGH,
> +	 .vmode = FB_VMODE_NONINTERLACED,
> +	 .flag = 0,
> +	 },
> +};
> +
> +static const struct ipu_platform_data mx3_ipu_data __initconst = {
> +	.irq_base = MXC_IPU_IRQ_START,
> +};
> +
> +static struct mx3fb_platform_data mx3fb_pdata __initdata = {
> +	.name = "Ceramate-CLAA070VC01",
> +	.mode = fb_modedb,
> +	.num_modes = ARRAY_SIZE(fb_modedb),
> +};
> +
> +static struct i2c_board_info __initdata mc9s08dz60_i2c_device = {
> +	I2C_BOARD_INFO("mc9s08dz60", 0x69),
> +};
> +
> +static struct i2c_client *mc9s08dz60_client;
> +
> +static void mx35_3ds_lcd_set_power(struct plat_lcd_data *pd, unsigned 
> +int power) {
> +	u8 temp;
> +
> +	if (!mc9s08dz60_client) {
> +		mc9s08dz60_client =
> +		    i2c_new_device(i2c_get_adapter(0), &mc9s08dz60_i2c_device);
> +	}
> +	if (mc9s08dz60_client) {
> +		temp = (u8) i2c_smbus_read_byte_data(mc9s08dz60_client, 0x20);
> +		if (power)
> +			temp |= (1 << 6);
> +		else
> +			temp &= ~(1 << 6);
> +
> +		i2c_smbus_write_byte_data(mc9s08dz60_client, 0x20, temp);
> +	}
> +}

The mc9s08dz60 is a RTC/Touchscreen/GPIO chip. You should write a driver for it instead of adding a quick hack in the board code.

>  
>  static void __init mx35pdk_timer_init(void) @@ -225,3 +323,4 @@ 
> MACHINE_START(MX35_3DS, "Freescale MX35PDK")
>  	.timer = &mx35pdk_timer,
>  	.init_machine = mx35_3ds_init,
>  MACHINE_END
> +

Please don't add blank lines to files.

Sascha
wu guoxing - Nov. 3, 2011, 8:02 a.m.
Hi Sascha:
  The mc9s08dz60 is a MCU, and its function depend on the code flashed in it. so, it is not a common chip.
it is only for mx35 3ds board, a driver for it will be useless for others, that's why I didn't write a common driver for it, as it will never be used in any other freescale board. But, if you insist, I will write a driver for it.
  For the Blank line, I will remove it.

Best Regards
Wu Guoxing

-----Original Message-----
From: Sascha Hauer [mailto:s.hauer@pengutronix.de] 
Sent: Thursday, November 03, 2011 3:18 PM
To: Wu Guoxing-B39297
Cc: linux-arm-kernel@lists.infradead.org; shawn.guo@linaro.org
Subject: Re: [PATCH] ARM : mx35: 3ds-board: add framebuffer device

On Thu, Nov 03, 2011 at 01:56:37PM +0800, wu guoxing wrote:
> This patch adds framebuffer support for freescale mx35 3ds board
> 
> Signed-off-by: Wu Guoxing <b39297@freescale.com>
> ---
>  arch/arm/mach-imx/mach-mx35_3ds.c |   99 +++++++++++++++++++++++++++++++++++++
>  1 files changed, 99 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/mach-mx35_3ds.c 
> b/arch/arm/mach-imx/mach-mx35_3ds.c
> index 5a5eb3e..e7889ca 100644
> --- a/arch/arm/mach-imx/mach-mx35_3ds.c
> +++ b/arch/arm/mach-imx/mach-mx35_3ds.c
> @@ -40,9 +40,74 @@
>  #include <mach/iomux-mx35.h>
>  #include <mach/irqs.h>
>  #include <mach/3ds_debugboard.h>
> +#include <video/platform_lcd.h>
>  
>  #include "devices-imx35.h"
>  
> +static const struct fb_videomode fb_modedb[] = {
> +	{
> +	 /* 800x480 @ 55 Hz */
> +	 .name = "Ceramate-CLAA070VC01",
> +	 .refresh = 55,
> +	 .xres = 800,
> +	 .yres = 480,
> +	 .pixclock = 40000,
> +	 .left_margin = 40,
> +	 .right_margin = 40,
> +	 .upper_margin = 5,
> +	 .lower_margin = 5,
> +	 .hsync_len = 20,
> +	 .vsync_len = 10,
> +	 .sync = FB_SYNC_OE_ACT_HIGH,
> +	 .vmode = FB_VMODE_NONINTERLACED,
> +	 .flag = 0,
> +	 },
> +};
> +
> +static const struct ipu_platform_data mx3_ipu_data __initconst = {
> +	.irq_base = MXC_IPU_IRQ_START,
> +};
> +
> +static struct mx3fb_platform_data mx3fb_pdata __initdata = {
> +	.name = "Ceramate-CLAA070VC01",
> +	.mode = fb_modedb,
> +	.num_modes = ARRAY_SIZE(fb_modedb),
> +};
> +
> +static struct i2c_board_info __initdata mc9s08dz60_i2c_device = {
> +	I2C_BOARD_INFO("mc9s08dz60", 0x69),
> +};
> +
> +static struct i2c_client *mc9s08dz60_client;
> +
> +static void mx35_3ds_lcd_set_power(struct plat_lcd_data *pd, unsigned 
> +int power) {
> +	u8 temp;
> +
> +	if (!mc9s08dz60_client) {
> +		mc9s08dz60_client =
> +		    i2c_new_device(i2c_get_adapter(0), &mc9s08dz60_i2c_device);
> +	}
> +	if (mc9s08dz60_client) {
> +		temp = (u8) i2c_smbus_read_byte_data(mc9s08dz60_client, 0x20);
> +		if (power)
> +			temp |= (1 << 6);
> +		else
> +			temp &= ~(1 << 6);
> +
> +		i2c_smbus_write_byte_data(mc9s08dz60_client, 0x20, temp);
> +	}
> +}

The mc9s08dz60 is a RTC/Touchscreen/GPIO chip. You should write a driver for it instead of adding a quick hack in the board code.

>  
>  static void __init mx35pdk_timer_init(void) @@ -225,3 +323,4 @@ 
> MACHINE_START(MX35_3DS, "Freescale MX35PDK")
>  	.timer = &mx35pdk_timer,
>  	.init_machine = mx35_3ds_init,
>  MACHINE_END
> +

Please don't add blank lines to files.

Sascha
Sascha Hauer - Nov. 3, 2011, 11:30 a.m.
On Thu, Nov 03, 2011 at 08:02:11AM +0000, Wu Guoxing-B39297 wrote:
> Hi Sascha:
>   The mc9s08dz60 is a MCU, and its function depend on the code flashed
>   in it. so, it is not a common chip.  it is only for mx35 3ds board,
>   a driver for it will be useless for others, that's why I didn't
>   write a common driver for it, as it will never be used in any other
>   freescale board. But, if you insist, I will write a driver for it.

Yes, please write a driver for it. You don't have to write a full
featured driver, gpio access is enough. Normally you should write a mfd
driver, but I think for now you can just put the i2c glue into
drivers/gpio/mc9s08dz60.c

Sascha

Patch

diff --git a/arch/arm/mach-imx/mach-mx35_3ds.c b/arch/arm/mach-imx/mach-mx35_3ds.c
index 5a5eb3e..e7889ca 100644
--- a/arch/arm/mach-imx/mach-mx35_3ds.c
+++ b/arch/arm/mach-imx/mach-mx35_3ds.c
@@ -40,9 +40,74 @@ 
 #include <mach/iomux-mx35.h>
 #include <mach/irqs.h>
 #include <mach/3ds_debugboard.h>
+#include <video/platform_lcd.h>
 
 #include "devices-imx35.h"
 
+static const struct fb_videomode fb_modedb[] = {
+	{
+	 /* 800x480 @ 55 Hz */
+	 .name = "Ceramate-CLAA070VC01",
+	 .refresh = 55,
+	 .xres = 800,
+	 .yres = 480,
+	 .pixclock = 40000,
+	 .left_margin = 40,
+	 .right_margin = 40,
+	 .upper_margin = 5,
+	 .lower_margin = 5,
+	 .hsync_len = 20,
+	 .vsync_len = 10,
+	 .sync = FB_SYNC_OE_ACT_HIGH,
+	 .vmode = FB_VMODE_NONINTERLACED,
+	 .flag = 0,
+	 },
+};
+
+static const struct ipu_platform_data mx3_ipu_data __initconst = {
+	.irq_base = MXC_IPU_IRQ_START,
+};
+
+static struct mx3fb_platform_data mx3fb_pdata __initdata = {
+	.name = "Ceramate-CLAA070VC01",
+	.mode = fb_modedb,
+	.num_modes = ARRAY_SIZE(fb_modedb),
+};
+
+static struct i2c_board_info __initdata mc9s08dz60_i2c_device = {
+	I2C_BOARD_INFO("mc9s08dz60", 0x69),
+};
+
+static struct i2c_client *mc9s08dz60_client;
+
+static void mx35_3ds_lcd_set_power(struct plat_lcd_data *pd, unsigned int power)
+{
+	u8 temp;
+
+	if (!mc9s08dz60_client) {
+		mc9s08dz60_client =
+		    i2c_new_device(i2c_get_adapter(0), &mc9s08dz60_i2c_device);
+	}
+	if (mc9s08dz60_client) {
+		temp = (u8) i2c_smbus_read_byte_data(mc9s08dz60_client, 0x20);
+		if (power)
+			temp |= (1 << 6);
+		else
+			temp &= ~(1 << 6);
+
+		i2c_smbus_write_byte_data(mc9s08dz60_client, 0x20, temp);
+	}
+}
+
+static struct plat_lcd_data mx35_3ds_lcd_data = {
+	.set_power = mx35_3ds_lcd_set_power,
+};
+
+static struct platform_device mx35_3ds_lcd = {
+	.name = "platform-lcd",
+	.dev.platform_data = &mx35_3ds_lcd_data,
+};
+
 #define EXPIO_PARENT_INT	gpio_to_irq(IMX_GPIO_NR(1, 1))
 
 static const struct imxuart_platform_data uart_pdata __initconst = {
@@ -120,6 +185,32 @@  static iomux_v3_cfg_t mx35pdk_pads[] = {
 	/* I2C1 */
 	MX35_PAD_I2C1_CLK__I2C1_SCL,
 	MX35_PAD_I2C1_DAT__I2C1_SDA,
+	/* Display */
+	MX35_PAD_LD0__IPU_DISPB_DAT_0,
+	MX35_PAD_LD1__IPU_DISPB_DAT_1,
+	MX35_PAD_LD2__IPU_DISPB_DAT_2,
+	MX35_PAD_LD3__IPU_DISPB_DAT_3,
+	MX35_PAD_LD4__IPU_DISPB_DAT_4,
+	MX35_PAD_LD5__IPU_DISPB_DAT_5,
+	MX35_PAD_LD6__IPU_DISPB_DAT_6,
+	MX35_PAD_LD7__IPU_DISPB_DAT_7,
+	MX35_PAD_LD8__IPU_DISPB_DAT_8,
+	MX35_PAD_LD9__IPU_DISPB_DAT_9,
+	MX35_PAD_LD10__IPU_DISPB_DAT_10,
+	MX35_PAD_LD11__IPU_DISPB_DAT_11,
+	MX35_PAD_LD12__IPU_DISPB_DAT_12,
+	MX35_PAD_LD13__IPU_DISPB_DAT_13,
+	MX35_PAD_LD14__IPU_DISPB_DAT_14,
+	MX35_PAD_LD15__IPU_DISPB_DAT_15,
+	MX35_PAD_LD16__IPU_DISPB_DAT_16,
+	MX35_PAD_LD17__IPU_DISPB_DAT_17,
+	MX35_PAD_D3_HSYNC__IPU_DISPB_D3_HSYNC,
+	MX35_PAD_D3_FPSHIFT__IPU_DISPB_D3_CLK,
+	MX35_PAD_D3_DRDY__IPU_DISPB_D3_DRDY,
+	MX35_PAD_CONTRAST__IPU_DISPB_CONTR,
+	MX35_PAD_D3_VSYNC__IPU_DISPB_D3_VSYNC,
+	MX35_PAD_D3_REV__IPU_DISPB_D3_REV,
+	MX35_PAD_D3_CLS__IPU_DISPB_D3_CLS,
 };
 
 static int mx35_3ds_otg_init(struct platform_device *pdev)
@@ -179,6 +270,8 @@  static const struct imxi2c_platform_data mx35_3ds_i2c0_data __initconst = {
  */
 static void __init mx35_3ds_init(void)
 {
+	struct platform_device *imx35_fb_pdev;
+
 	imx35_soc_init();
 
 	mxc_iomux_v3_setup_multiple_pads(mx35pdk_pads, ARRAY_SIZE(mx35pdk_pads));
@@ -204,6 +297,11 @@  static void __init mx35_3ds_init(void)
 		pr_warn("Init of the debugboard failed, all "
 				"devices on the debugboard are unusable.\n");
 	imx35_add_imx_i2c0(&mx35_3ds_i2c0_data);
+
+	imx35_add_ipu_core(&mx3_ipu_data);
+	imx35_fb_pdev = imx35_add_mx3_sdc_fb(&mx3fb_pdata);
+	mx35_3ds_lcd.dev.parent = &imx35_fb_pdev->dev;
+	platform_device_register(&mx35_3ds_lcd);
 }
 
 static void __init mx35pdk_timer_init(void)
@@ -225,3 +323,4 @@  MACHINE_START(MX35_3DS, "Freescale MX35PDK")
 	.timer = &mx35pdk_timer,
 	.init_machine = mx35_3ds_init,
 MACHINE_END
+