Patchwork [net,02/10] e100: make sure vlan support isn't advertised on old adapters

mail settings
Submitter Jeff Kirsher
Date Nov. 3, 2011, 12:19 a.m.
Message ID <>
Download mbox | patch
Permalink /patch/123376/
State Accepted
Delegated to: David Miller
Headers show


Jeff Kirsher - Nov. 3, 2011, 12:19 a.m.
From: Jesse Brandeburg <>

e100 parts don't support vlan offload but they generally do
allow use of vlans in higher software layers via the 8021q module.
That said, there are a couple of really old revisions of e100
hardware that don't even allow the longer frame sizes
required for vlan use with standard MTU.

Use the VLAN_CHALLENGED flag to prevent vlan binding to these

Reported-by: Michael Tokarev <>
Signed-off-by: Jesse Brandeburg <>
CC: Michael Tokarev <>
CC: David Lamparter <>
Tested-by: Aaron Brown <>
Signed-off-by: Jeff Kirsher <>
 drivers/net/ethernet/intel/e100.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)


diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c
index ae17cd1..5a2fdf7 100644
--- a/drivers/net/ethernet/intel/e100.c
+++ b/drivers/net/ethernet/intel/e100.c
@@ -2810,6 +2810,10 @@  static int __devinit e100_probe(struct pci_dev *pdev,
+	/* D100 MAC doesn't allow rx of vlan packets with normal MTU */
+	if (nic->mac < mac_82558_D101_A4)
+		netdev->features |= NETIF_F_VLAN_CHALLENGED;
 	/* locks must be initialized before calling hw_reset */