| Message ID | 20200205005054.k72fuikf6rwrgfe4@google.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | powerpc/vdso32: mark __kernel_datapage_offset as STV_PROTECTED | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (530a1cfd52af0aba1af4b1c9a7bc66a202a459b1) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | warning | total: 0 errors, 1 warnings, 0 checks, 9 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
Le 05/02/2020 à 01:50, Fangrui Song a écrit : > A PC-relative relocation (R_PPC_REL16_LO in this case) referencing a > preemptible symbol in a -shared link is not allowed. GNU ld's powerpc > port is permissive and allows it [1], but lld will report an error after > https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id=ec0895f08f99515194e9fcfe1338becf6f759d38 Note that there is a series whose first two patches aim at dropping __kernel_datapage_offset . See https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=156045 and especially patches https://patchwork.ozlabs.org/patch/1231467/ and https://patchwork.ozlabs.org/patch/1231461/ Those patches can be applied independentely of the rest. Christophe > > Make the symbol protected so that it is non-preemptible but still > exported. > > [1]: https://sourceware.org/bugzilla/show_bug.cgi?id=25500 > > Link: https://github.com/ClangBuiltLinux/linux/issues/851 > Signed-off-by: Fangrui Song <maskray@google.com> > --- > arch/powerpc/kernel/vdso32/datapage.S | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/kernel/vdso32/datapage.S b/arch/powerpc/kernel/vdso32/datapage.S > index 217bb630f8f9..2831a8676365 100644 > --- a/arch/powerpc/kernel/vdso32/datapage.S > +++ b/arch/powerpc/kernel/vdso32/datapage.S > @@ -13,7 +13,8 @@ > #include <asm/vdso_datapage.h> > > .text > - .global __kernel_datapage_offset; > + .global __kernel_datapage_offset > + .protected __kernel_datapage_offset > __kernel_datapage_offset: > .long 0 > >
On Wed, Feb 05, 2020 at 07:25:59AM +0100, Christophe Leroy wrote: > > > Le 05/02/2020 à 01:50, Fangrui Song a écrit : > > A PC-relative relocation (R_PPC_REL16_LO in this case) referencing a > > preemptible symbol in a -shared link is not allowed. GNU ld's powerpc > > port is permissive and allows it [1], but lld will report an error after > > https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id=ec0895f08f99515194e9fcfe1338becf6f759d38 > > Note that there is a series whose first two patches aim at dropping > __kernel_datapage_offset . See > https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=156045 and > especially patches https://patchwork.ozlabs.org/patch/1231467/ and > https://patchwork.ozlabs.org/patch/1231461/ > > Those patches can be applied independentely of the rest. > > Christophe If that is the case, it would be nice if those could be fast tracked to 5.6 because as it stands now, all PowerPC builds that were working with ld.lld are now broken. Either that or take this patch and rebase that series on this one. Cheers, Nathan
Fangrui Song <maskray@google.com> writes: > A PC-relative relocation (R_PPC_REL16_LO in this case) referencing a > preemptible symbol in a -shared link is not allowed. GNU ld's powerpc > port is permissive and allows it [1], but lld will report an error after > https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id=ec0895f08f99515194e9fcfe1338becf6f759d38 > > Make the symbol protected so that it is non-preemptible but still > exported. "preemptible" means something different to me, and I assume we're not using it to mean the same thing. Can you explain it using small words that a kernel developer can understand? :) cheers > [1]: https://sourceware.org/bugzilla/show_bug.cgi?id=25500 > > Link: https://github.com/ClangBuiltLinux/linux/issues/851 > Signed-off-by: Fangrui Song <maskray@google.com> > --- > arch/powerpc/kernel/vdso32/datapage.S | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/kernel/vdso32/datapage.S b/arch/powerpc/kernel/vdso32/datapage.S > index 217bb630f8f9..2831a8676365 100644 > --- a/arch/powerpc/kernel/vdso32/datapage.S > +++ b/arch/powerpc/kernel/vdso32/datapage.S > @@ -13,7 +13,8 @@ > #include <asm/vdso_datapage.h> > > .text > - .global __kernel_datapage_offset; > + .global __kernel_datapage_offset > + .protected __kernel_datapage_offset > __kernel_datapage_offset: > .long 0 > > -- > 2.25.0.341.g760bfbb309-goog
On Mon, Feb 10, 2020 at 3:01 AM Michael Ellerman <mpe@ellerman.id.au> wrote: > > Fangrui Song <maskray@google.com> writes: > > A PC-relative relocation (R_PPC_REL16_LO in this case) referencing a > > preemptible symbol in a -shared link is not allowed. GNU ld's powerpc > > port is permissive and allows it [1], but lld will report an error after > > https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id=ec0895f08f99515194e9fcfe1338becf6f759d38 > > > > Make the symbol protected so that it is non-preemptible but still > > exported. > > "preemptible" means something different to me, and I assume we're not > using it to mean the same thing. > > Can you explain it using small words that a kernel developer can > understand? :) > > cheers The term used in the ELF specification is "preemptable". I heard from Roland McGrathr that "preemptable" was a typo. The correct term is "preemptible". On a random article I found, it mentions that "preemptible" is used more than "preemptable". So now I stick with "preemptible". The word is overloaded and has a different meaning in the kernel, but here we refer to within the ELF binary format context. From http://www.sco.com/developers/gabi/latest/ch4.symtab.html "The visibility of symbols with the STV_DEFAULT attribute is as specified by the symbol's binding type. That is, global and weak symbols are visible outside of their defining component (executable file or shared object). Local symbols are hidden, as described below. Global and weak symbols are also preemptable, that is, they may by preempted by definitions of the same name in another component." __kernel_datapage_offset is a STB_GLOBAL STV_DEFAULT symbol. In a -shared link, it is considered preemptible. There are some methods that make such symbols non-preemptible but none is used in this context. * -Bsymbolic * -Bsymbolic-functions if STT_FUNC * --dynamic-list is specified but the dynamic list does not name this symbol * A --version-script makes the symbol local __kernel_datapage_offset is accessed via some mechanism similar to dlsym, so it has to be exported. Given all the above, I chose STV_PROTECTED, which is the simplest and least intrusive approach. > > [1]: https://sourceware.org/bugzilla/show_bug.cgi?id=25500 > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/851 > > Signed-off-by: Fangrui Song <maskray@google.com> > > > --- > > arch/powerpc/kernel/vdso32/datapage.S | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/powerpc/kernel/vdso32/datapage.S b/arch/powerpc/kernel/vdso32/datapage.S > > index 217bb630f8f9..2831a8676365 100644 > > --- a/arch/powerpc/kernel/vdso32/datapage.S > > +++ b/arch/powerpc/kernel/vdso32/datapage.S > > @@ -13,7 +13,8 @@ > > #include <asm/vdso_datapage.h> > > > > .text > > - .global __kernel_datapage_offset; > > + .global __kernel_datapage_offset > > + .protected __kernel_datapage_offset > > __kernel_datapage_offset: > > .long 0 > > > > -- > > 2.25.0.341.g760bfbb309-goog
On Thu, Feb 6, 2020 at 10:42 PM Nathan Chancellor <natechancellor@gmail.com> wrote: > > On Wed, Feb 05, 2020 at 07:25:59AM +0100, Christophe Leroy wrote: > > > > > > Le 05/02/2020 à 01:50, Fangrui Song a écrit : > > > A PC-relative relocation (R_PPC_REL16_LO in this case) referencing a > > > preemptible symbol in a -shared link is not allowed. GNU ld's powerpc > > > port is permissive and allows it [1], but lld will report an error after > > > https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id=ec0895f08f99515194e9fcfe1338becf6f759d38 > > > > Note that there is a series whose first two patches aim at dropping > > __kernel_datapage_offset . See > > https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=156045 and > > especially patches https://patchwork.ozlabs.org/patch/1231467/ and > > https://patchwork.ozlabs.org/patch/1231461/ > > > > Those patches can be applied independentely of the rest. > > > > Christophe > > If that is the case, it would be nice if those could be fast tracked to > 5.6 because as it stands now, all PowerPC builds that were working with > ld.lld are now broken. Either that or take this patch and rebase that > series on this one. So do we still need Fangrui's patch or is it moot? I'm doing a scrub of our bug tracker and this issue is still open: https://github.com/ClangBuiltLinux/linux/issues/851 but it looks like all of our ppc LE targets are linking with LLD just fine https://travis-ci.com/github/ClangBuiltLinux/continuous-integration/builds/169379039 though it sounds like https://github.com/ClangBuiltLinux/linux/issues/774 may be a blocker? Though I don't see Cristophe's https://patchwork.ozlabs.org/project/linuxppc-dev/patch/5f97f7c921ffc2113ada0f32924e409bccc8277a.1580399657.git.christophe.leroy@c-s.fr/ in mainline or -next. Was the series not accepted? > > Cheers, > Nathan > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20200207064210.GA13125%40ubuntu-x2-xlarge-x86. -- Thanks, ~Nick Desaulniers
diff --git a/arch/powerpc/kernel/vdso32/datapage.S b/arch/powerpc/kernel/vdso32/datapage.S index 217bb630f8f9..2831a8676365 100644 --- a/arch/powerpc/kernel/vdso32/datapage.S +++ b/arch/powerpc/kernel/vdso32/datapage.S @@ -13,7 +13,8 @@ #include <asm/vdso_datapage.h> .text - .global __kernel_datapage_offset; + .global __kernel_datapage_offset + .protected __kernel_datapage_offset __kernel_datapage_offset: .long 0
A PC-relative relocation (R_PPC_REL16_LO in this case) referencing a preemptible symbol in a -shared link is not allowed. GNU ld's powerpc port is permissive and allows it [1], but lld will report an error after https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id=ec0895f08f99515194e9fcfe1338becf6f759d38 Make the symbol protected so that it is non-preemptible but still exported. [1]: https://sourceware.org/bugzilla/show_bug.cgi?id=25500 Link: https://github.com/ClangBuiltLinux/linux/issues/851 Signed-off-by: Fangrui Song <maskray@google.com> --- arch/powerpc/kernel/vdso32/datapage.S | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)