[OpenWrt-Devel] ath79: WNDR3700 v1/v2: make u-boot env partition writable
diff mbox series

Message ID 20200203195431.33881551@kosmio.komorska
State Accepted
Headers show
Series
  • [OpenWrt-Devel] ath79: WNDR3700 v1/v2: make u-boot env partition writable
Related show

Commit Message

Michal Cieslakiewicz Feb. 3, 2020, 6:54 p.m. UTC
Remove read-only flag from U-boot environment partition for Netgear
WNDR3700 v1 and v2 so u-boot-envtools can modify data there.

Signed-off-by: Michal Cieslakiewicz <michal.cieslakiewicz@wp.pl>
---
 target/linux/ath79/dts/ar7161_netgear_wndr3700-v2.dts | 1 -
 target/linux/ath79/dts/ar7161_netgear_wndr3700.dts    | 1 -
 2 files changed, 2 deletions(-)

Comments

Hannu Nyman Feb. 3, 2020, 7:59 p.m. UTC | #1
Michal Cieslakiewicz kirjoitti 3.2.2020 klo 20.54:
> Remove read-only flag from U-boot environment partition for Netgear
> WNDR3700 v1 and v2 so u-boot-envtools can modify data there.
>

Any reason, why you have left out the third router in the series, WNDR3800? 
It is identical to WNDR3700v2 except the RAM amount. If the u-boot-env 
read-only attribute is modified for v1 and v2, also 3800 would be logical to 
fix at the same time.


Btw, what is the practical need for this change?  During the last 10 years 
with OpenWrt with this router I have not seen any need for modifying the 
u-boot-env.
Etienne Champetier Feb. 3, 2020, 8:29 p.m. UTC | #2
Hello Hannu,

Le lun. 3 févr. 2020 à 14:59, Hannu Nyman <hannu.nyman@iki.fi> a écrit :
>
> Michal Cieslakiewicz kirjoitti 3.2.2020 klo 20.54:
> > Remove read-only flag from U-boot environment partition for Netgear
> > WNDR3700 v1 and v2 so u-boot-envtools can modify data there.
> >
>
> Any reason, why you have left out the third router in the series, WNDR3800?
> It is identical to WNDR3700v2 except the RAM amount. If the u-boot-env
> read-only attribute is modified for v1 and v2, also 3800 would be logical to
> fix at the same time.

I see 1 use case that is not really common, it's the ability to
enable/disable failsafe

>
> Btw, what is the practical need for this change?  During the last 10 years
> with OpenWrt with this router I have not seen any need for modifying the
> u-boot-env.
>

Patch
diff mbox series

diff --git a/target/linux/ath79/dts/ar7161_netgear_wndr3700-v2.dts b/target/linux/ath79/dts/ar7161_netgear_wndr3700-v2.dts
index f3d27f2bdf..96573bdf14 100644
--- a/target/linux/ath79/dts/ar7161_netgear_wndr3700-v2.dts
+++ b/target/linux/ath79/dts/ar7161_netgear_wndr3700-v2.dts
@@ -18,7 +18,6 @@ 
 	partition@50000 {
 		label = "u-boot-env";
 		reg = <0x050000 0x020000>;
-		read-only;
 	};
 
 	partition@70000 {
diff --git a/target/linux/ath79/dts/ar7161_netgear_wndr3700.dts b/target/linux/ath79/dts/ar7161_netgear_wndr3700.dts
index ac6f2362ec..75c68d83c7 100644
--- a/target/linux/ath79/dts/ar7161_netgear_wndr3700.dts
+++ b/target/linux/ath79/dts/ar7161_netgear_wndr3700.dts
@@ -18,7 +18,6 @@ 
 	partition@50000 {
 		label = "u-boot-env";
 		reg = <0x050000 0x020000>;
-		read-only;
 	};
 
 	partition@70000 {