diff mbox series

[1/2] mx6ul_evk: Move CONFIG_FEC_MXC to defconfig

Message ID 20200203160923.23548-1-festevam@gmail.com
State Accepted
Commit ba83ed5922d15a3b81b2d2cd8c851e1b3eafab84
Delegated to: Stefano Babic
Headers show
Series [1/2] mx6ul_evk: Move CONFIG_FEC_MXC to defconfig | expand

Commit Message

Fabio Estevam Feb. 3, 2020, 4:09 p.m. UTC
CONFIG_FEC_MXC is supported in Kconfig, so it is preferred to
move it to defconfig file.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 configs/mx6ul_14x14_evk_defconfig | 1 +
 include/configs/mx6ul_14x14_evk.h | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

Comments

Peng Fan Feb. 5, 2020, 7:21 a.m. UTC | #1
> Subject: [PATCH 1/2] mx6ul_evk: Move CONFIG_FEC_MXC to defconfig
> 
> CONFIG_FEC_MXC is supported in Kconfig, so it is preferred to move it to
> defconfig file.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
>  configs/mx6ul_14x14_evk_defconfig | 1 +
> include/configs/mx6ul_14x14_evk.h | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configs/mx6ul_14x14_evk_defconfig
> b/configs/mx6ul_14x14_evk_defconfig
> index 4fd311d2fb..f72f050561 100644
> --- a/configs/mx6ul_14x14_evk_defconfig
> +++ b/configs/mx6ul_14x14_evk_defconfig
> @@ -55,6 +55,7 @@ CONFIG_SPI_FLASH_STMICRO=y  CONFIG_PHYLIB=y
> CONFIG_PHY_MICREL=y  CONFIG_PHY_MICREL_KSZ8XXX=y
> +CONFIG_FEC_MXC=y
>  CONFIG_DM_ETH=y
>  CONFIG_MII=y
>  CONFIG_PINCTRL=y
> diff --git a/include/configs/mx6ul_14x14_evk.h
> b/include/configs/mx6ul_14x14_evk.h
> index 5cc15b6d2f..a35077ddb8 100644
> --- a/include/configs/mx6ul_14x14_evk.h
> +++ b/include/configs/mx6ul_14x14_evk.h
> @@ -177,7 +177,6 @@
>  #endif
> 
>  #ifdef CONFIG_CMD_NET
> -#define CONFIG_FEC_MXC
>  #define CONFIG_FEC_ENET_DEV		1
> 
>  #if (CONFIG_FEC_ENET_DEV == 0)
> --
> 2.17.1
Stefano Babic April 18, 2020, 10:51 a.m. UTC | #2
> CONFIG_FEC_MXC is supported in Kconfig, so it is preferred to
> move it to defconfig file.
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/configs/mx6ul_14x14_evk_defconfig b/configs/mx6ul_14x14_evk_defconfig
index 4fd311d2fb..f72f050561 100644
--- a/configs/mx6ul_14x14_evk_defconfig
+++ b/configs/mx6ul_14x14_evk_defconfig
@@ -55,6 +55,7 @@  CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_PHYLIB=y
 CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ8XXX=y
+CONFIG_FEC_MXC=y
 CONFIG_DM_ETH=y
 CONFIG_MII=y
 CONFIG_PINCTRL=y
diff --git a/include/configs/mx6ul_14x14_evk.h b/include/configs/mx6ul_14x14_evk.h
index 5cc15b6d2f..a35077ddb8 100644
--- a/include/configs/mx6ul_14x14_evk.h
+++ b/include/configs/mx6ul_14x14_evk.h
@@ -177,7 +177,6 @@ 
 #endif
 
 #ifdef CONFIG_CMD_NET
-#define CONFIG_FEC_MXC
 #define CONFIG_FEC_ENET_DEV		1
 
 #if (CONFIG_FEC_ENET_DEV == 0)