| Submitter | Aneesh Kumar K.V |
|---|---|
| Date | Nov. 2, 2011, 10:22 a.m. |
| Message ID | <87aa8ehlih.fsf@linux.vnet.ibm.com> |
| Download | mbox |
| Permalink | /patch/123248/ |
| State | New |
| Headers | show |
Pull-request
git://repo.or.cz/qemu/v9fs.git for-upstream-8Comments
On 11/02/2011 05:22 AM, Aneesh Kumar K.V wrote: > > The following changes since commit e072ea2fd8fdceef64159b9596d3c15ce01bea91: > > Bump version to 1.0-rc0 (2011-11-01 19:37:01 -0500) > > are available in the git repository at: > git://repo.or.cz/qemu/v9fs.git for-upstream-8 > > Aneesh Kumar K.V (1): > hw/9pfs: Move opt validation to FsDriver callback > > Stefan Hajnoczi (1): > hw/9pfs: use g_vasprintf() instead of rolling our own Neither of these look like bug fixes to me. Regards, Anthony Liguori > > fsdev/file-op-9p.h | 15 ++++++- > fsdev/qemu-fsdev.c | 44 +++---------------- > fsdev/qemu-fsdev.h | 10 ---- > hw/9pfs/virtio-9p-device.c | 13 +++-- > hw/9pfs/virtio-9p-handle.c | 20 +++++++++ > hw/9pfs/virtio-9p-local.c | 34 ++++++++++++++ > hw/9pfs/virtio-9p.c | 103 ++------------------------------------------ > vl.c | 8 +--- > 8 files changed, 87 insertions(+), 160 deletions(-)
Anthony Liguori <aliguori@us.ibm.com> writes: > On 11/02/2011 05:22 AM, Aneesh Kumar K.V wrote: >> >> The following changes since commit e072ea2fd8fdceef64159b9596d3c15ce01bea91: >> >> Bump version to 1.0-rc0 (2011-11-01 19:37:01 -0500) >> >> are available in the git repository at: >> git://repo.or.cz/qemu/v9fs.git for-upstream-8 >> >> Aneesh Kumar K.V (1): >> hw/9pfs: Move opt validation to FsDriver callback >> >> Stefan Hajnoczi (1): >> hw/9pfs: use g_vasprintf() instead of rolling our own > > Neither of these look like bug fixes to me. The second one is actually a minor portability fix: one of the replaced functions uses va_copy() without a matching va_end(). I posted the obvious fix "Subject: [PATCH 2/2] hw/9pfs: Supply missing va_end()", but Stefan's fix is better.
The following changes since commit e072ea2fd8fdceef64159b9596d3c15ce01bea91: Bump version to 1.0-rc0 (2011-11-01 19:37:01 -0500) are available in the git repository at: git://repo.or.cz/qemu/v9fs.git for-upstream-8 Aneesh Kumar K.V (1): hw/9pfs: Move opt validation to FsDriver callback Stefan Hajnoczi (1): hw/9pfs: use g_vasprintf() instead of rolling our own fsdev/file-op-9p.h | 15 ++++++- fsdev/qemu-fsdev.c | 44 +++---------------- fsdev/qemu-fsdev.h | 10 ---- hw/9pfs/virtio-9p-device.c | 13 +++-- hw/9pfs/virtio-9p-handle.c | 20 +++++++++ hw/9pfs/virtio-9p-local.c | 34 ++++++++++++++ hw/9pfs/virtio-9p.c | 103 ++------------------------------------------ vl.c | 8 +--- 8 files changed, 87 insertions(+), 160 deletions(-)