ARM: imx: limit errata selection to Cortex-A9 based designs
diff mbox series

Message ID 20200202193014.107003-1-stefan@agner.ch
State New
Headers show
Series
  • ARM: imx: limit errata selection to Cortex-A9 based designs
Related show

Commit Message

Stefan Agner Feb. 2, 2020, 7:30 p.m. UTC
From: Stefan Agner <stefan.agner@toradex.com>

The two erratas 754322 and 775420 are Cortex-A9 specific. Only
select the erratas for SoC which use a Cortex-A9.

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 arch/arm/mach-imx/Kconfig | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Comments

Oleksandr Suvorov Feb. 3, 2020, 2:11 p.m. UTC | #1
On Sun, Feb 2, 2020 at 9:31 PM Stefan Agner <stefan@agner.ch> wrote:
>
> From: Stefan Agner <stefan.agner@toradex.com>
>
> The two erratas 754322 and 775420 are Cortex-A9 specific. Only
> select the erratas for SoC which use a Cortex-A9.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>

Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>

> ---
>  arch/arm/mach-imx/Kconfig | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index 95584ee02b55..e7d7b90e2cf8 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -471,8 +471,6 @@ config      SOC_IMX53
>  config SOC_IMX6
>         bool
>         select ARM_CPU_SUSPEND if (PM || CPU_IDLE)
> -       select ARM_ERRATA_754322
> -       select ARM_ERRATA_775420
>         select ARM_GIC
>         select HAVE_IMX_ANATOP
>         select HAVE_IMX_GPC
> @@ -484,6 +482,8 @@ config SOC_IMX6
>  config SOC_IMX6Q
>         bool "i.MX6 Quad/DualLite support"
>         select ARM_ERRATA_764369 if SMP
> +       select ARM_ERRATA_754322
> +       select ARM_ERRATA_775420
>         select HAVE_ARM_SCU if SMP
>         select HAVE_ARM_TWD
>         select PINCTRL_IMX6Q
> @@ -494,6 +494,8 @@ config SOC_IMX6Q
>
>  config SOC_IMX6SL
>         bool "i.MX6 SoloLite support"
> +       select ARM_ERRATA_754322
> +       select ARM_ERRATA_775420
>         select PINCTRL_IMX6SL
>         select SOC_IMX6
>
> @@ -502,6 +504,8 @@ config SOC_IMX6SL
>
>  config SOC_IMX6SLL
>         bool "i.MX6 SoloLiteLite support"
> +       select ARM_ERRATA_754322
> +       select ARM_ERRATA_775420
>         select PINCTRL_IMX6SLL
>         select SOC_IMX6
>
> @@ -510,6 +514,8 @@ config SOC_IMX6SLL
>
>  config SOC_IMX6SX
>         bool "i.MX6 SoloX support"
> +       select ARM_ERRATA_754322
> +       select ARM_ERRATA_775420
>         select PINCTRL_IMX6SX
>         select SOC_IMX6
>
> --
> 2.25.0
>
Fabio Estevam Feb. 3, 2020, 2:22 p.m. UTC | #2
Hi Stefan,

On Sun, Feb 2, 2020 at 4:30 PM Stefan Agner <stefan@agner.ch> wrote:
>
> From: Stefan Agner <stefan.agner@toradex.com>
>
> The two erratas 754322 and 775420 are Cortex-A9 specific. Only
> select the erratas for SoC which use a Cortex-A9.

Change looks good.

It is not clear from the commit log, which SoC selects the errata
incorrectly though.

I would mention that i.MX6UL is based on Cortex-A7 and hence should
not select them.

Otherwise, only by looking at this patch context and commit log, we
cannot notice the problem.

Reviewed-by: Fabio Estevam <festevam@gmail.com>

Patch
diff mbox series

diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index 95584ee02b55..e7d7b90e2cf8 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -471,8 +471,6 @@  config	SOC_IMX53
 config SOC_IMX6
 	bool
 	select ARM_CPU_SUSPEND if (PM || CPU_IDLE)
-	select ARM_ERRATA_754322
-	select ARM_ERRATA_775420
 	select ARM_GIC
 	select HAVE_IMX_ANATOP
 	select HAVE_IMX_GPC
@@ -484,6 +482,8 @@  config SOC_IMX6
 config SOC_IMX6Q
 	bool "i.MX6 Quad/DualLite support"
 	select ARM_ERRATA_764369 if SMP
+	select ARM_ERRATA_754322
+	select ARM_ERRATA_775420
 	select HAVE_ARM_SCU if SMP
 	select HAVE_ARM_TWD
 	select PINCTRL_IMX6Q
@@ -494,6 +494,8 @@  config SOC_IMX6Q
 
 config SOC_IMX6SL
 	bool "i.MX6 SoloLite support"
+	select ARM_ERRATA_754322
+	select ARM_ERRATA_775420
 	select PINCTRL_IMX6SL
 	select SOC_IMX6
 
@@ -502,6 +504,8 @@  config SOC_IMX6SL
 
 config SOC_IMX6SLL
 	bool "i.MX6 SoloLiteLite support"
+	select ARM_ERRATA_754322
+	select ARM_ERRATA_775420
 	select PINCTRL_IMX6SLL
 	select SOC_IMX6
 
@@ -510,6 +514,8 @@  config SOC_IMX6SLL
 
 config SOC_IMX6SX
 	bool "i.MX6 SoloX support"
+	select ARM_ERRATA_754322
+	select ARM_ERRATA_775420
 	select PINCTRL_IMX6SX
 	select SOC_IMX6