[1/2] i2c: designware: Add ACPI HID for Hisilicon Hip08-Lite I2C controller
diff mbox series

Message ID 1580643255-38214-1-git-send-email-guohanjun@huawei.com
State Superseded
Headers show
Series
  • [1/2] i2c: designware: Add ACPI HID for Hisilicon Hip08-Lite I2C controller
Related show

Commit Message

Hanjun Guo Feb. 2, 2020, 11:34 a.m. UTC
Add ACPI HID HISI02A3 for Hisilicon Hip08 Lite, which has different
clock frequency from Hip08 for I2C controller.

Tested-by: Sheng Feng <fengsheng5@huawei.com>
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
 drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Andy Shevchenko Feb. 2, 2020, 7:52 p.m. UTC | #1
On Sun, Feb 02, 2020 at 07:34:14PM +0800, Hanjun Guo wrote:
> Add ACPI HID HISI02A3 for Hisilicon Hip08 Lite, which has different
> clock frequency from Hip08 for I2C controller.

The series is good for me, but I think you should reverse the order of the
patches in it.

> Tested-by: Sheng Feng <fengsheng5@huawei.com>
> Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
> ---
>  drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index 16dd338..3b7d58c 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -130,6 +130,7 @@ static int dw_i2c_acpi_configure(struct platform_device *pdev)
>  	{ "APMC0D0F", 0 },
>  	{ "HISI02A1", 0 },
>  	{ "HISI02A2", 0 },
> +	{ "HISI02A3", 0 },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
> -- 
> 1.7.12.4
>
Hanjun Guo Feb. 3, 2020, 1:28 a.m. UTC | #2
On 2020/2/3 3:52, Andy Shevchenko wrote:
> On Sun, Feb 02, 2020 at 07:34:14PM +0800, Hanjun Guo wrote:
>> Add ACPI HID HISI02A3 for Hisilicon Hip08 Lite, which has different
>> clock frequency from Hip08 for I2C controller.
> 
> The series is good for me, but I think you should reverse the order of the
> patches in it.

I will send a updated version as you suggested.

Thanks
Hanjun

Patch
diff mbox series

diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index 16dd338..3b7d58c 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -130,6 +130,7 @@  static int dw_i2c_acpi_configure(struct platform_device *pdev)
 	{ "APMC0D0F", 0 },
 	{ "HISI02A1", 0 },
 	{ "HISI02A2", 0 },
+	{ "HISI02A3", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);