Patchwork configure: Suppress messages from pkg_config probe for check

login
register
mail settings
Submitter Peter Maydell
Date Nov. 1, 2011, 6:32 p.m.
Message ID <1320172375-28019-1-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/123115/
State New
Headers show

Comments

Peter Maydell - Nov. 1, 2011, 6:32 p.m.
Suppress confusing messages from pkg_config when probing for
'check' by sending them to /dev/null as we do with other
similar probes.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
We didn't notice this before because we only recently
changed the default for whether configure probed for this.
I think that makes this a regression we should fix for 1.0.

 configure |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Anthony Liguori - Nov. 1, 2011, 10:22 p.m.
On 11/01/2011 01:32 PM, Peter Maydell wrote:
> Suppress confusing messages from pkg_config when probing for
> 'check' by sending them to /dev/null as we do with other
> similar probes.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
> We didn't notice this before because we only recently
> changed the default for whether configure probed for this.
> I think that makes this a regression we should fix for 1.0.
>
>   configure |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index 28667fe..9661b0e 100755
> --- a/configure
> +++ b/configure
> @@ -1828,7 +1828,7 @@ if test "$check_utests" != "no" ; then
>   #include<check.h>
>   int main(void) { suite_create("qemu test"); return 0; }
>   EOF
> -  check_libs=`$pkg_config --libs check`
> +  check_libs=`$pkg_config --libs check 2>/dev/null`
>     if compile_prog "" $check_libs ; then
>       check_utests=yes
>       libs_tools="$check_libs $libs_tools"

Patch

diff --git a/configure b/configure
index 28667fe..9661b0e 100755
--- a/configure
+++ b/configure
@@ -1828,7 +1828,7 @@  if test "$check_utests" != "no" ; then
 #include <check.h>
 int main(void) { suite_create("qemu test"); return 0; }
 EOF
-  check_libs=`$pkg_config --libs check`
+  check_libs=`$pkg_config --libs check 2>/dev/null`
   if compile_prog "" $check_libs ; then
     check_utests=yes
     libs_tools="$check_libs $libs_tools"