gpio: bd71828: Remove unneeded defines for GPIO_LINE_DIRECTION_IN/OUT
diff mbox series

Message ID 20200129123021.26200-1-axel.lin@ingics.com
State New
Headers show
Series
  • gpio: bd71828: Remove unneeded defines for GPIO_LINE_DIRECTION_IN/OUT
Related show

Commit Message

Axel Lin Jan. 29, 2020, 12:30 p.m. UTC
They are defined in gpio/driver.h now.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/gpio/gpio-bd71828.c | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Vaittinen, Matti Jan. 29, 2020, 3:06 p.m. UTC | #1
On Wed, 2020-01-29 at 20:30 +0800, Axel Lin wrote:
> They are defined in gpio/driver.h now.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/gpio/gpio-bd71828.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-bd71828.c b/drivers/gpio/gpio-
> bd71828.c
> index 04aade9e0a4d..3dbbc638e9a9 100644
> --- a/drivers/gpio/gpio-bd71828.c
> +++ b/drivers/gpio/gpio-bd71828.c
> @@ -10,16 +10,6 @@
>  #define GPIO_OUT_REG(off) (BD71828_REG_GPIO_CTRL1 + (off))
>  #define HALL_GPIO_OFFSET 3
>  
> -/*
> - * These defines can be removed when
> - * "gpio: Add definition for GPIO direction"
> - * (9208b1e77d6e8e9776f34f46ef4079ecac9c3c25 in GPIO tree) gets
> merged,
> - */
> -#ifndef GPIO_LINE_DIRECTION_IN
> -	#define GPIO_LINE_DIRECTION_IN 1
> -	#define GPIO_LINE_DIRECTION_OUT 0
> -#endif
> 

Thanks once again for doing the cleanup! :)

Br,
	Matti
Axel Lin Jan. 30, 2020, 2:44 a.m. UTC | #2
Vaittinen, Matti <Matti.Vaittinen@fi.rohmeurope.com> 於 2020年1月29日 週三 下午11:06寫道:
>
>
> On Wed, 2020-01-29 at 20:30 +0800, Axel Lin wrote:
> > They are defined in gpio/driver.h now.
> >
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > ---
> >  drivers/gpio/gpio-bd71828.c | 10 ----------
> >  1 file changed, 10 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-bd71828.c b/drivers/gpio/gpio-
> > bd71828.c
> > index 04aade9e0a4d..3dbbc638e9a9 100644
> > --- a/drivers/gpio/gpio-bd71828.c
> > +++ b/drivers/gpio/gpio-bd71828.c
> > @@ -10,16 +10,6 @@
> >  #define GPIO_OUT_REG(off) (BD71828_REG_GPIO_CTRL1 + (off))
> >  #define HALL_GPIO_OFFSET 3
> >
> > -/*
> > - * These defines can be removed when
> > - * "gpio: Add definition for GPIO direction"
> > - * (9208b1e77d6e8e9776f34f46ef4079ecac9c3c25 in GPIO tree) gets
> > merged,
> > - */
> > -#ifndef GPIO_LINE_DIRECTION_IN
> > -     #define GPIO_LINE_DIRECTION_IN 1
> > -     #define GPIO_LINE_DIRECTION_OUT 0
> > -#endif
> >
>
> Thanks once again for doing the cleanup! :)
Hi Matti,
Can you reply with your Ack?
It would be easier for maintainers to pick up the patch with Ack.

Thanks,
Axel
Bartosz Golaszewski Feb. 4, 2020, 10:02 a.m. UTC | #3
śr., 29 sty 2020 o 13:30 Axel Lin <axel.lin@ingics.com> napisał(a):
>
> They are defined in gpio/driver.h now.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/gpio/gpio-bd71828.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/drivers/gpio/gpio-bd71828.c b/drivers/gpio/gpio-bd71828.c
> index 04aade9e0a4d..3dbbc638e9a9 100644
> --- a/drivers/gpio/gpio-bd71828.c
> +++ b/drivers/gpio/gpio-bd71828.c
> @@ -10,16 +10,6 @@
>  #define GPIO_OUT_REG(off) (BD71828_REG_GPIO_CTRL1 + (off))
>  #define HALL_GPIO_OFFSET 3
>
> -/*
> - * These defines can be removed when
> - * "gpio: Add definition for GPIO direction"
> - * (9208b1e77d6e8e9776f34f46ef4079ecac9c3c25 in GPIO tree) gets merged,
> - */
> -#ifndef GPIO_LINE_DIRECTION_IN
> -       #define GPIO_LINE_DIRECTION_IN 1
> -       #define GPIO_LINE_DIRECTION_OUT 0
> -#endif
> -
>  struct bd71828_gpio {
>         struct rohm_regmap_dev chip;
>         struct gpio_chip gpio;
> --
> 2.20.1
>

Applied for fixes. Thanks!

Bartosz

Patch
diff mbox series

diff --git a/drivers/gpio/gpio-bd71828.c b/drivers/gpio/gpio-bd71828.c
index 04aade9e0a4d..3dbbc638e9a9 100644
--- a/drivers/gpio/gpio-bd71828.c
+++ b/drivers/gpio/gpio-bd71828.c
@@ -10,16 +10,6 @@ 
 #define GPIO_OUT_REG(off) (BD71828_REG_GPIO_CTRL1 + (off))
 #define HALL_GPIO_OFFSET 3
 
-/*
- * These defines can be removed when
- * "gpio: Add definition for GPIO direction"
- * (9208b1e77d6e8e9776f34f46ef4079ecac9c3c25 in GPIO tree) gets merged,
- */
-#ifndef GPIO_LINE_DIRECTION_IN
-	#define GPIO_LINE_DIRECTION_IN 1
-	#define GPIO_LINE_DIRECTION_OUT 0
-#endif
-
 struct bd71828_gpio {
 	struct rohm_regmap_dev chip;
 	struct gpio_chip gpio;