[U-Boot,v2,4/4] bdinfo: fu540: print fdt base address for debugging
diff mbox series

Message ID 1580234527-29280-5-git-send-email-sagar.kadam@sifive.com
State New
Delegated to: Andes
Headers show
Series
  • Fix currently available support for flash on HiFive Unleashed
Related show

Commit Message

Sagar Kadam Jan. 28, 2020, 6:02 p.m. UTC
Add fdt->gd info to bdinfo so that it is useful for debugging
and easily use it with fdt util.

Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
---
 cmd/bdinfo.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Bin Meng Feb. 4, 2020, 12:13 p.m. UTC | #1
Hi Sagar,

On Wed, Jan 29, 2020 at 2:02 AM Sagar Shrikant Kadam
<sagar.kadam@sifive.com> wrote:
>
> Add fdt->gd info to bdinfo so that it is useful for debugging
> and easily use it with fdt util.

The commit title should be tagged with "riscv: bdinfo" as it is not
fu540 specific.

>
> Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
> ---
>  cmd/bdinfo.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c
> index d6a7175..96892b3 100644
> --- a/cmd/bdinfo.c
> +++ b/cmd/bdinfo.c
> @@ -433,6 +433,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>         print_bi_dram(bd);
>         print_num("relocaddr", gd->relocaddr);
>         print_num("reloc off", gd->reloc_off);
> +       print_num("fdt_blob", (ulong)gd->fdt_blob);
>         print_eth_ip_addr();
>         print_baudrate();
>
> --

Other than above,
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Regards,
Bin
Sagar Kadam Feb. 6, 2020, 6:44 p.m. UTC | #2
Hi Bin,

> -----Original Message-----
> From: Bin Meng <bmeng.cn@gmail.com>
> Sent: Tuesday, February 4, 2020 5:43 PM
> To: Sagar Kadam <sagar.kadam@sifive.com>
> Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Rick Chen
> <rick@andestech.com>; Paul Walmsley ( Sifive) <paul.walmsley@sifive.com>;
> Jagan Teki <jagan@amarulasolutions.com>; Anup Patel
> <anup.patel@wdc.com>
> Subject: Re: [U-Boot Patch v2 4/4] bdinfo: fu540: print fdt base address for
> debugging
> 
> Hi Sagar,
> 
> On Wed, Jan 29, 2020 at 2:02 AM Sagar Shrikant Kadam
> <sagar.kadam@sifive.com> wrote:
> >
> > Add fdt->gd info to bdinfo so that it is useful for debugging and
> > easily use it with fdt util.
> 
> The commit title should be tagged with "riscv: bdinfo" as it is not
> fu540 specific.
>
Thanks for the Reviewed-by tag.
I will include the change in next series

BR,
Sagar

> >
> > Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
> > ---
> >  cmd/bdinfo.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index d6a7175..96892b3 100644
> > --- a/cmd/bdinfo.c
> > +++ b/cmd/bdinfo.c
> > @@ -433,6 +433,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc,
> char * const argv[])
> >         print_bi_dram(bd);
> >         print_num("relocaddr", gd->relocaddr);
> >         print_num("reloc off", gd->reloc_off);
> > +       print_num("fdt_blob", (ulong)gd->fdt_blob);
> >         print_eth_ip_addr();
> >         print_baudrate();
> >
> > --
> 
> Other than above,
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> 
> Regards,
> Bin

Patch
diff mbox series

diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c
index d6a7175..96892b3 100644
--- a/cmd/bdinfo.c
+++ b/cmd/bdinfo.c
@@ -433,6 +433,7 @@  int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	print_bi_dram(bd);
 	print_num("relocaddr", gd->relocaddr);
 	print_num("reloc off", gd->reloc_off);
+	print_num("fdt_blob", (ulong)gd->fdt_blob);
 	print_eth_ip_addr();
 	print_baudrate();