[v2,2/3] tbs2910: disable loadb and loads commands
diff mbox series

Message ID 20200128170418.15912-2-GNUtoo@cyberdimension.org
State Deferred
Delegated to: Stefano Babic
Headers show
Series
  • [v2,1/3] tbs2910: disable fuse command
Related show

Commit Message

Denis 'GNUtoo' Carikli Jan. 28, 2020, 5:04 p.m. UTC
The loadb and loads commands are not needed for booting.

There are also more reliable and faster alternatives to
loadb and loads that can be used with the current configuration.

As that the resulting u-boot.imx image is already very close
to the size limit, removing the loadb and loads commands
shouldn't hurt.

With arm-linux-gnueabi-gcc 9.2.0-1 from the Parabola
GNU/Linux distribution, it shrinks the image from 388096 to
384000 bytes.

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
---
 configs/tbs2910_defconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Soeren Moch Jan. 28, 2020, 5:37 p.m. UTC | #1
On 28.01.20 18:04, Denis 'GNUtoo' Carikli wrote:
> The loadb and loads commands are not needed for booting.
>
> There are also more reliable and faster alternatives to
> loadb and loads that can be used with the current configuration.
>
> As that the resulting u-boot.imx image is already very close
> to the size limit, removing the loadb and loads commands
> shouldn't hurt.
>
> With arm-linux-gnueabi-gcc 9.2.0-1 from the Parabola
> GNU/Linux distribution, it shrinks the image from 388096 to
> 384000 bytes.
>
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>

I don't know any use case of these commands on tbs2910, so

Acked-by: Soeren Moch <smoch@web.de>

Patch
diff mbox series

diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig
index 0f12b94257..0e91eeffd4 100644
--- a/configs/tbs2910_defconfig
+++ b/configs/tbs2910_defconfig
@@ -27,6 +27,8 @@  CONFIG_CMD_MEMTEST=y
 # CONFIG_CMD_FUSE is not set
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_I2C=y
+# CONFIG_CMD_LOADB is not set
+# CONFIG_CMD_LOADS is not set
 CONFIG_CMD_MMC=y
 CONFIG_CMD_PART=y
 CONFIG_CMD_PCI=y