From patchwork Tue Nov 1 06:27:08 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 123031 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 098F0B6F7C for ; Tue, 1 Nov 2011 17:27:36 +1100 (EST) Received: from localhost ([::1]:49820 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RL7op-0002Or-Ui for incoming@patchwork.ozlabs.org; Tue, 01 Nov 2011 02:27:31 -0400 Received: from eggs.gnu.org ([140.186.70.92]:36619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RL7of-0002Is-CP for qemu-devel@nongnu.org; Tue, 01 Nov 2011 02:27:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RL7od-0004Hs-82 for qemu-devel@nongnu.org; Tue, 01 Nov 2011 02:27:21 -0400 Received: from mtagate7.uk.ibm.com ([194.196.100.167]:40982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RL7oc-0004HU-W5 for qemu-devel@nongnu.org; Tue, 01 Nov 2011 02:27:19 -0400 Received: from d06nrmr1507.portsmouth.uk.ibm.com (d06nrmr1507.portsmouth.uk.ibm.com [9.149.38.233]) by mtagate7.uk.ibm.com (8.13.1/8.13.1) with ESMTP id pA16RHfO008288 for ; Tue, 1 Nov 2011 06:27:17 GMT Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pA16RHg72310312 for ; Tue, 1 Nov 2011 06:27:17 GMT Received: from d06av01.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pA16RHgP022832 for ; Tue, 1 Nov 2011 00:27:17 -0600 Received: from localhost (sig-9-78-68-221.uk.ibm.com [9.78.68.221]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id pA16RHIo022825; Tue, 1 Nov 2011 00:27:17 -0600 From: Stefan Hajnoczi To: Date: Tue, 1 Nov 2011 06:27:08 +0000 Message-Id: <1320128830-25943-3-git-send-email-stefanha@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.7 In-Reply-To: <1320128830-25943-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1320128830-25943-1-git-send-email-stefanha@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 194.196.100.167 Cc: Anthony Liguori , Markus Armbruster , Stefan Hajnoczi Subject: [Qemu-devel] [PATCH 2/4] sysbus: Supply missing va_end() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Markus Armbruster C99 7.15.1: Each invocation of the va_start and va_copy macros shall be matched by a corresponding invocation of the va_end macro in the same function. Spotted by Coverity. Harmless on the (common) systems where va_end() does nothing. Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- hw/sysbus.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/sysbus.c b/hw/sysbus.c index 4fab5a4..fd2fc6a 100644 --- a/hw/sysbus.c +++ b/hw/sysbus.c @@ -198,6 +198,7 @@ DeviceState *sysbus_create_varargs(const char *name, sysbus_connect_irq(s, n, irq); n++; } + va_end(va); return dev; } @@ -229,6 +230,7 @@ DeviceState *sysbus_try_create_varargs(const char *name, sysbus_connect_irq(s, n, irq); n++; } + va_end(va); return dev; }