Patchwork ext4: let ext4_ext_convet_to_initialized initialize var(eh) before using it

login
register
mail settings
Submitter Yongqiang Yang
Date Nov. 1, 2011, 3:31 a.m.
Message ID <CAGBYx2ZVt1=QJFDuGrC6NxXkZtP-J51s=i9eh-zRYYx7GdcBrw@mail.gmail.com>
Download mbox | patch
Permalink /patch/123013/
State Superseded
Headers show

Comments

Yongqiang Yang - Nov. 1, 2011, 3:31 a.m.
Hi Eric,

Sorry, Cc did not work in git.

Yongqiang.
---------- Forwarded message ----------
From: Yongqiang Yang <xiaoqiangnk@gmail.com>
Date: Tue, Nov 1, 2011 at 9:21 AM
Subject: [PATCH] ext4: let ext4_ext_convet_to_initialized initialize
var(eh) before using it
To: linux-ext4@vger.kernel.org
Cc: Yongqiang Yang <xiaoqiangnk@gmail.com>


ext4_ext_convert_to_initialized() does not initialize eh before using it
and this is introduced in commit 864d21652.

Cc:Eric Gouriou <egouriou@google.com>
Cc:"Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
---

Hi Eric,

Was that patch tested?

 fs/ext4/extents.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

       ee_len = ext4_ext_get_actual_len(ex);
--
1.7.5.1

Patch

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 9dfdf8f..2798945 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2944,6 +2944,7 @@  static int
ext4_ext_convert_to_initialized(handle_t *handle,
               eof_block = map->m_lblk + map->m_len;

       depth = ext_depth(inode);
+       eh = path[depth].p_hdr;
       ex = path[depth].p_ext;
       ee_block = le32_to_cpu(ex->ee_block);