Patchwork [3/3] drivers: ata: libata-scsi.c: Add function parameter documentation

login
register
mail settings
Submitter Marcos Paulo de Souza
Date Nov. 1, 2011, 1:50 a.m.
Message ID <1320112216-23810-1-git-send-email-marcos.mage@gmail.com>
Download mbox | patch
Permalink /patch/123006/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Marcos Paulo de Souza - Nov. 1, 2011, 1:50 a.m.
Add the documentation of parameters of ata_change_queue_depth to silence the warning of make xmldocs

Signed-off-by: Marcos paulo de Souza <marcos.mage@gmail.com>
---
 drivers/ata/libata-scsi.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Randy.Dunlap - Nov. 1, 2011, 6:13 p.m.
On 10/31/2011 06:50 PM, Marcos Paulo de Souza wrote:
> Add the documentation of parameters of ata_change_queue_depth to silence the warning of make xmldocs
> 
> Signed-off-by: Marcos paulo de Souza <marcos.mage@gmail.com>

Acked-by: Randy Dunlap <rdunlap@xenotime.net>

Thanks.

> ---
>  drivers/ata/libata-scsi.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
> index 19ba770..5eceb23 100644
> --- a/drivers/ata/libata-scsi.c
> +++ b/drivers/ata/libata-scsi.c
> @@ -1216,6 +1216,10 @@ void ata_scsi_slave_destroy(struct scsi_device *sdev)
>  
>  /**
>   *	__ata_change_queue_depth - helper for ata_scsi_change_queue_depth
> + *	@ap: ATA port to which the device change the queue depth
> + *	@sdev: SCSI device to configure queue depth for
> + *	@queue_depth: new queue depth
> + *	@reason: calling context
>   *
>   *	libsas and libata have different approaches for associating a sdev to
>   *	its ata_port.
Marcos Paulo de Souza - Nov. 8, 2011, 3:31 p.m.
ping?

2011/11/1, Randy Dunlap <rdunlap@xenotime.net>:
> On 10/31/2011 06:50 PM, Marcos Paulo de Souza wrote:
>> Add the documentation of parameters of ata_change_queue_depth to silence
>> the warning of make xmldocs
>>
>> Signed-off-by: Marcos paulo de Souza <marcos.mage@gmail.com>
>
> Acked-by: Randy Dunlap <rdunlap@xenotime.net>
>
> Thanks.
>
>> ---
>>  drivers/ata/libata-scsi.c |    4 ++++
>>  1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
>> index 19ba770..5eceb23 100644
>> --- a/drivers/ata/libata-scsi.c
>> +++ b/drivers/ata/libata-scsi.c
>> @@ -1216,6 +1216,10 @@ void ata_scsi_slave_destroy(struct scsi_device
>> *sdev)
>>
>>  /**
>>   *	__ata_change_queue_depth - helper for ata_scsi_change_queue_depth
>> + *	@ap: ATA port to which the device change the queue depth
>> + *	@sdev: SCSI device to configure queue depth for
>> + *	@queue_depth: new queue depth
>> + *	@reason: calling context
>>   *
>>   *	libsas and libata have different approaches for associating a sdev to
>>   *	its ata_port.
>
>
> --
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>

Patch

diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 19ba770..5eceb23 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -1216,6 +1216,10 @@  void ata_scsi_slave_destroy(struct scsi_device *sdev)
 
 /**
  *	__ata_change_queue_depth - helper for ata_scsi_change_queue_depth
+ *	@ap: ATA port to which the device change the queue depth
+ *	@sdev: SCSI device to configure queue depth for
+ *	@queue_depth: new queue depth
+ *	@reason: calling context
  *
  *	libsas and libata have different approaches for associating a sdev to
  *	its ata_port.