Patchwork block.c typo in comment fixed

login
register
mail settings
Submitter matthias.bgg@googlemail.com
Date Nov. 1, 2011, 1:36 a.m.
Message ID <1320111402-1816-1-git-send-email-matthias.bgg@gmail.com>
Download mbox | patch
Permalink /patch/123002/
State New
Headers show

Comments

matthias.bgg@googlemail.com - Nov. 1, 2011, 1:36 a.m.
From: Matthias Brugger <matthias.bgg@gmail.com>


Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---
 block.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Stefan Weil - Nov. 1, 2011, 7:24 a.m.
Am 01.11.2011 02:36, schrieb matthias.bgg@googlemail.com:
> From: Matthias Brugger<matthias.bgg@gmail.com>
>
>
> Signed-off-by: Matthias Brugger<matthias.bgg@gmail.com>
> ---
>   block.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/block.c b/block.c
> index 9bb236c..480aae2 100644
> --- a/block.c
> +++ b/block.c
> @@ -497,7 +497,7 @@ static int bdrv_open_common(BlockDriverState *bs, const char *filename,
>       open_flags = flags&  ~(BDRV_O_SNAPSHOT | BDRV_O_NO_BACKING);
>
>       /*
> -     * Snapshots should be writable.
> +     * Snapshots should be writeable.
>        */
>       if (bs->is_temporary) {
>           open_flags |= BDRV_O_RDWR;

Hi Matthias,

both writable and writeable seem to be correct,
but http://oxforddictionaries.com/ says that writable is the only
correct spelling.

Therefore your patch should not be used.

Cheers,
Stefan
Stefan Hajnoczi - Nov. 1, 2011, 8:39 a.m.
On Tue, Nov 01, 2011 at 01:36:42AM +0000, matthias.bgg@googlemail.com wrote:
> From: Matthias Brugger <matthias.bgg@gmail.com>
> 
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
>  block.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

"Writable" is also a common spelling.  Try git grep writable and compare
against git grep writeable.  In qemu.git "writable" actually dominates
by a large majority so we should leave this alone.

Stefan
matthias.bgg@googlemail.com - Nov. 1, 2011, 11:53 a.m.
On 11/01/2011 08:39 AM, Stefan Hajnoczi wrote:
> On Tue, Nov 01, 2011 at 01:36:42AM +0000, matthias.bgg@googlemail.com wrote:
>> From: Matthias Brugger<matthias.bgg@gmail.com>
>>
>>
>> Signed-off-by: Matthias Brugger<matthias.bgg@gmail.com>
>> ---
>>   block.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> "Writable" is also a common spelling.  Try git grep writable and compare
> against git grep writeable.  In qemu.git "writable" actually dominates
> by a large majority so we should leave this alone.
>
> Stefan

Alright, I didn't know that. Sorry for the noise.

Regards,
Matthias

Patch

diff --git a/block.c b/block.c
index 9bb236c..480aae2 100644
--- a/block.c
+++ b/block.c
@@ -497,7 +497,7 @@  static int bdrv_open_common(BlockDriverState *bs, const char *filename,
     open_flags = flags & ~(BDRV_O_SNAPSHOT | BDRV_O_NO_BACKING);
 
     /*
-     * Snapshots should be writable.
+     * Snapshots should be writeable.
      */
     if (bs->is_temporary) {
         open_flags |= BDRV_O_RDWR;