Message ID | 1580142994-1836-4-git-send-email-liam.merwick@oracle.com |
---|---|
State | New |
Headers | show |
Series | tests/boot_linux_console: add extra boot acceptance tests | expand |
On Mon, Jan 27, 2020 at 04:36:31PM +0000, Liam Merwick wrote: > The second param in extract_from_deb() is 'path' not 'file' > > Signed-off-by: Liam Merwick <liam.merwick@oracle.com> > --- > tests/acceptance/boot_linux_console.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> > > diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py > index 8daf6461ffac..43bc928b03a2 100644 > --- a/tests/acceptance/boot_linux_console.py > +++ b/tests/acceptance/boot_linux_console.py > @@ -40,7 +40,7 @@ class BootLinuxConsole(Test): > Extracts a file from a deb package into the test workdir > > :param deb: path to the deb archive > - :param file: path within the deb archive of the file to be extracted > + :param path: path within the deb archive of the file to be extracted > :returns: path of the extracted file > """ > cwd = os.getcwd() > -- > 1.8.3.1 > --
On 1/27/20 2:36 PM, Liam Merwick wrote: > The second param in extract_from_deb() is 'path' not 'file' > > Signed-off-by: Liam Merwick <liam.merwick@oracle.com> > --- > tests/acceptance/boot_linux_console.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py > index 8daf6461ffac..43bc928b03a2 100644 > --- a/tests/acceptance/boot_linux_console.py > +++ b/tests/acceptance/boot_linux_console.py > @@ -40,7 +40,7 @@ class BootLinuxConsole(Test): > Extracts a file from a deb package into the test workdir > > :param deb: path to the deb archive > - :param file: path within the deb archive of the file to be extracted > + :param path: path within the deb archive of the file to be extracted Well noted! Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com> > :returns: path of the extracted file > """ > cwd = os.getcwd()
On 1/27/20 5:36 PM, Liam Merwick wrote: > The second param in extract_from_deb() is 'path' not 'file' > > Signed-off-by: Liam Merwick <liam.merwick@oracle.com> > --- > tests/acceptance/boot_linux_console.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py > index 8daf6461ffac..43bc928b03a2 100644 > --- a/tests/acceptance/boot_linux_console.py > +++ b/tests/acceptance/boot_linux_console.py > @@ -40,7 +40,7 @@ class BootLinuxConsole(Test): > Extracts a file from a deb package into the test workdir > > :param deb: path to the deb archive > - :param file: path within the deb archive of the file to be extracted > + :param path: path within the deb archive of the file to be extracted > :returns: path of the extracted file > """ > cwd = os.getcwd() > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Also, applied to my python-next tree: https://gitlab.com/philmd/qemu/commits/python-next
diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py index 8daf6461ffac..43bc928b03a2 100644 --- a/tests/acceptance/boot_linux_console.py +++ b/tests/acceptance/boot_linux_console.py @@ -40,7 +40,7 @@ class BootLinuxConsole(Test): Extracts a file from a deb package into the test workdir :param deb: path to the deb archive - :param file: path within the deb archive of the file to be extracted + :param path: path within the deb archive of the file to be extracted :returns: path of the extracted file """ cwd = os.getcwd()
The second param in extract_from_deb() is 'path' not 'file' Signed-off-by: Liam Merwick <liam.merwick@oracle.com> --- tests/acceptance/boot_linux_console.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)