Patchwork powerpc/83xx: Enable FIXED_PHY in mpc834x_itx and mpc83xx defconfigs

login
register
mail settings
Submitter Anton Vorontsov
Date Dec. 4, 2008, 5:52 p.m.
Message ID <20081204175231.GA28554@oksana.dev.rtsoft.ru>
Download mbox | patch
Permalink /patch/12299/
State Accepted
Delegated to: Kumar Gala
Headers show

Comments

Anton Vorontsov - Dec. 4, 2008, 5:52 p.m.
This is needed so that Vitesse 7385 5-port switch could work on
MPC8349E-mITX boards.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---

On Thu, Dec 04, 2008 at 11:15:32AM -0600, Timur Tabi wrote:
> The Freescale MPC8349e-MITX reference board has two TSECs, the second
> of which (eth1) is attached to a Vitesse 7385 5-port switch.
> 
> Using the latest U-Boot, Kernel, and device tree, I cannot bring up
> eth1.  When I try, I get this message:
> 
> [root@tintin root]# ifconfig eth1 up
> 0:01 not found
> eth1: Could not attach to PHY
> SIOCSIFFLAGS: No such device
> 
> Unfortunately, I don't even know what this means.

The FIXED_PHY driver isn't enabled in the defconfig. Following
patch should fix the issue.

 arch/powerpc/configs/83xx/mpc834x_itx_defconfig |    2 +-
 arch/powerpc/configs/mpc83xx_defconfig          |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Timur Tabi - Dec. 4, 2008, 7:18 p.m.
Anton Vorontsov wrote:

> The FIXED_PHY driver isn't enabled in the defconfig. Following
> patch should fix the issue.
> 
>  arch/powerpc/configs/83xx/mpc834x_itx_defconfig |    2 +-
>  arch/powerpc/configs/mpc83xx_defconfig          |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Acked-by: Timur Tabi <timur@freescale.com>

Kumar, please apply.
Kumar Gala - Dec. 5, 2008, 12:48 a.m.
On Dec 4, 2008, at 11:52 AM, Anton Vorontsov wrote:

> This is needed so that Vitesse 7385 5-port switch could work on
> MPC8349E-mITX boards.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---

applied to merge.

Guys, can you put a [for 2.6.28] or something if a patch is intended  
for .28.. this way I hopefully pay a bit more attention.

- k

Patch

diff --git a/arch/powerpc/configs/83xx/mpc834x_itx_defconfig b/arch/powerpc/configs/83xx/mpc834x_itx_defconfig
index e55ff7c..07a674f 100644
--- a/arch/powerpc/configs/83xx/mpc834x_itx_defconfig
+++ b/arch/powerpc/configs/83xx/mpc834x_itx_defconfig
@@ -723,7 +723,7 @@  CONFIG_CICADA_PHY=y
 # CONFIG_BROADCOM_PHY is not set
 # CONFIG_ICPLUS_PHY is not set
 # CONFIG_REALTEK_PHY is not set
-# CONFIG_FIXED_PHY is not set
+CONFIG_FIXED_PHY=y
 # CONFIG_MDIO_BITBANG is not set
 # CONFIG_NET_ETHERNET is not set
 CONFIG_NETDEV_1000=y
diff --git a/arch/powerpc/configs/mpc83xx_defconfig b/arch/powerpc/configs/mpc83xx_defconfig
index 15eb30c..d582014 100644
--- a/arch/powerpc/configs/mpc83xx_defconfig
+++ b/arch/powerpc/configs/mpc83xx_defconfig
@@ -682,7 +682,7 @@  CONFIG_VITESSE_PHY=y
 # CONFIG_BROADCOM_PHY is not set
 CONFIG_ICPLUS_PHY=y
 # CONFIG_REALTEK_PHY is not set
-# CONFIG_FIXED_PHY is not set
+CONFIG_FIXED_PHY=y
 # CONFIG_MDIO_BITBANG is not set
 CONFIG_NET_ETHERNET=y
 CONFIG_MII=y