| Message ID | 1580117304-12682-2-git-send-email-hadar.gat@arm.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | hw_random: introduce Arm CryptoCell TRNG driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Mon, 27 Jan 2020 11:28:22 +0200, Hadar Gat wrote: > The Arm CryptoCell is a hardware security engine. This patch adds DT > bindings for its TRNG (True Random Number Generator) engine. > > Signed-off-by: Hadar Gat <hadar.gat@arm.com> > --- > .../devicetree/bindings/rng/arm-cctrng.yaml | 49 ++++++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rng/arm-cctrng.yaml > My bot found errors running 'make dt_binding_check' on your patch: warning: no schema found in file: Documentation/devicetree/bindings/rng/arm-cctrng.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rng/arm-cctrng.yaml: ignoring, error parsing file Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node Documentation/devicetree/bindings/rng/arm-cctrng.yaml: while parsing a block mapping in "<unicode string>", line 42, column 3 did not find expected key in "<unicode string>", line 47, column 3 Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/rng/arm-cctrng.example.dts' failed make[1]: *** [Documentation/devicetree/bindings/rng/arm-cctrng.example.dts] Error 1 Makefile:1263: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1229638 Please check and re-submit.
Rob, Thank you for noticing and notifying. I will fix this and re-submit. Hadar -----Original Message----- From: Rob Herring <robh@kernel.org> Sent: Monday, 27 January 2020 16:28 To: Hadar Gat <Hadar.Gat@arm.com> Cc: Matt Mackall <mpm@selenic.com>; Herbert Xu <herbert@gondor.apana.org.au>; David S. Miller <davem@davemloft.net>; Jonathan Cameron <Jonathan.Cameron@huawei.com>; linux-crypto@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Gilad Ben-Yossef <gilad@benyossef.com>; Ofir Drang <Ofir.Drang@arm.com>; Hadar Gat <Hadar.Gat@arm.com> Subject: Re: [PATCH 1/3] dt-bindings: add device tree binding for Arm CryptoCell trng engine On Mon, 27 Jan 2020 11:28:22 +0200, Hadar Gat wrote: > The Arm CryptoCell is a hardware security engine. This patch adds DT > bindings for its TRNG (True Random Number Generator) engine. > > Signed-off-by: Hadar Gat <hadar.gat@arm.com> > --- > .../devicetree/bindings/rng/arm-cctrng.yaml | 49 ++++++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/rng/arm-cctrng.yaml > My bot found errors running 'make dt_binding_check' on your patch: warning: no schema found in file: Documentation/devicetree/bindings/rng/arm-cctrng.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rng/arm-cctrng.yaml: ignoring, error parsing file Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node Documentation/devicetree/bindings/rng/arm-cctrng.yaml: while parsing a block mapping in "<unicode string>", line 42, column 3 did not find expected key in "<unicode string>", line 47, column 3 Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/rng/arm-cctrng.example.dts' failed make[1]: *** [Documentation/devicetree/bindings/rng/arm-cctrng.example.dts] Error 1 Makefile:1263: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1229638 Please check and re-submit. IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
diff --git a/Documentation/devicetree/bindings/rng/arm-cctrng.yaml b/Documentation/devicetree/bindings/rng/arm-cctrng.yaml new file mode 100644 index 0000000..d68693f --- /dev/null +++ b/Documentation/devicetree/bindings/rng/arm-cctrng.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/crypto/arm-cctrng.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Arm ZrustZone CryptoCell TRNG engine + +maintainers: + - Hadar Gat <hadar.gat@arm.com> + +description: |+ + Arm ZrustZone CryptoCell TRNG (True Random Number Generator) engine. + +properties: + compatible: + description: Should be "arm,cryptocell-7x3-trng" + + interrupts: + description: Interrupt number for the device. + maxItems: 1 + + reg: + description: Base physical address of the engine and length of memory + mapped region. + maxItems: 1 + + rosc-ratio: + description: Sampling ratio values from calibration for 4 ring oscillators. + maxItems: 1 + + clocks: + description: Reference to the crypto engine clock. + +required: + - compatible + - interrupts + - reg + - rosc-ratio + +examples: + arm_cctrng: arm_cctrng@60000000 { + compatible = "arm,cryptocell-7x3-trng"; + interrupts = <0 29 4>; + reg = <0x60000000 0x10000>; + rosc-ratio = <5000 1000 500 0>; + }; + +additionalProperties: false
The Arm CryptoCell is a hardware security engine. This patch adds DT bindings for its TRNG (True Random Number Generator) engine. Signed-off-by: Hadar Gat <hadar.gat@arm.com> --- .../devicetree/bindings/rng/arm-cctrng.yaml | 49 ++++++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/rng/arm-cctrng.yaml