Message ID | 20200126220508.87.Ia817c48e5544c95f117f45b37a2581f54d67392b@changeid |
---|---|
State | RFC |
Delegated to: | Bin Meng |
Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=Wr9V1EZm; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 485dTj4d5jz9sR1 for <incoming@patchwork.ozlabs.org>; Mon, 27 Jan 2020 16:24:25 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D496F81915; Mon, 27 Jan 2020 06:13:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Wr9V1EZm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CB08B81764; Mon, 27 Jan 2020 06:10:19 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-il1-x142.google.com (mail-il1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3007C817BF for <u-boot@lists.denx.de>; Mon, 27 Jan 2020 06:09:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-il1-x142.google.com with SMTP id g12so6460831ild.2 for <u-boot@lists.denx.de>; Sun, 26 Jan 2020 21:09:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bJaPQCwOKX3e657cVwsAmcVVe0lXJnuAcVj7bnEdCfE=; b=Wr9V1EZmssvd9boClxka0EPEUH/HaF72mOXVwq8M0NECKbL6vjfQMkAs4xBMPpZ27h c5+4mMgHb2KbZ5Zn2WgK/qMdcapXlXskP2/JzZjQuKTKiiYmN2qN8+HP5X/s2yIqXC8P ZUbmrF9w/uLgM+bgchvEJqKOzQ4poHtZRjlvk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bJaPQCwOKX3e657cVwsAmcVVe0lXJnuAcVj7bnEdCfE=; b=W94Gr+eKtfJ8gy2uTCmLR1GmzRINdgEI9gUAyguLWXyiGB+1Uv/weSmm6feWa8l2BJ tCdOeDTdIh67ZjUry5+wliCvZeEAb2toyEiWxakRhkgp9Bw+ojj+WZJhoGfevNTHP6N+ g+enK8n5gsOs8CcGXnKUUAW4/sxPPFkXjWsTEnnR9vzMvTruoF/HQoXi3WXkG9VgcLMj DOXSrhEzGbFpf6oZaZ9dqpnaHQ28hk0WRwm6xf+YY8rbOgSlmg37m0cPIdd+DDRke3l/ NPnr0/zi6rUCOP+wavFBaTN4evkydjNjDYHPgXdy9sKOyfw0dOtlZE1UrAmnQs2xMQL2 BYrw== X-Gm-Message-State: APjAAAW9rFXejUYqgC7JgNtJwVSp77kC48vTojsETlGcdDdAuAJ8mrky VzEqdUJVaFMxLqgzVfxvOnfm+WLDwOt8sg== X-Google-Smtp-Source: APXvYqw0+cwKXaQx7O65whCEuJysawyunm4zNSpJnQiFofU6H3wsP7wDb5nG7lDduyUfVJJ1jrasRg== X-Received: by 2002:a92:3991:: with SMTP id h17mr14018534ilf.131.1580101773995; Sun, 26 Jan 2020 21:09:33 -0800 (PST) Received: from kiwi.bld.corp.google.com ([2620:15c:183:0:8223:87c:a681:66aa]) by smtp.gmail.com with ESMTPSA id h23sm4313195ilf.57.2020.01.26.21.09.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jan 2020 21:09:33 -0800 (PST) From: Simon Glass <sjg@chromium.org> To: U-Boot Mailing List <u-boot@lists.denx.de> Subject: [PATCH 087/108] x86: apl: Add a check for reading the FSP-S config Date: Sun, 26 Jan 2020 22:06:34 -0700 Message-Id: <20200126220508.87.Ia817c48e5544c95f117f45b37a2581f54d67392b@changeid> X-Mailer: git-send-email 2.25.0.341.g760bfbb309-goog In-Reply-To: <20200127050655.170614-1-sjg@chromium.org> References: <20200127050655.170614-1-sjg@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.26 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <https://lists.denx.de/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <https://lists.denx.de/pipermail/u-boot/> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <https://lists.denx.de/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de> X-Virus-Scanned: clamav-milter 0.101.4 at phobos.denx.de X-Virus-Status: Clean |
Series |
RFC: dm: Add programatic generation of ACPI tables
|
expand
|
diff --git a/arch/x86/cpu/apollolake/fsp_s.c b/arch/x86/cpu/apollolake/fsp_s.c index e7e0c30873..d1aad7a094 100644 --- a/arch/x86/cpu/apollolake/fsp_s.c +++ b/arch/x86/cpu/apollolake/fsp_s.c @@ -350,8 +350,10 @@ int fsps_update_config(struct udevice *dev, ulong rom_offset, apl = malloc(sizeof(*apl)); if (!apl) - return log_msg_ret("config", -ENOMEM); - get_config(dev, apl); + return log_msg_ret("alloc", -ENOMEM); + ret = get_config(dev, apl); + if (ret) + return log_msg_ret("config", ret); cfg->ish_enable = 0; cfg->enable_sata = 0; diff --git a/arch/x86/dts/chromebook_coral.dts b/arch/x86/dts/chromebook_coral.dts index 7ba38d7791..3c6f14310f 100644 --- a/arch/x86/dts/chromebook_coral.dts +++ b/arch/x86/dts/chromebook_coral.dts @@ -497,13 +497,13 @@ * If the Board has PERST_0 signal, assign the GPIO * If the Board does not have PERST_0, assign GPIO_PRT0_UDEF * - * This are not used yet, so comment them out for now. - * - * prt0-gpio = <GPIO_122>; - * - * GPIO for SD card detect - * sdcard-cd-gpio = <GPIO_177>; + * This should be converted to real GPIOs and ideally stored in the + * device they relate to. */ + prt0-gpio = <GPIO_122>; + + /* GPIO for SD card detect */ + sdcard-cd-gpio = <GPIO_177>; /* * Order is emmc-tx-data-cntl1, emmc-tx-data-cntl2,
This currently fails as two required items are commented out. Put them back in and add a check that reading the config succeeds. Both of these items need a little more work to put them in an appropriate driver at some point. Signed-off-by: Simon Glass <sjg@chromium.org> --- arch/x86/cpu/apollolake/fsp_s.c | 6 ++++-- arch/x86/dts/chromebook_coral.dts | 12 ++++++------ 2 files changed, 10 insertions(+), 8 deletions(-)