diff mbox series

[v2,net-next] soreuseport: Cleanup duplicate initialization of more_reuse->max_socks.

Message ID 336488a1ae764c05acffe4b930dfe787@EX13MTAUEA002.ant.amazon.com
State Accepted
Delegated to: David Miller
Headers show
Series [v2,net-next] soreuseport: Cleanup duplicate initialization of more_reuse->max_socks. | expand

Commit Message

Kuniyuki Iwashima Jan. 25, 2020, 10:41 a.m. UTC 
From: Kuniyuki Iwashima <kuniyu@amazon.co.jp>

reuseport_grow() does not need to initialize the more_reuse->max_socks
again. It is already initialized in __reuseport_alloc().

Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
---
 net/core/sock_reuseport.c | 1 -
 1 file changed, 1 deletion(-)

Comments

David Miller Jan. 27, 2020, 10:01 a.m. UTC | #1 
From: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
Date: Sat, 25 Jan 2020 10:41:02 +0000

> From: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
> 
> reuseport_grow() does not need to initialize the more_reuse->max_socks
> again. It is already initialized in __reuseport_alloc().
> 
> Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.co.jp>

Applied.
diff mbox series

Patch

diff --git a/net/core/sock_reuseport.c b/net/core/sock_reuseport.c
index f19f179538b9..91e9f2223c39 100644
--- a/net/core/sock_reuseport.c
+++ b/net/core/sock_reuseport.c
@@ -107,7 +107,6 @@  static struct sock_reuseport *reuseport_grow(struct sock_reuseport *reuse)
 	if (!more_reuse)
 		return NULL;
 
-	more_reuse->max_socks = more_socks_size;
 	more_reuse->num_socks = reuse->num_socks;
 	more_reuse->prog = reuse->prog;
 	more_reuse->reuseport_id = reuse->reuseport_id;