read_all: skip eeprom and nvmem
diff mbox series

Message ID 79fee43729701f3a3d46c6cbc26fa3f2402e182e.1579877705.git.jstancek@redhat.com
State Accepted, archived
Headers show
Series
  • read_all: skip eeprom and nvmem
Related show

Commit Message

Jan Stancek Jan. 24, 2020, 2:56 p.m. UTC
Big Power9 NV systems are failing to complete the test, as they
spend lot of time on /sys/devices/platform, trying to read dozens
of low level files like eeprom or nvmem. Each adds couple seconds,
eventually pushing test over timeout.

User or system admin is unlikely to ever need to access these
entries, so skip them.

Signed-off-by: Jan Stancek <jstancek@redhat.com>
---
 testcases/kernel/fs/read_all/read_all.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Petr Vorel Jan. 28, 2020, 9:30 p.m. UTC | #1
Hi Jan,

> Big Power9 NV systems are failing to complete the test, as they
> spend lot of time on /sys/devices/platform, trying to read dozens
> of low level files like eeprom or nvmem. Each adds couple seconds,
> eventually pushing test over timeout.

> User or system admin is unlikely to ever need to access these
> entries, so skip them.
LGTM.
Acked-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr
Jan Stancek Jan. 29, 2020, 9:11 a.m. UTC | #2
----- Original Message -----
> Hi Jan,
> 
> > Big Power9 NV systems are failing to complete the test, as they
> > spend lot of time on /sys/devices/platform, trying to read dozens
> > of low level files like eeprom or nvmem. Each adds couple seconds,
> > eventually pushing test over timeout.
> 
> > User or system admin is unlikely to ever need to access these
> > entries, so skip them.
> LGTM.
> Acked-by: Petr Vorel <pvorel@suse.cz>

Thanks, pushed.

Patch
diff mbox series

diff --git a/testcases/kernel/fs/read_all/read_all.c b/testcases/kernel/fs/read_all/read_all.c
index 47f8532231d9..f091f2f64a4d 100644
--- a/testcases/kernel/fs/read_all/read_all.c
+++ b/testcases/kernel/fs/read_all/read_all.c
@@ -85,6 +85,8 @@  static char *blacklist[] = {
 	NULL, /* reserved for -e parameter */
 	"/sys/power/wakeup_count",
 	"/sys/kernel/debug/*",
+	"/sys/devices/platform/*/eeprom",
+	"/sys/devices/platform/*/nvmem",
 };
 
 static struct tst_option options[] = {