[v3,1/2] dt-bindings: usb: dwc2: add support for STM32MP15 SoCs USB OTG HS and FS
diff mbox series

Message ID 20200124084131.23749-2-amelie.delaunay@st.com
State Not Applicable
Headers show
Series
  • USB DWC2 support for STM32MP15 SoCs USB OTG
Related show

Checks

Context Check Description
robh/checkpatch success

Commit Message

Amelie Delaunay Jan. 24, 2020, 8:41 a.m. UTC
Add the specific compatible string for the DWC2 IP found in the STM32MP15
SoCs.
STM32MP15 SoCs uses sensing comparators to detect Vbus valid levels and
ID pin state. usb33d-supply described the regulator supplying Vbus and ID
sensing comparators.

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 Documentation/devicetree/bindings/usb/dwc2.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Rob Herring Jan. 27, 2020, 2:29 p.m. UTC | #1
On Fri, Jan 24, 2020 at 09:41:30AM +0100, Amelie Delaunay wrote:
> Add the specific compatible string for the DWC2 IP found in the STM32MP15
> SoCs.
> STM32MP15 SoCs uses sensing comparators to detect Vbus valid levels and
> ID pin state. usb33d-supply described the regulator supplying Vbus and ID
> sensing comparators.
> 
> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
> ---
>  Documentation/devicetree/bindings/usb/dwc2.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)

Reviewed-by: Rob Herring <robh@kernel.org>
Felipe Balbi Jan. 31, 2020, 1:36 p.m. UTC | #2
Hi,

Amelie Delaunay <amelie.delaunay@st.com> writes:

> Add the specific compatible string for the DWC2 IP found in the STM32MP15
> SoCs.
> STM32MP15 SoCs uses sensing comparators to detect Vbus valid levels and
> ID pin state. usb33d-supply described the regulator supplying Vbus and ID
> sensing comparators.
>
> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>

This doesn't apply. dwc2 bindings is still in .txt format. I have taken
patch 2, though.
Amelie Delaunay Jan. 31, 2020, 4:13 p.m. UTC | #3
Hi,

On 1/31/20 2:36 PM, Felipe Balbi wrote:
> Hi,
> 
> Amelie Delaunay <amelie.delaunay@st.com> writes:
> 
>> Add the specific compatible string for the DWC2 IP found in the STM32MP15
>> SoCs.
>> STM32MP15 SoCs uses sensing comparators to detect Vbus valid levels and
>> ID pin state. usb33d-supply described the regulator supplying Vbus and ID
>> sensing comparators.
>>
>> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
> 
> This doesn't apply. dwc2 bindings is still in .txt format. I have taken
> patch 2, though.
>

Thanks for taking driver patch.

Rob, would you mind to take patch 1 (Yaml binding update) in your tree ?

Regards,
Amelie
Rob Herring Jan. 31, 2020, 8:06 p.m. UTC | #4
On Fri, Jan 31, 2020 at 05:13:25PM +0100, Amelie DELAUNAY wrote:
> Hi,
> 
> On 1/31/20 2:36 PM, Felipe Balbi wrote:
> > Hi,
> > 
> > Amelie Delaunay <amelie.delaunay@st.com> writes:
> > 
> > > Add the specific compatible string for the DWC2 IP found in the STM32MP15
> > > SoCs.
> > > STM32MP15 SoCs uses sensing comparators to detect Vbus valid levels and
> > > ID pin state. usb33d-supply described the regulator supplying Vbus and ID
> > > sensing comparators.
> > > 
> > > Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
> > 
> > This doesn't apply. dwc2 bindings is still in .txt format. I have taken
> > patch 2, though.
> > 
> 
> Thanks for taking driver patch.
> 
> Rob, would you mind to take patch 1 (Yaml binding update) in your tree ?

Done.

Rob

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
index 71cf7ba32237..e95ba9373023 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.yaml
+++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
@@ -58,6 +58,8 @@  properties:
       - const: st,stm32f4x9-fsotg
       - const: st,stm32f4x9-hsotg
       - const: st,stm32f7-hsotg
+      - const: st,stm32mp15-fsotg
+      - const: st,stm32mp15-hsotg
       - const: samsung,s3c6400-hsotg
 
   reg:
@@ -103,6 +105,10 @@  properties:
   vusb_a-supply:
     description: phandle to voltage regulator of analog section.
 
+  vusb33d-supply:
+    description: reference to the VBUS and ID sensing comparators supply, in
+      order to perform OTG operation, used on STM32MP15 SoCs.
+
   dr_mode:
     enum: [host, peripheral, otg]