From patchwork Thu Jan 23 23:06:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 1228589 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-518190-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha1 header.s=default header.b=iLxQXc6C; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UZXh/y2D; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 483dFy1bwpz9sNx for ; Fri, 24 Jan 2020 10:07:16 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:subject:from:reply-to:to:date:mime-version :content-type; q=dns; s=default; b=BozkbbiQOmKYLsgoQwzky7yKCg/xG T05Gi2U4JEgxUvKsX8L3Y4e00yjjsekQF6zyJ13eRJKUJ/tF2TTqYsDEEUvUYHlb UETden4mCWnuawMFm22VmlE+9t1OnA97EEoHZwYsmsbAWtG84RVE4Slvw1WDay0q Pw1jAA1wkSkD7Y= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:subject:from:reply-to:to:date:mime-version :content-type; s=default; bh=72E+FntELsysY5LBjeSUHOSoJWI=; b=iLx QXc6CjqizZFkWWJICjYBNHjZl5GK0MS8Jsz4R59gb/LBj+Xbdi7WAzr4EZr3fSdO fZ/iDGSVgFoQ4GgdQOpHWwVTEGn1HBbxbPmYwDusYNAnEXLD1Ymiov+Z5ySuVT1X yVfrDSM55xjmjm1uUFohH+H4dz3ECCFgqT7/sGzo= Received: (qmail 93012 invoked by alias); 23 Jan 2020 23:07:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 93003 invoked by uid 89); 23 Jan 2020 23:07:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (205.139.110.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Jan 2020 23:07:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579820823; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type; bh=77HzO8bWEKXXwe1Zb5RpEbI3v5/N+vFNHg8byQXkqwE=; b=UZXh/y2D9aiDtqvW60Iu56YZwcrprrWtcphPs1bHKYWH9Ix+TCeSyWUEyJLAVMmK8qHmok MZ1kG09x0UtkENBL2TGupLVaNKfIwRz3Lme5PCqbBdTBqXTFebmFAzC0j5ey/jiSXo91qq H07rcoGccOLbiW3kwoJznelWfefeZPc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-308-DbY0JUqYNziIdrbl4xomHg-1; Thu, 23 Jan 2020 18:07:01 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7A26C801E67 for ; Thu, 23 Jan 2020 23:07:00 +0000 (UTC) Received: from ovpn-112-23.phx2.redhat.com (ovpn-112-23.phx2.redhat.com [10.3.112.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 259BA3B7 for ; Thu, 23 Jan 2020 23:06:59 +0000 (UTC) Message-ID: <5801de2a28dc04bacc399a7ce659d54b2020d3e2.camel@redhat.com> Subject: [committed] [PR translation/90162] Fix diagnostic to better follow guidelines From: Jeff Law Reply-To: law@redhat.com To: gcc-patches@gcc.gnu.org Date: Thu, 23 Jan 2020 16:06:59 -0700 User-Agent: Evolution 3.34.3 (3.34.3-1.fc31) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-IsSubscribed: yes Not a regression, but only affects a diagnostic on the H8 port. As pointed out in the BZ, we should not be emitting an exclamation point in the diagnostic and the capitalization was incorrect. Fixed by the attached patch which I've committed to the trunk. Jeff commit dfa075d00d396f554b4aca183c3ca685fbb73bbd Author: Jeff Law Date: Thu Jan 23 16:03:27 2020 -0700 Fix diagnostic text on H8. * config/h8300/h8300.c (h8300_option_override): Fix diagnostic text. diff --git a/gcc/ChangeLog b/gcc/ChangeLog index c00deeed142..023e9c398ea 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,7 @@ +2020-01-23 Jeff Law + + * config/h8300/h8300.c (h8300_option_override): Fix diagnostic text. + 2020-01-23 Mikael Tillenius * config/h8300/h8300.h (FUNCTION_PROFILER): Fix emission of diff --git a/gcc/config/h8300/h8300.c b/gcc/config/h8300/h8300.c index 6c84b0abea7..ffbfa9eaaa9 100644 --- a/gcc/config/h8300/h8300.c +++ b/gcc/config/h8300/h8300.c @@ -378,8 +378,8 @@ h8300_option_override (void) if ((!TARGET_H8300S && TARGET_NEXR) && (!TARGET_H8300SX && TARGET_NEXR)) { - warning (OPT_mno_exr, "%<-mno-exr%> valid only with %<-ms%> or " - "%<-msx%> - Option ignored!"); + warning (OPT_mno_exr, "%<-mno-exr%> is valid only with %<-ms%> or " + "%<-msx%> - option ignored"); } #ifdef H8300_LINUX