Message ID | 20200123221817.199969-1-matthewmwang@chromium.org |
---|---|
State | Accepted |
Headers | show
Return-Path: <hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20170209 header.b=PcAvg1A9; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=hDa1vcno; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 483cCW3M6bz9s1x for <incoming@patchwork.ozlabs.org>; Fri, 24 Jan 2020 09:20:07 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=OTFF3Dc9QdPpdVdAmOfp+6Tn2zTpg+IXQFy6LdzV4TA=; b=PcAvg1A9ptrZLI MmJW1gM9TDrggaMUJVYKLG5H2vTUVD+LrF/CagaexNN1oG43Gcz7jEwKljwVzbC9ohg13SMyOGlU/ 7CW8QhW7W9PLJiCPDFvvwuKoYsgtcy1MXqad1/Vxyvb64/YYizbLXXsLVMK06R8fXbqGSpWxKGmOP dnxJ0hVwdeKlsPDNTdEjp7Pile3HL/IrSpd6chd4m0mUqL1HM/gOcAkCH5qAwnrVEEtz/nP/+gFov /q3kCdJoOVNbd3CzN/Mi76a4Jkxf5cM0J+unsjdSc0qWIN0SAprepcExdhhDDrFsMa0J2HB8vt/kT znRb11ugB82NsccGiU3A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iukpS-0005Xa-CX; Thu, 23 Jan 2020 22:19:58 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iuknz-0005TX-4W for hostap@lists.infradead.org; Thu, 23 Jan 2020 22:18:28 +0000 Received: by mail-pg1-x543.google.com with SMTP id 6so2108394pgk.0 for <hostap@lists.infradead.org>; Thu, 23 Jan 2020 14:18:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eTszK36qj9PT19JEaYYa9vA7w2RmxxiEuyReLjY0ElQ=; b=hDa1vcno4g39WxtkqpcNCkVok5OzIqbFYtVL/GkXn7LwonCg6d+uTPAcKCeKpugDQo OiT8obhA51Aqfj313083HyXWKY9wrzN/hsnS0gw9SG8pHXg3qJGh8f+YeeSMaiWefH83 H1ykW09zXGLw84tpywQwPvClthVFkWvVcaFUc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eTszK36qj9PT19JEaYYa9vA7w2RmxxiEuyReLjY0ElQ=; b=J2lT9YUPj/+NPquwg8U6t4hYznLudj8FDbWNkJlpPO1xB4VThiUaf5s1hDZ0E+CJV+ wN0QFWs2zWBB79xS9ufLg0Yh4FHL3KMRbFaIbfuwebwjtUb2U+/4PNz0pJQLkSKl4DOW /ecz8dAeMQ/pH6GnYzAwEIrqkqTBvejGIUBZD9x41qrrAOpLssHR7YDnDGWQ0Li3qzsD VteN61fQf510scAJKK6ff+AV3lcIaAcQhuGLQo1ddM1tCC5DPvaKb/pxslEKUpbqLBhl hgPyWbPujdRb2xV4W27oJLe6QqqjHDPg2Y/lhY3WiTOB1dVP/RWflCxQeF8br0J9uR6A vwrw== X-Gm-Message-State: APjAAAVSBWH84nsDplii3dEwLlV//t/fuhtZXG0DFOSIQZCrVdFC3WZy 3rPcQnFt9aKak9yl6DI4znLWcvTS1LY= X-Google-Smtp-Source: APXvYqyUwmjFEvv/Vy6OwXtvAjg1LePC1WZD4IQ9aOPbFdELE11zegISekCgZv1Hk/BB8OqPVojtTw== X-Received: by 2002:a65:5a8f:: with SMTP id c15mr550257pgt.259.1579817906073; Thu, 23 Jan 2020 14:18:26 -0800 (PST) Received: from localhost ([2620:15c:202:201:2b10:8627:31e7:c5ec]) by smtp.gmail.com with ESMTPSA id y128sm3653628pfg.17.2020.01.23.14.18.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jan 2020 14:18:24 -0800 (PST) From: Matthew Wang <matthewmwang@chromium.org> To: j@w1.fi Subject: [PATCH] scan_est_throughput: use ie_len instead of res->ie_len Date: Thu, 23 Jan 2020 14:18:17 -0800 Message-Id: <20200123221817.199969-1-matthewmwang@chromium.org> X-Mailer: git-send-email 2.25.0.341.g760bfbb309-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200123_141827_203122_B535ACD1 X-CRM114-Status: UNSURE ( 9.92 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:543 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-Mailman-Approved-At: Thu, 23 Jan 2020 14:19:58 -0800 X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <hostap.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/hostap>, <mailto:hostap-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/hostap/> List-Post: <mailto:hostap@lists.infradead.org> List-Help: <mailto:hostap-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/hostap>, <mailto:hostap-request@lists.infradead.org?subject=subscribe> Cc: hostap@lists.infradead.org, Matthew Wang <matthewmwang@chromium.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Hostap" <hostap-bounces@lists.infradead.org> Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
scan_est_throughput: use ie_len instead of res->ie_len
|
expand
|
On Thu, Jan 23, 2020 at 02:18:17PM -0800, Matthew Wang wrote:
> Local variable should be used.
Thanks, applied.
diff --git a/wpa_supplicant/scan.c b/wpa_supplicant/scan.c index c91517a45..17636e3b6 100644 --- a/wpa_supplicant/scan.c +++ b/wpa_supplicant/scan.c @@ -2347,7 +2347,7 @@ void scan_est_throughput(struct wpa_supplicant *wpa_s, if (!ie_len) ie_len = res->beacon_ie_len; res->est_throughput = - wpas_get_est_tpt(wpa_s, ies, res->ie_len, rate, snr); + wpas_get_est_tpt(wpa_s, ies, ie_len, rate, snr); /* TODO: channel utilization and AP load (e.g., from AP Beacon) */ }
Local variable should be used. Fixes: ad06ac0b0 ("Move throughput estimation into a helper function") Signed-off-by: Matthew Wang <matthewmwang@chromium.org> --- wpa_supplicant/scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)