Patchwork [U-Boot] part_efi: fix build warning

login
register
mail settings
Submitter Lei Wen
Date Oct. 31, 2011, 3:07 p.m.
Message ID <1320073625-7544-1-git-send-email-leiwen@marvell.com>
Download mbox | patch
Permalink /patch/122852/
State Rejected
Headers show

Comments

Lei Wen - Oct. 31, 2011, 3:07 p.m.
part_efi.c: In function 'print_part_efi':
part_efi.c:133: warning: passing argument 3 of 'is_gpt_valid' from
incompatible pointer type
part_efi.c:95: note: expected 'struct gpt_header *' but argument is of
type 'struct gpt_header **'
part_efi.c: In function 'get_partition_info_efi':
part_efi.c:172: warning: passing argument 3 of 'is_gpt_valid' from
incompatible pointer type
part_efi.c:95: note: expected 'struct gpt_header *' but argument is of
type 'struct gpt_header **'

Signed-off-by: Lei Wen <leiwen@marvell.com>
---
 disk/part_efi.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Anatolij Gustschin - Oct. 31, 2011, 3:26 p.m.
Hi,

On Mon, 31 Oct 2011 08:07:05 -0700
Lei Wen <leiwen@marvell.com> wrote:

> part_efi.c: In function 'print_part_efi':
> part_efi.c:133: warning: passing argument 3 of 'is_gpt_valid' from
> incompatible pointer type
> part_efi.c:95: note: expected 'struct gpt_header *' but argument is of
> type 'struct gpt_header **'
> part_efi.c: In function 'get_partition_info_efi':
> part_efi.c:172: warning: passing argument 3 of 'is_gpt_valid' from
> incompatible pointer type
> part_efi.c:95: note: expected 'struct gpt_header *' but argument is of
> type 'struct gpt_header **'
> 
> Signed-off-by: Lei Wen <leiwen@marvell.com>
> ---
>  disk/part_efi.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

A patch for this bug already exists: [1].

Thanks anyway,
Anatolij

[1] http://patchwork.ozlabs.org/patch/122485/

Patch

diff --git a/disk/part_efi.c b/disk/part_efi.c
index e7f2714..ddf80a7 100644
--- a/disk/part_efi.c
+++ b/disk/part_efi.c
@@ -130,7 +130,7 @@  void print_part_efi(block_dev_desc_t * dev_desc)
 	}
 	/* This function validates AND fills in the GPT header and PTE */
 	if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA,
-			 &(gpt_head), &gpt_pte) != 1) {
+			 gpt_head, &gpt_pte) != 1) {
 		printf("%s: *** ERROR: Invalid GPT ***\n", __func__);
 		return;
 	}
@@ -169,7 +169,7 @@  int get_partition_info_efi(block_dev_desc_t * dev_desc, int part,
 
 	/* This function validates AND fills in the GPT header and PTE */
 	if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA,
-			&(gpt_head), &gpt_pte) != 1) {
+			gpt_head, &gpt_pte) != 1) {
 		printf("%s: *** ERROR: Invalid GPT ***\n", __func__);
 		return -1;
 	}