[net-next] soreuseport: Cleanup duplicate initialization of more_reuse->max_socks.
diff mbox series

Message ID 658d70e554ee4206b753cc2014407d95@EX13MTAUWA001.ant.amazon.com
State Changes Requested
Delegated to: David Miller
Headers show
Series
  • [net-next] soreuseport: Cleanup duplicate initialization of more_reuse->max_socks.
Related show

Commit Message

Kuniyuki Iwashima Jan. 23, 2020, 3:52 p.m. UTC
From: Kuniyuki Iwashima <kuniyu@amazon.co.jp>

reuseport_grow() does not need to initialize the more_reuse->max_socks
again. It is already initialized in __reuseport_alloc().

Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
---
net/core/sock_reuseport.c | 1 -
1 file changed, 1 deletion(-)

Comments

David Miller Jan. 25, 2020, 9:29 a.m. UTC | #1
From: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
Date: Thu, 23 Jan 2020 15:52:23 +0000

> diff --git a/net/core/sock_reuseport.c b/net/core/sock_reuseport.c
> index f19f179538b9..91e9f2223c39 100644
> --- a/net/core/sock_reuseport.c
> +++ b/net/core/sock_reuseport.c
> @@ -107,7 +107,6 @@ static struct sock_reuseport *reuseport_grow(struct sock_reuseport *reuse)
> 	if (!more_reuse)
> 		return NULL;
> -	more_reuse->max_socks = more_socks_size;
> 	more_reuse->num_socks = reuse->num_socks;
> 	more_reuse->prog = reuse->prog;
> 	more_reuse->reuseport_id = reuse->reuseport_id;
> --
> 2.17.2

This patch is corrupted.  The context says that there are 7 lines beforehand
and 6 afterwards.  But the hunk shows 6 lines beforehand and 5 afterward.
Kuniyuki Iwashima Jan. 25, 2020, 10:18 a.m. UTC | #2
From: David Miller <davem@davemloft.net>
Date: Sat, 25 Jan 2020 10:29:36 +0100

> This patch is corrupted.  The context says that there are 7 lines beforehand
> and 6 afterwards.  But the hunk shows 6 lines beforehand and 5 afterward.

I am sorry, my mail client dropped the blank line. I will respin this 
patch.

Patch
diff mbox series

diff --git a/net/core/sock_reuseport.c b/net/core/sock_reuseport.c
index f19f179538b9..91e9f2223c39 100644
--- a/net/core/sock_reuseport.c
+++ b/net/core/sock_reuseport.c
@@ -107,7 +107,6 @@  static struct sock_reuseport *reuseport_grow(struct sock_reuseport *reuse)
	if (!more_reuse)
		return NULL;
-	more_reuse->max_socks = more_socks_size;
	more_reuse->num_socks = reuse->num_socks;
	more_reuse->prog = reuse->prog;
	more_reuse->reuseport_id = reuse->reuseport_id;
--
2.17.2