[PULL,11/17] linux-user: Add support for TYPE_LONG and TYPE_ULONG in do_ioctl()
diff mbox series

Message ID 20200123082227.2037994-12-laurent@vivier.eu
State New
Headers show
  • [PULL,01/17] linux-user:Fix align mistake when mmap guest space
Related show

Commit Message

Laurent Vivier Jan. 23, 2020, 8:22 a.m. UTC
From: Filip Bozuta <Filip.Bozuta@rt-rk.com>

Function "do_ioctl()" located in file "syscall.c" was missing
an option for TYPE_LONG and TYPE_ULONG. This caused some ioctls
to not be recognised because they had the third argument that was
of type 'long' or 'unsigned long'.

For example:

Since implemented ioctls RTC_IRQP_SET and RTC_EPOCH_SET
are of type IOW(writing type) that have unsigned long as
their third argument, they were not recognised in QEMU
before the changes of this patch.

Signed-off-by: Filip Bozuta <Filip.Bozuta@rt-rk.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <1579117007-7565-14-git-send-email-Filip.Bozuta@rt-rk.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
 linux-user/syscall.c | 2 ++
 1 file changed, 2 insertions(+)

diff mbox series

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index c5bda60b45de..bd2436b31007 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -5178,6 +5178,8 @@  static abi_long do_ioctl(int fd, int cmd, abi_long arg)
     case TYPE_PTRVOID:
     case TYPE_INT:
+    case TYPE_LONG:
+    case TYPE_ULONG:
         ret = get_errno(safe_ioctl(fd, ie->host_cmd, arg));
     case TYPE_PTR: