Patchwork [U-Boot] Powerpc/DIU: Fixed the 800x600 and 1024x768 resolution bug

login
register
mail settings
Submitter Jerry Huang
Date Oct. 31, 2011, 6:19 a.m.
Message ID <1320041994-28675-1-git-send-email-Chang-Ming.Huang@freescale.com>
Download mbox | patch
Permalink /patch/122754/
State Accepted
Commit 15006cb7db8fc9cbae809746ad7959c9e90cca1d
Delegated to: Anatolij Gustschin
Headers show

Comments

Jerry Huang - Oct. 31, 2011, 6:19 a.m.
From: Jerry Huang <Chang-Ming.Huang@freescale.com>

When the resolution is set to 800x600 and 1024x768,
but, the driver will use 1280x1024 resolution to set the DIU register

Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
---
 drivers/video/fsl_diu_fb.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Tabi Timur-B04825 - Oct. 31, 2011, 1:31 p.m.
On Mon, Oct 31, 2011 at 1:19 AM,  <Chang-Ming.Huang@freescale.com> wrote:
> From: Jerry Huang <Chang-Ming.Huang@freescale.com>
>
> When the resolution is set to 800x600 and 1024x768,
> but, the driver will use 1280x1024 resolution to set the DIU register
>
> Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>

Acked-by: Timur Tabi <timur@freescale.com>

Thanks, Jerry.  I'm amazed that I didn't notice this mistake earlier.
Anatolij Gustschin - Oct. 31, 2011, 7:32 p.m.
On Mon, 31 Oct 2011 14:19:54 +0800
<Chang-Ming.Huang@freescale.com> wrote:

> From: Jerry Huang <Chang-Ming.Huang@freescale.com>
> 
> When the resolution is set to 800x600 and 1024x768,
> but, the driver will use 1280x1024 resolution to set the DIU register
> 
> Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
> ---
>  drivers/video/fsl_diu_fb.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Applied to u-boot-video/master, thanks!

Anatolij

Patch

diff --git a/drivers/video/fsl_diu_fb.c b/drivers/video/fsl_diu_fb.c
index e1d6c26..7cb8cb6 100644
--- a/drivers/video/fsl_diu_fb.c
+++ b/drivers/video/fsl_diu_fb.c
@@ -296,8 +296,10 @@  int fsl_diu_init(u16 xres, u16 yres, u32 pixel_format, int gamma_fix)
 		break;
 	case RESOLUTION(800, 600):
 		fsl_diu_mode_db = &fsl_diu_mode_800_600;
+		break;
 	case RESOLUTION(1024, 768):
 		fsl_diu_mode_db = &fsl_diu_mode_1024_768;
+		break;
 	case RESOLUTION(1280, 1024):
 		fsl_diu_mode_db = &fsl_diu_mode_1280_1024;
 		break;