Patchwork [U-Boot,V2] ARM: re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board

login
register
mail settings
Submitter Jens Scharsig
Date Oct. 31, 2011, 7:26 a.m.
Message ID <1320045966-25187-1-git-send-email-js_at_ng@scharsoft.de>
Download mbox | patch
Permalink /patch/122752/
State Superseded
Headers show

Comments

Jens Scharsig - Oct. 31, 2011, 7:26 a.m.
* re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board

Signed-off-by: Jens Scharsig <js_at_ng@scharsoft.de>
---
 include/configs/eb_cpux9k2.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Igor Grinberg - Oct. 31, 2011, 7:46 a.m.
Hi Jens,

On 10/31/11 09:26, Jens Scharsig wrote:
> 
> * re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board
> 
> Signed-off-by: Jens Scharsig <js_at_ng@scharsoft.de>
> ---
>  include/configs/eb_cpux9k2.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/configs/eb_cpux9k2.h b/include/configs/eb_cpux9k2.h
> index 4324172..ad51906 100644
> --- a/include/configs/eb_cpux9k2.h
> +++ b/include/configs/eb_cpux9k2.h
> @@ -41,6 +41,8 @@
>  #define CONFIG_MISC_INIT_R
>  #define CONFIG_BOARD_EARLY_INIT_F
>  
> +#define MACH_TYPE_EB_CPUX9K2           1977
> +

While you are at it, probably, it will be a good time
to switch to the new standard and use the CONFIG_MACH_TYPE
option. Please, read the README file.

>  /*--------------------------------------------------------------------------*/
>  #define CONFIG_SYS_TEXT_BASE 		0x00000000
>  #define CONFIG_SYS_LOAD_ADDR		0x21000000  /* default load address */
Jens Scharsig - Oct. 31, 2011, 8:27 a.m.
Am 2011-10-31 08:46, schrieb Igor Grinberg:
> Hi Jens,
>> @@ -41,6 +41,8 @@
>>  #define CONFIG_MISC_INIT_R
>>  #define CONFIG_BOARD_EARLY_INIT_F
>>  
>> +#define MACH_TYPE_EB_CPUX9K2           1977
>> +
> 
> While you are at it, probably, it will be a good time
> to switch to the new standard and use the CONFIG_MACH_TYPE
> option. Please, read the README file.
> 
>>  /*--------------------------------------------------------------------------*/
>>  #define CONFIG_SYS_TEXT_BASE 		0x00000000
>>  #define CONFIG_SYS_LOAD_ADDR		0x21000000  /* default load address */
> 

Dear Albert ARIBAUD,

What's your opinion?

#define MACH_TYPE_EB_CPUX9K2 1977

or

#define CONFIG_MACH_TYPE 1977

Regards Jens
Igor Grinberg - Oct. 31, 2011, 8:48 a.m.
Hi Jens,

On 10/31/11 10:27, Jens Scharsig wrote:
> Am 2011-10-31 08:46, schrieb Igor Grinberg:
>> Hi Jens,
>>> @@ -41,6 +41,8 @@
>>>  #define CONFIG_MISC_INIT_R
>>>  #define CONFIG_BOARD_EARLY_INIT_F
>>>  
>>> +#define MACH_TYPE_EB_CPUX9K2           1977
>>> +
>>
>> While you are at it, probably, it will be a good time
>> to switch to the new standard and use the CONFIG_MACH_TYPE
>> option. Please, read the README file.
>>
>>>  /*--------------------------------------------------------------------------*/
>>>  #define CONFIG_SYS_TEXT_BASE 		0x00000000
>>>  #define CONFIG_SYS_LOAD_ADDR		0x21000000  /* default load address */
>>
> 
> Dear Albert ARIBAUD,
> 
> What's your opinion?
> 
> #define MACH_TYPE_EB_CPUX9K2 1977
> 
> or
> 
> #define CONFIG_MACH_TYPE 1977

It should be both:

#define MACH_TYPE_EB_CPUX9K2 1977

and then:

#define CONFIG_MACH_TYPE MACH_TYPE_EB_CPUX9K2
Albert ARIBAUD - Nov. 5, 2011, 10:52 a.m.
Le 31/10/2011 09:48, Igor Grinberg a écrit :
> Hi Jens,
>
> On 10/31/11 10:27, Jens Scharsig wrote:
>> Am 2011-10-31 08:46, schrieb Igor Grinberg:
>>> Hi Jens,
>>>> @@ -41,6 +41,8 @@
>>>>   #define CONFIG_MISC_INIT_R
>>>>   #define CONFIG_BOARD_EARLY_INIT_F
>>>>
>>>> +#define MACH_TYPE_EB_CPUX9K2           1977
>>>> +
>>>
>>> While you are at it, probably, it will be a good time
>>> to switch to the new standard and use the CONFIG_MACH_TYPE
>>> option. Please, read the README file.
>>>
>>>>   /*--------------------------------------------------------------------------*/
>>>>   #define CONFIG_SYS_TEXT_BASE 		0x00000000
>>>>   #define CONFIG_SYS_LOAD_ADDR		0x21000000  /* default load address */
>>>
>>
>> Dear Albert ARIBAUD,
>>
>> What's your opinion?
>>
>> #define MACH_TYPE_EB_CPUX9K2 1977
>>
>> or
>>
>> #define CONFIG_MACH_TYPE 1977
>
> It should be both:
>
> #define MACH_TYPE_EB_CPUX9K2 1977
>
> and then:
>
> #define CONFIG_MACH_TYPE MACH_TYPE_EB_CPUX9K2

Correct.

Amicalement,

Patch

diff --git a/include/configs/eb_cpux9k2.h b/include/configs/eb_cpux9k2.h
index 4324172..ad51906 100644
--- a/include/configs/eb_cpux9k2.h
+++ b/include/configs/eb_cpux9k2.h
@@ -41,6 +41,8 @@ 
 #define CONFIG_MISC_INIT_R
 #define CONFIG_BOARD_EARLY_INIT_F
 
+#define MACH_TYPE_EB_CPUX9K2           1977
+
 /*--------------------------------------------------------------------------*/
 #define CONFIG_SYS_TEXT_BASE 		0x00000000
 #define CONFIG_SYS_LOAD_ADDR		0x21000000  /* default load address */