| Message ID | 1579702003-5122-1-git-send-email-damjan.skvarc@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Ilya Maximets |
| Headers | show |
| Series | [ovs-dev,1/1] dpif: fix memory leak while dumping dpif flows | expand |
> leak was detected by running test: "ofproto-dpif - balance-tcp bonding" > > Signed-off-by: Damijan Skvarc <damjan.skvarc@gmail.com> Thanks! Applied to master and branch-2.13. Best regards, Ilya maximets.
thanks for review, br damijan On Thu, 23 Jan 2020, 11:06 Ilya Maximets, <i.maximets@ovn.org> wrote: > > leak was detected by running test: "ofproto-dpif - balance-tcp bonding" > > > > Signed-off-by: Damijan Skvarc <damjan.skvarc@gmail.com> > > > Thanks! Applied to master and branch-2.13. > > Best regards, Ilya maximets. > >
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index d3cb392..e8c851e 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -6281,7 +6281,8 @@ ofproto_unixctl_dpif_dump_flows(struct unixctl_conn *conn, flow_dump_thread = dpif_flow_dump_thread_create(flow_dump); while (dpif_flow_dump_next(flow_dump_thread, &f, 1)) { struct flow flow; - + /* no need for extra info */ + free(f.attrs.dp_extra_info); if ((odp_flow_key_to_flow(f.key, f.key_len, &flow, NULL) == ODP_FIT_ERROR) || (xlate_lookup_ofproto(ofproto->backer, &flow, NULL, NULL)
leak was detected by running test: "ofproto-dpif - balance-tcp bonding" Signed-off-by: Damijan Skvarc <damjan.skvarc@gmail.com> --- ofproto/ofproto-dpif.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)