Patchwork [1/3] ext4: move variables to its scope

login
register
mail settings
Submitter Yongqiang Yang
Date Oct. 30, 2011, 11:30 a.m.
Message ID <1319974203-2625-1-git-send-email-xiaoqiangnk@gmail.com>
Download mbox | patch
Permalink /patch/122606/
State Accepted
Headers show

Comments

Yongqiang Yang - Oct. 30, 2011, 11:30 a.m.
Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
---
 fs/ext4/inode.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Coly Li - Oct. 30, 2011, 2 p.m.
On 2011年10月30日 19:30, Yongqiang Yang Wrote:
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
> ---
>  fs/ext4/inode.c |    3 ++-
[snip]

Yongqiang,

Could you please to add any commit log to this patch set ? That could be much helpful then only one line SOB :-)

Thanks.
Theodore Ts'o - Oct. 31, 2011, 10:12 p.m.
On Sun, Oct 30, 2011 at 07:30:01PM +0800, Yongqiang Yang wrote:
> 
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>

Thanks, applied.

				- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index e4b26fa..3c4a9d5 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -3182,7 +3182,6 @@  int ext4_discard_partial_page_buffers_no_lock(handle_t *handle,
 	ext4_fsblk_t index = from >> PAGE_CACHE_SHIFT;
 	unsigned int offset = from & (PAGE_CACHE_SIZE-1);
 	unsigned int blocksize, max, pos;
-	unsigned int end_of_block, range_to_discard;
 	ext4_lblk_t iblock;
 	struct buffer_head *bh;
 	int err = 0;
@@ -3234,6 +3233,8 @@  int ext4_discard_partial_page_buffers_no_lock(handle_t *handle,
 
 	pos = offset;
 	while (pos < offset + length) {
+		unsigned int end_of_block, range_to_discard;
+
 		err = 0;
 
 		/* The length of space left to zero and unmap */