Patchwork [U-Boot] tx25: re-add MACH_TYPE_TX25

login
register
mail settings
Submitter Wolfgang Denk
Date Oct. 30, 2011, 1:18 p.m.
Message ID <1319980721-6615-1-git-send-email-wd@denx.de>
Download mbox | patch
Permalink /patch/122605/
State Superseded
Delegated to: Stefano Babic
Headers show

Comments

Wolfgang Denk - Oct. 30, 2011, 1:18 p.m.
Signed-off-by: Wolfgang Denk <wd@denx.de>
cc: Stefano Babic <sbabic@denx.de>
---
 include/configs/tx25.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Stefano Babic - Oct. 30, 2011, 8:17 p.m.
On 10/30/2011 02:18 PM, Wolfgang Denk wrote:
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> cc: Stefano Babic <sbabic@denx.de>
> ---
>  include/configs/tx25.h |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/include/configs/tx25.h b/include/configs/tx25.h
> index 8cb57ff..39d551e 100644
> --- a/include/configs/tx25.h
> +++ b/include/configs/tx25.h
> @@ -29,6 +29,10 @@
>  #define CONFIG_MX25_CLK32		32000	/* OSC32K frequency */
>  #define CONFIG_SYS_HZ			1000
>  
> +#ifndef MACH_TYPE_TX25
> +#define MACH_TYPE_TX25			2177
> +#endif
> +
>  #define	CONFIG_SYS_MONITOR_LEN		(256 << 10)	/* 256 kB for U-Boot */
>  

Thanks for reporting, but....

..I have already sent a fix for this last week, using also the standard
mechanism in arch/arm/lib/board.c to set the mach-id:

http://patchwork.ozlabs.org/patch/122357/

As a fix, I have already applied it and I inserted it in my pull-request
ro Albert. The patch is already in u-boot-arm and as far as I have
tested, there should be no broken IMX boards due to missing mach type.

Best regards,
Stefano Babic
Wolfgang Denk - Oct. 30, 2011, 8:19 p.m.
Dear Stefano,

In message <4EADB0D2.8010000@denx.de> you wrote:
>
> Thanks for reporting, but....
> 
> ..I have already sent a fix for this last week, using also the standard
> mechanism in arch/arm/lib/board.c to set the mach-id:

Sorry, I missed that.  Thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/include/configs/tx25.h b/include/configs/tx25.h
index 8cb57ff..39d551e 100644
--- a/include/configs/tx25.h
+++ b/include/configs/tx25.h
@@ -29,6 +29,10 @@ 
 #define CONFIG_MX25_CLK32		32000	/* OSC32K frequency */
 #define CONFIG_SYS_HZ			1000
 
+#ifndef MACH_TYPE_TX25
+#define MACH_TYPE_TX25			2177
+#endif
+
 #define	CONFIG_SYS_MONITOR_LEN		(256 << 10)	/* 256 kB for U-Boot */
 
 /* NAND BOOT is the only boot method */